From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Hisashi T Fujinaka <htodd@twofifty.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Greg Rose <gregory.v.rose@intel.com>,
Matthew Vick <matthew.vick@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Mitch Williams <mitch.a.williams@intel.com>,
Linux NICS <linux.nics@intel.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e1000: remove unused variables
Date: Mon, 1 Dec 2014 10:24:46 +0530 [thread overview]
Message-ID: <20141201045446.GA3277@sudip-PC> (raw)
In-Reply-To: <1417311913.7215.111.camel@decadent.org.uk>
On Sun, Nov 30, 2014 at 01:45:13AM +0000, Ben Hutchings wrote:
> On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote:
> > I'm pretty sure those double reads are there for a reason, so most of
> > this I'm going to have to check on Monday. We have a long holiday
> > weekend here in the US.
> [...]
>
> If there were double register reads being replaced with single register
> reads, I'd agree this was likely to introduce a regression. But all I
> see is var = er32(REG) being changed to er32(REG).
no, double register reads are not modified. only the unused variables are removed.
thanks
sudip
>
> Ben.
>
> --
> Ben Hutchings
> The world is coming to an end. Please log off.
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Linux NICS <linux.nics@intel.com>,
e1000-devel@lists.sourceforge.net,
Bruce Allan <bruce.w.allan@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
linux-kernel@vger.kernel.org,
John Ronciak <john.ronciak@intel.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] e1000: remove unused variables
Date: Mon, 1 Dec 2014 10:24:46 +0530 [thread overview]
Message-ID: <20141201045446.GA3277@sudip-PC> (raw)
In-Reply-To: <1417311913.7215.111.camel@decadent.org.uk>
On Sun, Nov 30, 2014 at 01:45:13AM +0000, Ben Hutchings wrote:
> On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote:
> > I'm pretty sure those double reads are there for a reason, so most of
> > this I'm going to have to check on Monday. We have a long holiday
> > weekend here in the US.
> [...]
>
> If there were double register reads being replaced with single register
> reads, I'd agree this was likely to introduce a regression. But all I
> see is var = er32(REG) being changed to er32(REG).
no, double register reads are not modified. only the unused variables are removed.
thanks
sudip
>
> Ben.
>
> --
> Ben Hutchings
> The world is coming to an end. Please log off.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2014-12-01 4:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 5:22 [PATCH] e1000: remove unused variables Sudip Mukherjee
2014-11-27 5:22 ` Sudip Mukherjee
2014-11-27 5:59 ` Hisashi T Fujinaka
2014-11-27 13:07 ` Sudip Mukherjee
2014-11-28 23:28 ` Florian Fainelli
2014-11-28 23:28 ` Florian Fainelli
2014-11-29 11:01 ` Lino Sanfilippo
2014-11-29 11:01 ` Lino Sanfilippo
2014-11-30 1:45 ` Ben Hutchings
2014-11-30 1:45 ` Ben Hutchings
2014-12-01 4:54 ` Sudip Mukherjee [this message]
2014-12-01 4:54 ` Sudip Mukherjee
2014-12-01 18:56 ` [linux-nics] " Fujinaka, Todd
2014-12-02 14:24 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201045446.GA3277@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=ben@decadent.org.uk \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=htodd@twofifty.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.