All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/3] i8k: Rework error retries
Date: Mon, 01 Dec 2014 19:45:59 +0000	[thread overview]
Message-ID: <201412012045.59404@pali> (raw)
In-Reply-To: <1417381240-7641-2-git-send-email-linux@roeck-us.net>


[-- Attachment #1.1: Type: Text/Plain, Size: 855 bytes --]

On Sunday 30 November 2014 22:00:39 Guenter Roeck wrote:
> Instead of returning a previous value if the SMM code returns
> an error when trying to read a temperature, retry once.
> If that fails again, return -ENODATA. Also return -ENODATA if
> an attempt is made to read the GPU temperature but the GPU is
> currently turned off.
> 
> Drop the I8K_TEMPERATURE_BUG definition and handle the related
> bug unconditionally.
> 
> Cc: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Applies on top of Pali's patch series.
> 
>  drivers/char/i8k.c | 47
> ++++++++++++++++++++++++----------------------- 1 file
> changed, 24 insertions(+), 23 deletions(-)
> 

Working fine GPU temp (turned on or off).

Tested-by: Pali Rohár <pali.rohar@gmail.com>

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] i8k: Rework error retries
Date: Mon, 1 Dec 2014 20:45:59 +0100	[thread overview]
Message-ID: <201412012045.59404@pali> (raw)
In-Reply-To: <1417381240-7641-2-git-send-email-linux@roeck-us.net>

[-- Attachment #1: Type: Text/Plain, Size: 855 bytes --]

On Sunday 30 November 2014 22:00:39 Guenter Roeck wrote:
> Instead of returning a previous value if the SMM code returns
> an error when trying to read a temperature, retry once.
> If that fails again, return -ENODATA. Also return -ENODATA if
> an attempt is made to read the GPU temperature but the GPU is
> currently turned off.
> 
> Drop the I8K_TEMPERATURE_BUG definition and handle the related
> bug unconditionally.
> 
> Cc: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Applies on top of Pali's patch series.
> 
>  drivers/char/i8k.c | 47
> ++++++++++++++++++++++++----------------------- 1 file
> changed, 24 insertions(+), 23 deletions(-)
> 

Working fine GPU temp (turned on or off).

Tested-by: Pali Rohár <pali.rohar@gmail.com>

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2014-12-01 19:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 21:00 [lm-sensors] [PATCH 1/3] MAINTAINERS: Fix up entry for Dell laptop SMM driver Guenter Roeck
2014-11-30 21:00 ` Guenter Roeck
2014-11-30 21:00 ` [lm-sensors] [PATCH 2/3] i8k: Rework error retries Guenter Roeck
2014-11-30 21:00   ` Guenter Roeck
2014-12-01 19:45   ` Pali Rohár [this message]
2014-12-01 19:45     ` Pali Rohár
2014-12-01 20:15     ` [lm-sensors] " Guenter Roeck
2014-12-01 20:15       ` Guenter Roeck
2014-11-30 21:00 ` [lm-sensors] [PATCH 3/3] i8k: Add support for Dell XPS 13 Guenter Roeck
2014-11-30 21:00   ` Guenter Roeck
2014-12-01 12:36   ` [lm-sensors] " Jean Delvare
2014-12-01 12:36     ` Jean Delvare
2014-12-01 16:22     ` Guenter Roeck
2014-12-01 16:22       ` Guenter Roeck
2014-12-01 11:34 ` [lm-sensors] [PATCH 1/3] MAINTAINERS: Fix up entry for Dell laptop SMM driver Jean Delvare
2014-12-01 11:34   ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201412012045.59404@pali \
    --to=pali.rohar@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.