All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] tools/hotplug: update systemd dependency to use service instead of socket
Date: Wed, 3 Dec 2014 10:52:52 +0100	[thread overview]
Message-ID: <20141203095252.GA25950@aepfle.de> (raw)
In-Reply-To: <1417534763-25053-1-git-send-email-olaf@aepfle.de>

On Tue, Dec 02, Olaf Hering wrote:

> Since commit 4542ae340d75bd6319e3fcd94e6c9336e210aeef ("tools/hotplug:
> systemd xenstored dependencies") all service files use the .socket unit
> as startup dependency. While this happens to work for boot it fails for
> shutdown because a .socket does not seem to enforce ordering. When
> xendomains.service runs during shutdown then systemd will stop
> xenstored.service at the same time.
> 
> Change all "xenstored.socket" to "xenstored.service" to let systemd know
> that xenstored has to be shutdown after everything else.
> 
> Reported-by: Mark Pryor <tlviewer@yahoo.com>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>

Tested-by: Olaf Hering <olaf@aepfle.de>

I was able to reproduce the hang on shutdown with openSUSE 13.1. This
patch fixes the hang.

Olaf

      parent reply	other threads:[~2014-12-03  9:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 15:39 [PATCH] tools/hotplug: update systemd dependency to use service instead of socket Olaf Hering
2014-12-02 15:44 ` Ian Campbell
2014-12-02 18:42   ` Konrad Rzeszutek Wilk
2014-12-02 18:51     ` M A Young
2014-12-02 20:42       ` Konrad Rzeszutek Wilk
2014-12-04 13:25         ` Ian Campbell
2014-12-03 16:54       ` Konrad Rzeszutek Wilk
2014-12-03 21:11         ` M A Young
2014-12-04  7:47           ` Olaf Hering
2014-12-05  2:15             ` Konrad Rzeszutek Wilk
2014-12-05  7:47               ` Olaf Hering
2014-12-05  8:03                 ` Olaf Hering
2014-12-05  8:28                   ` Olaf Hering
2014-12-05 16:15                     ` Konrad Rzeszutek Wilk
2014-12-08  9:31                       ` Olaf Hering
2014-12-03  9:52 ` Olaf Hering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203095252.GA25950@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.