Re: [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

[Olaf Hering <olaf@aepfle.de>]

On Fri, Dec 05, Olaf Hering wrote:

> On Thu, Dec 04, Konrad Rzeszutek Wilk wrote:
> 
> > On Thu, Dec 04, 2014 at 08:47:56AM +0100, Olaf Hering wrote:
> > > Is that something the sysadmin has to adjust, or should the xen source
> > > provide proper values?
> > It would be rather cumbersome if the sysadmin had to adjust it. The goal
> > here would be that distros could use it and package it neatly so that it
> > works out of the box.
> > 
> > What are the proper values in SuSE?
> 
> I have no idea, we dont run with selinux. At least not per default.
> So what is supposed to be there, why does it happen to work for me?
> 
> And if there are changes required to the config file, they should be
> passed in via configure instead of doing a patch.

So looking again at
tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in it seems that it
happens to work for me because XENSTORED_MOUNT_CTX is set within that
file. So if something happens to need a different value for
XENSTORED_MOUNT_CTX it has to be provided in the to-be-created config
file: EnvironmentFile=-@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xenstored
This config file is not part of xen. 

Does the current state of xen-4.5 (like "make rpmball") not work out of
the box on Fedora or anything that uses selinux? If thats the case it
should probably be covered in the INSTALL file.

Olaf