From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org, quentin.lambert@inria.fr
Subject: Re: [patch] mpt2sas: issue reset is not uninitialized
Date: Wed, 03 Dec 2014 11:03:25 +0000 [thread overview]
Message-ID: <20141203110325.GL4994@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.10.1412031135410.2373@hadrien>
On Wed, Dec 03, 2014 at 11:36:20AM +0100, Julia Lawall wrote:
> On Wed, 3 Dec 2014, Dan Carpenter wrote:
>
> > The issue_reset variables were never set to zero. This bug was found
> > with static analysis.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > index 58e4521..98bd546 100644
> > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > @@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
> > u16 smid;
> > u32 ioc_state;
> > unsigned long timeleft;
> > - u8 issue_reset;
> > + bool issue_reset = 0;
>
> Why not false if it is going to be a boolean?
>
Good point. I'll send a v2 for these tomorrow.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org, quentin.lambert@inria.fr
Subject: Re: [patch] mpt2sas: issue reset is not uninitialized
Date: Wed, 3 Dec 2014 14:03:25 +0300 [thread overview]
Message-ID: <20141203110325.GL4994@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.10.1412031135410.2373@hadrien>
On Wed, Dec 03, 2014 at 11:36:20AM +0100, Julia Lawall wrote:
> On Wed, 3 Dec 2014, Dan Carpenter wrote:
>
> > The issue_reset variables were never set to zero. This bug was found
> > with static analysis.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > index 58e4521..98bd546 100644
> > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > @@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
> > u16 smid;
> > u32 ioc_state;
> > unsigned long timeleft;
> > - u8 issue_reset;
> > + bool issue_reset = 0;
>
> Why not false if it is going to be a boolean?
>
Good point. I'll send a v2 for these tomorrow.
regards,
dan carpenter
next prev parent reply other threads:[~2014-12-03 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 10:09 [patch] mpt2sas: issue reset is not uninitialized Dan Carpenter
2014-12-03 10:09 ` Dan Carpenter
2014-12-03 10:36 ` Julia Lawall
2014-12-03 10:36 ` Julia Lawall
2014-12-03 11:03 ` Dan Carpenter [this message]
2014-12-03 11:03 ` Dan Carpenter
2014-12-03 14:14 ` walter harms
2014-12-03 14:14 ` walter harms
2014-12-03 14:18 ` Dan Carpenter
2014-12-03 14:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203110325.GL4994@mwanda \
--to=dan.carpenter@oracle.com \
--cc=JBottomley@parallels.com \
--cc=MPT-FusionLinux.pdl@avagotech.com \
--cc=abhijit.mahajan@avagotech.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nagalakshmi.nandigama@avagotech.com \
--cc=praveen.krishnamoorthy@avagotech.com \
--cc=quentin.lambert@inria.fr \
--cc=sreekanth.reddy@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.