From: Darren Hart <dvhart@infradead.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver
Date: Wed, 3 Dec 2014 05:43:23 -0800 [thread overview]
Message-ID: <20141203134323.GI75099@vmdeb7> (raw)
In-Reply-To: <201411230338.26239@pali>
On Sun, Nov 23, 2014 at 03:38:26AM +0100, Pali Rohár wrote:
> Oops, I lost this mail somewhere...
>
> I copied these ids from windows driver inf file. I did not tested
> them because I do not have machine which reports these ids. It
> looks like all SMOXX devices have same acpi structure (one IRQ).
> So adding ids could not break anything (if acpi device will not
> have for some reason IRQ specified, device probe function will
> fail).
Please resend with a complete message body and the typo fix below.
>
> On Monday 29 September 2014 22:56:04 Darren Hart wrote:
> > On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote:
> >
> > Please see Documentation/SubmittingPatches, 15) The canonical
> > patch format, and provide a complete message body.
> >
> > Have you validated each of the 6 ACPI IDs added to the driver?
> >
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > ---
> > >
> > > drivers/platform/x86/Kconfig | 4 ++--
> > > drivers/platform/x86/dell-smo8800.c | 10 ++++++++--
> > > 2 files changed, 10 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/platform/x86/Kconfig
> > > b/drivers/platform/x86/Kconfig index 3bbcbf1..ba9ee4f
> > > 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -128,10 +128,10 @@ config DELL_WMI_AIO
> > >
> > > be called dell-wmi-aio.
> > >
> > > config DELL_SMO8800
> > >
> > > - tristate "Dell Latitude freefall driver (ACPI
> > > SMO8800/SMO8810)" + tristate "Dell Latitude freefall driver
> > > (ACPI SMO88XX)"
> > >
> > > depends on ACPI
> > > ---help---
> > >
> > > - Say Y here if you want to support SMO8800/SMO8810
> > > freefall device + Say Y here if you want to support
> > > SMO88XX freefall device
> >
> > "devices" now that multiple are supported.
> >
> > Thanks,
>
> --
> Pali Rohár
> pali.rohar@gmail.com
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver
Date: Wed, 3 Dec 2014 05:43:23 -0800 [thread overview]
Message-ID: <20141203134323.GI75099@vmdeb7> (raw)
In-Reply-To: <201411230338.26239@pali>
On Sun, Nov 23, 2014 at 03:38:26AM +0100, Pali Rohár wrote:
> Oops, I lost this mail somewhere...
>
> I copied these ids from windows driver inf file. I did not tested
> them because I do not have machine which reports these ids. It
> looks like all SMOXX devices have same acpi structure (one IRQ).
> So adding ids could not break anything (if acpi device will not
> have for some reason IRQ specified, device probe function will
> fail).
Please resend with a complete message body and the typo fix below.
>
> On Monday 29 September 2014 22:56:04 Darren Hart wrote:
> > On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote:
> >
> > Please see Documentation/SubmittingPatches, 15) The canonical
> > patch format, and provide a complete message body.
> >
> > Have you validated each of the 6 ACPI IDs added to the driver?
> >
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > ---
> > >
> > > drivers/platform/x86/Kconfig | 4 ++--
> > > drivers/platform/x86/dell-smo8800.c | 10 ++++++++--
> > > 2 files changed, 10 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/platform/x86/Kconfig
> > > b/drivers/platform/x86/Kconfig index 3bbcbf1..ba9ee4f
> > > 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -128,10 +128,10 @@ config DELL_WMI_AIO
> > >
> > > be called dell-wmi-aio.
> > >
> > > config DELL_SMO8800
> > >
> > > - tristate "Dell Latitude freefall driver (ACPI
> > > SMO8800/SMO8810)" + tristate "Dell Latitude freefall driver
> > > (ACPI SMO88XX)"
> > >
> > > depends on ACPI
> > > ---help---
> > >
> > > - Say Y here if you want to support SMO8800/SMO8810
> > > freefall device + Say Y here if you want to support
> > > SMO88XX freefall device
> >
> > "devices" now that multiple are supported.
> >
> > Thanks,
>
> --
> Pali Rohár
> pali.rohar@gmail.com
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2014-12-05 3:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 12:45 [PATCH] dell-smo8800: Add more acpi ids and change description of driver Pali Rohár
2014-09-29 20:56 ` Darren Hart
2014-09-29 20:56 ` Darren Hart
2014-11-23 2:38 ` Pali Rohár
2014-12-03 13:43 ` Darren Hart [this message]
2014-12-03 13:43 ` Darren Hart
2014-12-05 12:05 ` [PATCH v2] dell-smo8800: Add more ACPI " Pali Rohár
2014-12-05 12:05 ` Pali Rohár
2014-12-03 18:07 ` Darren Hart
2014-12-03 18:07 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203134323.GI75099@vmdeb7 \
--to=dvhart@infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.