All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Rik van Riel <riel@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>, Ingo Molnar <mingo@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Dave Jones <davej@redhat.com>,
	LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>,
	Kirill Shutemov <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa
Date: Wed, 3 Dec 2014 15:52:43 +0000	[thread overview]
Message-ID: <20141203155242.GE6043@suse.de> (raw)
In-Reply-To: <87lhmobvuu.fsf@linux.vnet.ibm.com>

On Wed, Dec 03, 2014 at 08:53:37PM +0530, Aneesh Kumar K.V wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> 
> > On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote:
> >> Now, hash_preload can possibly insert an hpte in hash page table even if
> >> the access is not allowed by the pte permissions. But i guess even that
> >> is ok. because we will fault again, end-up calling hash_page_mm where we
> >> handle that part correctly.
> >
> > I think we need a test case...
> >
> 
> I ran the subpageprot test that Paul had written. I modified it to ran
> with selftest. 
> 

It's implied but can I assume it passed? If so, Ben and Paul, can I
consider the series to be acked by you other than the minor comment
updates?

Thanks.

-- 
Mel Gorman
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>,
	Hugh Dickins <hughd@google.com>, Dave Jones <davej@redhat.com>,
	Rik van Riel <riel@redhat.com>, Ingo Molnar <mingo@redhat.com>,
	Kirill Shutemov <kirill.shutemov@linux.intel.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	Paul Mackerras <paulus@samba.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa
Date: Wed, 3 Dec 2014 15:52:43 +0000	[thread overview]
Message-ID: <20141203155242.GE6043@suse.de> (raw)
In-Reply-To: <87lhmobvuu.fsf@linux.vnet.ibm.com>

On Wed, Dec 03, 2014 at 08:53:37PM +0530, Aneesh Kumar K.V wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> 
> > On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote:
> >> Now, hash_preload can possibly insert an hpte in hash page table even if
> >> the access is not allowed by the pte permissions. But i guess even that
> >> is ok. because we will fault again, end-up calling hash_page_mm where we
> >> handle that part correctly.
> >
> > I think we need a test case...
> >
> 
> I ran the subpageprot test that Paul had written. I modified it to ran
> with selftest. 
> 

It's implied but can I assume it passed? If so, Ben and Paul, can I
consider the series to be acked by you other than the minor comment
updates?

Thanks.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>,
	Hugh Dickins <hughd@google.com>, Dave Jones <davej@redhat.com>,
	Rik van Riel <riel@redhat.com>, Ingo Molnar <mingo@redhat.com>,
	Kirill Shutemov <kirill.shutemov@linux.intel.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	Paul Mackerras <paulus@samba.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa
Date: Wed, 3 Dec 2014 15:52:43 +0000	[thread overview]
Message-ID: <20141203155242.GE6043@suse.de> (raw)
In-Reply-To: <87lhmobvuu.fsf@linux.vnet.ibm.com>

On Wed, Dec 03, 2014 at 08:53:37PM +0530, Aneesh Kumar K.V wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> 
> > On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote:
> >> Now, hash_preload can possibly insert an hpte in hash page table even if
> >> the access is not allowed by the pte permissions. But i guess even that
> >> is ok. because we will fault again, end-up calling hash_page_mm where we
> >> handle that part correctly.
> >
> > I think we need a test case...
> >
> 
> I ran the subpageprot test that Paul had written. I modified it to ran
> with selftest. 
> 

It's implied but can I assume it passed? If so, Ben and Paul, can I
consider the series to be acked by you other than the minor comment
updates?

Thanks.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2014-12-03 15:52 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 13:57 [PATCH 0/10] Replace _PAGE_NUMA with PAGE_NONE protections v3 Mel Gorman
2014-11-21 13:57 ` Mel Gorman
2014-11-21 13:57 ` Mel Gorman
2014-11-21 13:57 ` [PATCH 01/10] mm: numa: Do not dereference pmd outside of the lock during NUMA hinting fault Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57 ` [PATCH 02/10] mm: Add p[te|md] protnone helpers for use by NUMA balancing Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-12-01 22:38   ` Benjamin Herrenschmidt
2014-12-01 22:38     ` Benjamin Herrenschmidt
2014-12-01 22:38     ` Benjamin Herrenschmidt
2014-12-02 10:12     ` Mel Gorman
2014-12-02 10:12       ` Mel Gorman
2014-12-02 10:12       ` Mel Gorman
2014-11-21 13:57 ` [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-12-01 22:42   ` Benjamin Herrenschmidt
2014-12-01 22:42     ` Benjamin Herrenschmidt
2014-12-01 22:42     ` Benjamin Herrenschmidt
2014-12-02  7:27     ` Aneesh Kumar K.V
2014-12-02  7:27       ` Aneesh Kumar K.V
2014-12-02  7:27       ` Aneesh Kumar K.V
2014-12-02 20:11       ` Benjamin Herrenschmidt
2014-12-02 20:11         ` Benjamin Herrenschmidt
2014-12-02 20:11         ` Benjamin Herrenschmidt
2014-12-03 15:23         ` Aneesh Kumar K.V
2014-12-03 15:23           ` Aneesh Kumar K.V
2014-12-03 15:23           ` Aneesh Kumar K.V
2014-12-03 15:52           ` Mel Gorman [this message]
2014-12-03 15:52             ` Mel Gorman
2014-12-03 15:52             ` Mel Gorman
2014-12-03 17:20             ` Aneesh Kumar K.V
2014-12-03 17:20               ` Aneesh Kumar K.V
2014-12-03 17:20               ` Aneesh Kumar K.V
2014-12-04 11:17               ` Mel Gorman
2014-12-04 11:17                 ` Mel Gorman
2014-12-04 11:17                 ` Mel Gorman
2014-12-03 21:01             ` Benjamin Herrenschmidt
2014-12-03 21:01               ` Benjamin Herrenschmidt
2014-12-03 21:01               ` Benjamin Herrenschmidt
2014-12-04 11:15               ` Mel Gorman
2014-12-04 11:15                 ` Mel Gorman
2014-12-04 11:15                 ` Mel Gorman
2014-12-01 22:44   ` Benjamin Herrenschmidt
2014-12-01 22:44     ` Benjamin Herrenschmidt
2014-12-01 22:44     ` Benjamin Herrenschmidt
2014-12-02  7:31     ` Aneesh Kumar K.V
2014-12-02  7:31       ` Aneesh Kumar K.V
2014-12-02  7:31       ` Aneesh Kumar K.V
2014-12-02 20:13       ` Benjamin Herrenschmidt
2014-12-02 20:13         ` Benjamin Herrenschmidt
2014-12-02 20:13         ` Benjamin Herrenschmidt
2014-11-21 13:57 ` [PATCH 04/10] ppc64: Add paranoid warnings for unexpected DSISR_PROTFAULT Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57 ` [PATCH 05/10] mm: Convert p[te|md]_mknonnuma and remaining page table manipulations Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57 ` [PATCH 06/10] mm: Remove remaining references to NUMA hinting bits and helpers Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57 ` [PATCH 07/10] mm: numa: Do not trap faults on the huge zero page Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57 ` [PATCH 08/10] x86: mm: Restore original pte_special check Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57 ` [PATCH 09/10] mm: numa: Add paranoid check around pte_protnone_numa Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57 ` [PATCH 10/10] mm: numa: Avoid unnecessary TLB flushes when setting NUMA hinting entries Mel Gorman
2014-11-21 13:57   ` Mel Gorman
2014-11-21 13:57   ` Mel Gorman
  -- strict thread matches above, loose matches on Subject: below --
2015-01-05 10:54 [PATCH 0/10] Replace _PAGE_NUMA with PAGE_NONE protections v5 Mel Gorman
2015-01-05 10:54 ` [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa Mel Gorman
2015-01-05 10:54   ` Mel Gorman
2015-01-05 10:54   ` Mel Gorman
2014-12-04 11:24 [PATCH 0/10] Replace _PAGE_NUMA with PAGE_NONE protections v4 Mel Gorman
2014-12-04 11:24 ` [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa Mel Gorman
2014-12-04 11:24   ` Mel Gorman
2014-12-04 11:24   ` Mel Gorman
2014-11-20 10:19 [PATCH 0/10] Replace _PAGE_NUMA with PAGE_NONE protections v2 Mel Gorman
2014-11-20 10:19 ` [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa Mel Gorman
2014-11-20 10:19   ` Mel Gorman
2014-11-20 10:19   ` Mel Gorman
2014-11-20 10:38   ` David Laight
2014-11-20 10:38     ` David Laight
2014-11-20 10:38     ` David Laight
2014-11-20 10:47     ` Mel Gorman
2014-11-20 10:47       ` Mel Gorman
2014-11-20 10:47       ` Mel Gorman
2014-11-21  5:28   ` Aneesh Kumar K.V
2014-11-21  5:28     ` Aneesh Kumar K.V
2014-11-21  5:28     ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203155242.GE6043@suse.de \
    --to=mgorman@suse.de \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=davej@redhat.com \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=riel@redhat.com \
    --cc=sasha.levin@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.