From: Ondrej Zary <linux@rainbow-software.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>,
James Bottomley <jbottomley@parallels.com>,
Matthew Wilcox <matthew@wil.cx>,
Doug Gilbert <dgilbert@interlog.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 00/12] nobody loves the advansys driver
Date: Wed, 3 Dec 2014 16:34:48 +0100 [thread overview]
Message-ID: <201412031634.48711.linux@rainbow-software.org> (raw)
In-Reply-To: <20141203152141.GA6175@lst.de>
On Wednesday 03 December 2014, Christoph Hellwig wrote:
> Thanks for looking into this old driver.
>
> If you've got a few spare cycles it might make sense to simply split
> the "wide board" support out - the driver literally is two different
> drivers with an if/else section in every method for the totally
> different narrow vs wide boards. Having at least a clean and simple
> driver for the newer wide boards would be good, and narrow ones are
> probably old enough that we can let the driver for those fade away..
I have an ASB-3940UA (bought around 2000) and use it for scanner so I can test
patches.
The driver was working fine so I never had to look at the code. Now I see that
it's 12K lines long :( Converting that to something simple would require a
lot of work.
--
Ondrej Zary
next prev parent reply other threads:[~2014-12-03 15:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 11:44 [PATCH 00/12] nobody loves the advansys driver Hannes Reinecke
2014-12-03 11:44 ` [PATCH 01/12] advansys: use host_reset Hannes Reinecke
2014-12-04 9:17 ` Christoph Hellwig
2014-12-04 9:23 ` Hannes Reinecke
2014-12-03 11:44 ` [PATCH 02/12] advansys: use shared host tag map for command lookup Hannes Reinecke
2014-12-04 9:20 ` Christoph Hellwig
2014-12-04 9:25 ` Hannes Reinecke
2014-12-04 9:26 ` Christoph Hellwig
2014-12-03 11:44 ` [PATCH 03/12] advansys: use DMA-API for mapping sense buffer Hannes Reinecke
2014-12-03 11:44 ` [PATCH 04/12] advansys: Use DMA-API for carrier buffer Hannes Reinecke
2014-12-03 11:44 ` [PATCH 05/12] advansys: Use DMA-API for mapping request blocks Hannes Reinecke
2014-12-03 11:44 ` [PATCH 06/12] advansys: Use dma_pool for sg elements Hannes Reinecke
2014-12-03 11:45 ` [PATCH 07/12] advansys: use 'bool' instead of 'int' Hannes Reinecke
2014-12-03 11:45 ` [PATCH 08/12] advansys: use standard data types Hannes Reinecke
2014-12-03 11:45 ` [PATCH 09/12] advansys: Remove 'TRUE' and 'FALSE' definitions Hannes Reinecke
2014-12-03 11:45 ` [PATCH 10/12] advansys: Remove 'ERR' definition Hannes Reinecke
2014-12-03 11:45 ` [PATCH 11/12] advansys: cleanup function return codes Hannes Reinecke
2014-12-03 11:45 ` [PATCH 12/12] advansys: Update to version 3.5 and remove compilation warning Hannes Reinecke
2014-12-04 9:23 ` Christoph Hellwig
2014-12-04 9:26 ` Hannes Reinecke
2014-12-03 15:21 ` [PATCH 00/12] nobody loves the advansys driver Christoph Hellwig
2014-12-03 15:34 ` Ondrej Zary [this message]
2014-12-03 15:42 ` James Bottomley
2014-12-03 16:28 ` Hannes Reinecke
2014-12-04 9:13 ` hch
2014-12-04 9:12 ` Christoph Hellwig
2014-12-03 16:06 ` Douglas Gilbert
2014-12-03 18:29 ` Ondrej Zary
2014-12-04 7:12 ` Hannes Reinecke
2014-12-07 14:44 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412031634.48711.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.