All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-filesystems][PATCH] f2fs-tools: Update to Version 1.04
@ 2014-12-03 11:14 Sven Ebenfeld
  2014-12-03 18:06 ` Martin Jansa
  0 siblings, 1 reply; 3+ messages in thread
From: Sven Ebenfeld @ 2014-12-03 11:14 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
---
 .../recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb   | 17 ++++++++++++
 ...emove-AC_CHECK_FILE-for-cross-compilation.patch | 32 ++++++++++++++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
 create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch

diff --git a/meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb b/meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
new file mode 100644
index 0000000..c329692
--- /dev/null
+++ b/meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
@@ -0,0 +1,17 @@
+SUMMARY = "Tools for Flash-Friendly File System (F2FS)"
+HOMEPAGE = "http://sourceforge.net/projects/f2fs-tools/"
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=362b4b2594cd362b874a97718faa51d3"
+
+# to provide libuuid
+DEPENDS = "util-linux"
+
+SRCREV = "baac4b4e6f41ceb02511da49dd3707674f3fea21"
+SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git \
+	file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch"
+S = "${WORKDIR}/git"
+
+inherit pkgconfig autotools
+
+BBCLASSEXTEND = "native"
diff --git a/meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch b/meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch
new file mode 100644
index 0000000..cf844bf
--- /dev/null
+++ b/meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch
@@ -0,0 +1,32 @@
+From 3b3c6e6376babcd9a0b0db312b0e1e3bb3ab833e Mon Sep 17 00:00:00 2001
+From: Sven Ebenfeld <sven.ebenfeld@vaillant.de>
+Date: Wed, 26 Nov 2014 10:36:44 +0100
+Subject: [PATCH] Remove AC_CHECK_FILE for cross compilation
+
+---
+ configure.ac | 7 +------
+ 1 file changed, 1 insertion(+), 6 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 0111e72..8c286d4 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -20,14 +20,9 @@ AC_DEFINE([F2FS_MINOR_VERSION], m4_bpatsubst(f2fs_tools_version,
+ 				[\([0-9]*\).\([0-9]*\)\(\w\|\W\)*], [\2]),
+ 				[Minor version for f2fs-tools])
+ 
+-AC_CHECK_FILE(.git,
+-	AC_DEFINE([F2FS_TOOLS_DATE],
+-		"m4_bpatsubst(f2fs_tools_gitdate,
+-		[\([0-9-]*\)\(\w\|\W\)*], [\1])",
+-		[f2fs-tools date based on Git commits]),
+ 	AC_DEFINE([F2FS_TOOLS_DATE],
+ 		"f2fs_tools_date",
+-		[f2fs-tools date based on Source releases]))
++		[f2fs-tools date based on Source releases])
+ 
+ AC_CONFIG_SRCDIR([config.h.in])
+ AC_CONFIG_HEADER([config.h])
+-- 
+1.8.1.rc3
+
-- 
1.8.1.rc3



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [meta-filesystems][PATCH] f2fs-tools: Update to Version 1.04
  2014-12-03 11:14 [meta-filesystems][PATCH] f2fs-tools: Update to Version 1.04 Sven Ebenfeld
@ 2014-12-03 18:06 ` Martin Jansa
  2014-12-03 21:53   ` Sven Ebenfeld
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Jansa @ 2014-12-03 18:06 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 3475 bytes --]

On Wed, Dec 03, 2014 at 12:14:01PM +0100, Sven Ebenfeld wrote:
> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
> ---

The subject says 1.04 and recipe 1.4.0.

Also next time remove old version (1.1.0).

And use f2fs-tools instead of "files" directory for slightly faster
lookup.

I've updated all 3 when cherry-picking to master-next.

>  .../recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb   | 17 ++++++++++++
>  ...emove-AC_CHECK_FILE-for-cross-compilation.patch | 32 ++++++++++++++++++++++
>  2 files changed, 49 insertions(+)
>  create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
>  create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch
> 
> diff --git a/meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb b/meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
> new file mode 100644
> index 0000000..c329692
> --- /dev/null
> +++ b/meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
> @@ -0,0 +1,17 @@
> +SUMMARY = "Tools for Flash-Friendly File System (F2FS)"
> +HOMEPAGE = "http://sourceforge.net/projects/f2fs-tools/"
> +
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=362b4b2594cd362b874a97718faa51d3"
> +
> +# to provide libuuid
> +DEPENDS = "util-linux"
> +
> +SRCREV = "baac4b4e6f41ceb02511da49dd3707674f3fea21"
> +SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git \
> +	file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch"
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig autotools
> +
> +BBCLASSEXTEND = "native"
> diff --git a/meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch b/meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch
> new file mode 100644
> index 0000000..cf844bf
> --- /dev/null
> +++ b/meta-filesystems/recipes-utils/f2fs-tools/files/0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch
> @@ -0,0 +1,32 @@
> +From 3b3c6e6376babcd9a0b0db312b0e1e3bb3ab833e Mon Sep 17 00:00:00 2001
> +From: Sven Ebenfeld <sven.ebenfeld@vaillant.de>
> +Date: Wed, 26 Nov 2014 10:36:44 +0100
> +Subject: [PATCH] Remove AC_CHECK_FILE for cross compilation
> +
> +---
> + configure.ac | 7 +------
> + 1 file changed, 1 insertion(+), 6 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 0111e72..8c286d4 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -20,14 +20,9 @@ AC_DEFINE([F2FS_MINOR_VERSION], m4_bpatsubst(f2fs_tools_version,
> + 				[\([0-9]*\).\([0-9]*\)\(\w\|\W\)*], [\2]),
> + 				[Minor version for f2fs-tools])
> + 
> +-AC_CHECK_FILE(.git,
> +-	AC_DEFINE([F2FS_TOOLS_DATE],
> +-		"m4_bpatsubst(f2fs_tools_gitdate,
> +-		[\([0-9-]*\)\(\w\|\W\)*], [\1])",
> +-		[f2fs-tools date based on Git commits]),
> + 	AC_DEFINE([F2FS_TOOLS_DATE],
> + 		"f2fs_tools_date",
> +-		[f2fs-tools date based on Source releases]))
> ++		[f2fs-tools date based on Source releases])
> + 
> + AC_CONFIG_SRCDIR([config.h.in])
> + AC_CONFIG_HEADER([config.h])
> +-- 
> +1.8.1.rc3
> +
> -- 
> 1.8.1.rc3
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [meta-filesystems][PATCH] f2fs-tools: Update to Version 1.04
  2014-12-03 18:06 ` Martin Jansa
@ 2014-12-03 21:53   ` Sven Ebenfeld
  0 siblings, 0 replies; 3+ messages in thread
From: Sven Ebenfeld @ 2014-12-03 21:53 UTC (permalink / raw)
  To: openembedded-devel, martin.jansa

Am 03.12.2014 um 19:06 schrieb Martin Jansa:
> On Wed, Dec 03, 2014 at 12:14:01PM +0100, Sven Ebenfeld wrote:
>> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
>> ---
> 
> The subject says 1.04 and recipe 1.4.0.
> 
> Also next time remove old version (1.1.0).

I were not really sure what is "best practice". Next time, I will remove
the old version as well.

> 
> And use f2fs-tools instead of "files" directory for slightly faster
> lookup.
> 
> I've updated all 3 when cherry-picking to master-next.

Thanks for updating! I will use this feedback for my future patches.


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-03 21:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 11:14 [meta-filesystems][PATCH] f2fs-tools: Update to Version 1.04 Sven Ebenfeld
2014-12-03 18:06 ` Martin Jansa
2014-12-03 21:53   ` Sven Ebenfeld

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.