From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/include/asm: Fixed a warning about 'struct pt_regs'
Date: Thu, 4 Dec 2014 10:11:31 +0000 [thread overview]
Message-ID: <20141204101131.GE13224@arm.com> (raw)
In-Reply-To: <1417674575-10855-1-git-send-email-chunyan.zhang@spreadtrum.com>
On Thu, Dec 04, 2014 at 06:29:35AM +0000, Chunyan Zhang wrote:
> If I include asm/irq.h on the top of my code, and set ARCH=arm64,
> I'll get a compile warning, details are below:
> warning: ?struct pt_regs?
> declared inside parameter list [enabled by default]
>
> This patch is suggested by Arnd, see:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/308270.html
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
> ---
> arch/arm64/include/asm/irq.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h
> index e1f7ecd..acedc7e 100644
> --- a/arch/arm64/include/asm/irq.h
> +++ b/arch/arm64/include/asm/irq.h
> @@ -3,6 +3,8 @@
>
> #include <asm-generic/irq.h>
>
> +struct pt_regs;
> +
> extern void (*handle_arch_irq)(struct pt_regs *);
> extern void migrate_irqs(void);
> extern void set_handle_irq(void (*handle_irq)(struct pt_regs *));
Fair enough, applied with trivial conflict resolution.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64/include/asm: Fixed a warning about 'struct pt_regs'
Date: Thu, 4 Dec 2014 10:11:31 +0000 [thread overview]
Message-ID: <20141204101131.GE13224@arm.com> (raw)
In-Reply-To: <1417674575-10855-1-git-send-email-chunyan.zhang@spreadtrum.com>
On Thu, Dec 04, 2014 at 06:29:35AM +0000, Chunyan Zhang wrote:
> If I include asm/irq.h on the top of my code, and set ARCH=arm64,
> I'll get a compile warning, details are below:
> warning: ‘struct pt_regs’
> declared inside parameter list [enabled by default]
>
> This patch is suggested by Arnd, see:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/308270.html
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
> ---
> arch/arm64/include/asm/irq.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h
> index e1f7ecd..acedc7e 100644
> --- a/arch/arm64/include/asm/irq.h
> +++ b/arch/arm64/include/asm/irq.h
> @@ -3,6 +3,8 @@
>
> #include <asm-generic/irq.h>
>
> +struct pt_regs;
> +
> extern void (*handle_arch_irq)(struct pt_regs *);
> extern void migrate_irqs(void);
> extern void set_handle_irq(void (*handle_irq)(struct pt_regs *));
Fair enough, applied with trivial conflict resolution.
Will
next prev parent reply other threads:[~2014-12-04 10:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <zcyirq.h>
2014-12-04 6:29 ` [PATCH] arm64/include/asm: Fixed a warning about 'struct pt_regs' Chunyan Zhang
2014-12-04 6:29 ` Chunyan Zhang
2014-12-04 10:11 ` Will Deacon [this message]
2014-12-04 10:11 ` Will Deacon
2014-12-04 11:23 Chunyan Zhang
2014-12-04 11:23 ` Chunyan Zhang
2014-12-04 12:37 ` Lyra Zhang
2014-12-04 12:37 ` Lyra Zhang
-- strict thread matches above, loose matches on Subject: below --
2014-12-04 11:24 Chunyan Zhang
2014-12-04 11:24 ` Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204101131.GE13224@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.