From: Daniel Vetter <daniel@ffwll.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: Fix memory leak at error path of drm_read()
Date: Thu, 4 Dec 2014 12:46:16 +0100 [thread overview]
Message-ID: <20141204114616.GD20350@phenom.ffwll.local> (raw)
In-Reply-To: <1417690603-1595-1-git-send-email-tiwai@suse.de>
On Thu, Dec 04, 2014 at 11:56:42AM +0100, Takashi Iwai wrote:
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied to my drm-misc branch. The second patch seems to be a dupe of
commit bd008e5b2953186fc0c6633a885ade95e7043800
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Tue Oct 7 14:13:51 2014 +0100
drm: Implement O_NONBLOCK support on /dev/dri/cardN
so maybe we should backport that one once it's landed in 3.19?
-Daniel
> ---
> drivers/gpu/drm/drm_fops.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c
> index ed7bc68f7e87..a82dc28d54f3 100644
> --- a/drivers/gpu/drm/drm_fops.c
> +++ b/drivers/gpu/drm/drm_fops.c
> @@ -525,6 +525,7 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
> if (copy_to_user(buffer + total,
> e->event, e->event->length)) {
> total = -EFAULT;
> + e->destroy(e);
> break;
> }
>
> --
> 2.1.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-12-04 11:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 10:56 [PATCH 1/2] drm: Fix memory leak at error path of drm_read() Takashi Iwai
2014-12-04 10:56 ` [PATCH 2/2] drm: Implement nonblocking mode in drm_read() Takashi Iwai
2014-12-04 11:46 ` Daniel Vetter [this message]
2014-12-04 11:50 ` [PATCH 1/2] drm: Fix memory leak at error path of drm_read() Takashi Iwai
2014-12-04 11:51 ` Takashi Iwai
2014-12-04 11:51 ` Chris Wilson
2014-12-04 11:56 ` Takashi Iwai
2014-12-04 12:13 ` Chris Wilson
2014-12-04 12:27 ` Takashi Iwai
2014-12-04 12:28 ` Daniel Vetter
2014-12-04 16:31 ` Chris Wilson
2014-12-04 16:38 ` Chris Wilson
2014-12-04 16:55 ` Takashi Iwai
2014-12-04 21:03 ` [PATCH] drm: Make drm_read() more robust against multithreaded races Chris Wilson
2014-12-05 2:19 ` shuang.he
2014-12-05 20:59 ` Daniel Vetter
2014-12-05 8:42 ` Takashi Iwai
2015-01-05 10:18 ` [Intel-gfx] " Daniel Vetter
2014-12-05 8:44 ` Daniel Vetter
2014-12-04 17:25 ` [PATCH 1/2] drm: Fix memory leak at error path of drm_read() Daniel Vetter
2014-12-05 8:01 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204114616.GD20350@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.