From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
David Hildenbrand <dahi@linux.vnet.ibm.com>,
virtualization@lists.linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1
Date: Thu, 4 Dec 2014 20:15:12 +0200 [thread overview]
Message-ID: <20141204181512.GA24307@redhat.com> (raw)
In-Reply-To: <20141204185914.4e989a7a.cornelia.huck@de.ibm.com>
On Thu, Dec 04, 2014 at 06:59:14PM +0100, Cornelia Huck wrote:
> On Thu, 4 Dec 2014 19:26:50 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > What does it mean if rev 1 device does not set
> > VIRTIO_F_VERSION_1? E.g. is it native endian?
> >
> > Let's not even try to drive such devices:
> > skip attempts to finalize features or set status.
>
> Why not set status_failed?
It might be cleanest to just teach core that finalize_features
can fail.
I'll look into this.
> > virtio core will detect this and bail out.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/s390/kvm/virtio_ccw.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
>
> I'm not sure yet whether I like this approach. I'll think about it over
> the weekend.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-s390@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
David Hildenbrand <dahi@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com
Subject: Re: [PATCH RFC 3/3] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1
Date: Thu, 4 Dec 2014 20:15:12 +0200 [thread overview]
Message-ID: <20141204181512.GA24307@redhat.com> (raw)
In-Reply-To: <20141204185914.4e989a7a.cornelia.huck@de.ibm.com>
On Thu, Dec 04, 2014 at 06:59:14PM +0100, Cornelia Huck wrote:
> On Thu, 4 Dec 2014 19:26:50 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > What does it mean if rev 1 device does not set
> > VIRTIO_F_VERSION_1? E.g. is it native endian?
> >
> > Let's not even try to drive such devices:
> > skip attempts to finalize features or set status.
>
> Why not set status_failed?
It might be cleanest to just teach core that finalize_features
can fail.
I'll look into this.
> > virtio core will detect this and bail out.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/s390/kvm/virtio_ccw.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
>
> I'm not sure yet whether I like this approach. I'll think about it over
> the weekend.
next prev parent reply other threads:[~2014-12-04 18:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 17:26 [PATCH RFC 1/3] virtio: add API to detect legacy devices Michael S. Tsirkin
2014-12-04 17:26 ` Michael S. Tsirkin
2014-12-04 17:26 ` [PATCH RFC 2/3] virtio_ccw: legacy: don't negotiate rev 1/features Michael S. Tsirkin
2014-12-04 17:26 ` Michael S. Tsirkin
2014-12-04 17:56 ` Cornelia Huck
2014-12-04 17:56 ` Cornelia Huck
2014-12-04 18:09 ` Michael S. Tsirkin
2014-12-04 18:09 ` Michael S. Tsirkin
2014-12-04 17:26 ` [PATCH RFC 3/3] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 Michael S. Tsirkin
2014-12-04 17:26 ` Michael S. Tsirkin
2014-12-04 17:59 ` Cornelia Huck
2014-12-04 17:59 ` Cornelia Huck
2014-12-04 18:09 ` Michael S. Tsirkin
2014-12-04 18:09 ` Michael S. Tsirkin
2014-12-04 18:15 ` Michael S. Tsirkin [this message]
2014-12-04 18:15 ` Michael S. Tsirkin
2014-12-04 17:54 ` [PATCH RFC 1/3] virtio: add API to detect legacy devices Cornelia Huck
2014-12-04 17:54 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204181512.GA24307@redhat.com \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.