* [PATCH bluetooth-next 1/2] mac802154: use goto label on failure
@ 2014-12-05 11:49 Varka Bhadram
2014-12-05 11:49 ` [PATCH bluetooth-next 2/2] cc2520: adds terminating newline Varka Bhadram
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Varka Bhadram @ 2014-12-05 11:49 UTC (permalink / raw)
To: linux-wpan; +Cc: alex.aring, Varka Bhadram
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
net/mac802154/rx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
index 041dbd5..c0d67b2 100644
--- a/net/mac802154/rx.c
+++ b/net/mac802154/rx.c
@@ -85,8 +85,7 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data *sdata,
default:
spin_unlock_bh(&sdata->mib_lock);
pr_debug("invalid dest mode\n");
- kfree_skb(skb);
- return NET_RX_DROP;
+ goto fail;
}
spin_unlock_bh(&sdata->mib_lock);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH bluetooth-next 2/2] cc2520: adds terminating newline
2014-12-05 11:49 [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Varka Bhadram
@ 2014-12-05 11:49 ` Varka Bhadram
2014-12-05 13:19 ` Marcel Holtmann
2014-12-05 12:03 ` [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Stefan Schmidt
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Varka Bhadram @ 2014-12-05 11:49 UTC (permalink / raw)
To: linux-wpan; +Cc: alex.aring, Varka Bhadram
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
drivers/net/ieee802154/cc2520.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index ccbb082..f9df9fa 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -858,7 +858,7 @@ static int cc2520_probe(struct spi_device *spi)
pinctrl = devm_pinctrl_get_select_default(&spi->dev);
if (IS_ERR(pinctrl))
dev_warn(&spi->dev,
- "pinctrl pins are not configured");
+ "pinctrl pins are not configured\n");
pdata = cc2520_get_platform_data(spi);
if (!pdata) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH bluetooth-next 1/2] mac802154: use goto label on failure
2014-12-05 11:49 [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Varka Bhadram
2014-12-05 11:49 ` [PATCH bluetooth-next 2/2] cc2520: adds terminating newline Varka Bhadram
@ 2014-12-05 12:03 ` Stefan Schmidt
2014-12-05 12:31 ` Alexander Aring
2014-12-05 13:19 ` Marcel Holtmann
3 siblings, 0 replies; 6+ messages in thread
From: Stefan Schmidt @ 2014-12-05 12:03 UTC (permalink / raw)
To: 'Varka Bhadram', linux-wpan; +Cc: alex.aring, 'Varka Bhadram'
Hello.
On 05/12/14 12:49, Varka Bhadram wrote:
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> net/mac802154/rx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
> index 041dbd5..c0d67b2 100644
> --- a/net/mac802154/rx.c
> +++ b/net/mac802154/rx.c
> @@ -85,8 +85,7 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data
> *sdata,
> default:
> spin_unlock_bh(&sdata->mib_lock);
> pr_debug("invalid dest mode\n");
> - kfree_skb(skb);
> - return NET_RX_DROP;
> + goto fail;
> }
>
> spin_unlock_bh(&sdata->mib_lock);
>
Good catch!
Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bluetooth-next 1/2] mac802154: use goto label on failure
2014-12-05 11:49 [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Varka Bhadram
2014-12-05 11:49 ` [PATCH bluetooth-next 2/2] cc2520: adds terminating newline Varka Bhadram
2014-12-05 12:03 ` [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Stefan Schmidt
@ 2014-12-05 12:31 ` Alexander Aring
2014-12-05 13:19 ` Marcel Holtmann
3 siblings, 0 replies; 6+ messages in thread
From: Alexander Aring @ 2014-12-05 12:31 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-wpan, Varka Bhadram
On Fri, Dec 05, 2014 at 05:19:09PM +0530, Varka Bhadram wrote:
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
Acked-by: Alexander Aring <alex.aring@gmail.com>
on the complete serie. Thanks.
- Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bluetooth-next 1/2] mac802154: use goto label on failure
2014-12-05 11:49 [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Varka Bhadram
` (2 preceding siblings ...)
2014-12-05 12:31 ` Alexander Aring
@ 2014-12-05 13:19 ` Marcel Holtmann
3 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2014-12-05 13:19 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-wpan, alex.aring, Varka Bhadram
Hi Varka,
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> net/mac802154/rx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bluetooth-next 2/2] cc2520: adds terminating newline
2014-12-05 11:49 ` [PATCH bluetooth-next 2/2] cc2520: adds terminating newline Varka Bhadram
@ 2014-12-05 13:19 ` Marcel Holtmann
0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2014-12-05 13:19 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-wpan, alex.aring, Varka Bhadram
Hi Varka,
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> drivers/net/ieee802154/cc2520.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-05 13:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 11:49 [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Varka Bhadram
2014-12-05 11:49 ` [PATCH bluetooth-next 2/2] cc2520: adds terminating newline Varka Bhadram
2014-12-05 13:19 ` Marcel Holtmann
2014-12-05 12:03 ` [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Stefan Schmidt
2014-12-05 12:31 ` Alexander Aring
2014-12-05 13:19 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.