From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification
Date: Fri, 5 Dec 2014 22:17:58 +0530 [thread overview]
Message-ID: <20141205164758.GR3411@intel.com> (raw)
In-Reply-To: <bd47278216b64375b32cdc9ed66fe907@BN1BFFO11FD024.protection.gbl>
On Wed, Nov 12, 2014 at 10:26:03AM -0800, S?ren Brinkmann wrote:
> On Wed, 2014-11-12 at 07:03PM +0100, Andreas F?rber wrote:
> > Am 12.11.2014 um 16:57 schrieb S?ren Brinkmann:
> > > On Wed, 2014-11-12 at 02:51PM +0100, Andreas F?rber wrote:
> > >> The specification requires xlnx,data-width, but example and driver use
> > >> xlnx,datawidth. Change the specification to match the implementation.
> > >
> > > Isn't this the wrong way around? The bindings are considered API, so
> > > shouldn't the driver be fixed to match the spec?
> >
> > In theory, patch review should've never let the two differ... ;)
> >
> > It's not my driver, so I fixed the perceived inconsistency the least
> > invasive way; Michal and Srikanth seemed to concur at the time.
> >
> > https://patchwork.kernel.org/patch/4620261/
> >
> > > Are there already dts files out there using either of these options?
> >
> > In upstream, no. microblaze and virtex440 use a
> > xlnx,include-datawidth-matching-0 property as precedence for the
> > spelling, whereas there is an fsl,data-width and an unused msix-data-width.
> >
> > Downstream, yes: Beyond my own patch derived from the Parallella tree,
> > there's some in the ADI tree. None in the Xilinx tree on quick check.
> >
> > I haven't encountered any using the documented xlnx,data-width - but
> > this patch was authored pre 3.17, haven't ran a full Web search again.
>
> grepping through linux-next shows some usage of xlnx,datawidth, but
> only the single hit in Documentation for xlnx,data-width.
> Other than VDMA the other hit seems to be just some DT
> documentation which I can't find a driver for...
> Anyhow, this patch is probably the best way of fixing this.
the driver had issues so want applied, I havent seen repot though.
Will apply this now
--
~Vinod
>
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>
> Thanks,
> S?ren
--
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
dmaengine@vger.kernel.org,
"Michal Simek" <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Srikanth Thokala" <sthokal@xilinx.com>,
"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification
Date: Fri, 5 Dec 2014 22:17:58 +0530 [thread overview]
Message-ID: <20141205164758.GR3411@intel.com> (raw)
In-Reply-To: <bd47278216b64375b32cdc9ed66fe907@BN1BFFO11FD024.protection.gbl>
On Wed, Nov 12, 2014 at 10:26:03AM -0800, Sören Brinkmann wrote:
> On Wed, 2014-11-12 at 07:03PM +0100, Andreas Färber wrote:
> > Am 12.11.2014 um 16:57 schrieb Sören Brinkmann:
> > > On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote:
> > >> The specification requires xlnx,data-width, but example and driver use
> > >> xlnx,datawidth. Change the specification to match the implementation.
> > >
> > > Isn't this the wrong way around? The bindings are considered API, so
> > > shouldn't the driver be fixed to match the spec?
> >
> > In theory, patch review should've never let the two differ... ;)
> >
> > It's not my driver, so I fixed the perceived inconsistency the least
> > invasive way; Michal and Srikanth seemed to concur at the time.
> >
> > https://patchwork.kernel.org/patch/4620261/
> >
> > > Are there already dts files out there using either of these options?
> >
> > In upstream, no. microblaze and virtex440 use a
> > xlnx,include-datawidth-matching-0 property as precedence for the
> > spelling, whereas there is an fsl,data-width and an unused msix-data-width.
> >
> > Downstream, yes: Beyond my own patch derived from the Parallella tree,
> > there's some in the ADI tree. None in the Xilinx tree on quick check.
> >
> > I haven't encountered any using the documented xlnx,data-width - but
> > this patch was authored pre 3.17, haven't ran a full Web search again.
>
> grepping through linux-next shows some usage of xlnx,datawidth, but
> only the single hit in Documentation for xlnx,data-width.
> Other than VDMA the other hit seems to be just some DT
> documentation which I can't find a driver for...
> Anyhow, this patch is probably the best way of fixing this.
the driver had issues so want applied, I havent seen repot though.
Will apply this now
--
~Vinod
>
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>
> Thanks,
> Sören
--
next prev parent reply other threads:[~2014-12-05 16:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 13:51 [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification Andreas Färber
2014-11-12 13:51 ` Andreas Färber
2014-11-12 13:51 ` Andreas Färber
2014-11-12 15:57 ` Sören Brinkmann
2014-11-12 15:57 ` Sören Brinkmann
2014-11-12 15:57 ` Sören Brinkmann
2014-11-12 18:03 ` Andreas Färber
2014-11-12 18:03 ` Andreas Färber
2014-11-12 18:26 ` Sören Brinkmann
2014-11-12 18:26 ` Sören Brinkmann
2014-11-12 18:26 ` Sören Brinkmann
2014-12-05 16:47 ` Vinod Koul [this message]
2014-12-05 16:47 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205164758.GR3411@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.