All of lore.kernel.org
 help / color / mirror / Atom feed
From: HeavyJoost <heavyjoost@heavyjoost.ca>
To: linux-media@vger.kernel.org
Subject: [BUG] libdvbv5: dvb_fe_retrieve_quality not working correctly (dvb-fe.c)
Date: Sun, 7 Dec 2014 13:52:37 -0700	[thread overview]
Message-ID: <20141207135237.4ad61a94@sleipnir.lan> (raw)

I was trying out this library and I found two things that probably need fixing in dvb_fe_retrieve_quality. Without this it only returns DVB_QUAL_UNKNOWN for my setup.


Issue 1 on line 1205:

ber = dvb_fe_retrieve_per(&parms->p, layer);

As far as I can tell this should use dvb_fe_retrieve_ber (so _ber instead of _per) with the appropriate arguments.


Issue 2 on line 1218:

dvbv_fe_cnr_to_quality(parms, cnr);

This probably needs to be changed to the following because it doesn't have any effect otherwise ;)

qual = dvbv_fe_cnr_to_quality(parms, cnr);

                 reply	other threads:[~2014-12-07 20:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141207135237.4ad61a94@sleipnir.lan \
    --to=heavyjoost@heavyjoost.ca \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.