All of lore.kernel.org
 help / color / mirror / Atom feed
* [BUG] libdvbv5: dvb_fe_retrieve_quality not working correctly (dvb-fe.c)
@ 2014-12-07 20:52 HeavyJoost
  0 siblings, 0 replies; only message in thread
From: HeavyJoost @ 2014-12-07 20:52 UTC (permalink / raw)
  To: linux-media

I was trying out this library and I found two things that probably need fixing in dvb_fe_retrieve_quality. Without this it only returns DVB_QUAL_UNKNOWN for my setup.


Issue 1 on line 1205:

ber = dvb_fe_retrieve_per(&parms->p, layer);

As far as I can tell this should use dvb_fe_retrieve_ber (so _ber instead of _per) with the appropriate arguments.


Issue 2 on line 1218:

dvbv_fe_cnr_to_quality(parms, cnr);

This probably needs to be changed to the following because it doesn't have any effect otherwise ;)

qual = dvbv_fe_cnr_to_quality(parms, cnr);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-12-07 20:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-07 20:52 [BUG] libdvbv5: dvb_fe_retrieve_quality not working correctly (dvb-fe.c) HeavyJoost

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.