From: Paul Mackerras <paulus@samba.org>
To: "Shreyas B. Prabhu" <shreyas@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
"Preeti U. Murthy" <preeti@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 2/4] powerpc/powernv: Enable Offline CPUs to enter deep idle states
Date: Mon, 8 Dec 2014 14:33:51 +1100 [thread overview]
Message-ID: <20141208033351.GA4437@drongo> (raw)
In-Reply-To: <1417678103-32571-3-git-send-email-shreyas@linux.vnet.ibm.com>
On Thu, Dec 04, 2014 at 12:58:21PM +0530, Shreyas B. Prabhu wrote:
> From: "Preeti U. Murthy" <preeti@linux.vnet.ibm.com>
>
> The secondary threads should enter deep idle states so as to gain maximum
> powersavings when the entire core is offline. To do so the offline path
> must be made aware of the available deepest idle state. Hence probe the
> device tree for the possible idle states in powernv core code and
> expose the deepest idle state through flags.
>
> Since the device tree is probed by the cpuidle driver as well, move
> the parameters required to discover the idle states into an appropriate
> common place to both the driver and the powernv core code.
>
> Another point is that fastsleep idle state may require workarounds in
> the kernel to function properly. This workaround is introduced in the
> subsequent patches. However neither the cpuidle driver or the hotplug
> path need be bothered about this workaround.
>
> They will be taken care of by the core powernv code.
>
> Originally-by: Srivatsa S. Bhat <srivatsa@mit.edu>
> Signed-off-by: Preeti U. Murthy <preeti@linux.vnet.ibm.com>
> Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com>
Reviewed-by: Paul Mackerras <paulus@samba.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@samba.org>
To: "Shreyas B. Prabhu" <shreyas@linux.vnet.ibm.com>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
"Preeti U. Murthy" <preeti@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 2/4] powerpc/powernv: Enable Offline CPUs to enter deep idle states
Date: Mon, 8 Dec 2014 14:33:51 +1100 [thread overview]
Message-ID: <20141208033351.GA4437@drongo> (raw)
In-Reply-To: <1417678103-32571-3-git-send-email-shreyas@linux.vnet.ibm.com>
On Thu, Dec 04, 2014 at 12:58:21PM +0530, Shreyas B. Prabhu wrote:
> From: "Preeti U. Murthy" <preeti@linux.vnet.ibm.com>
>
> The secondary threads should enter deep idle states so as to gain maximum
> powersavings when the entire core is offline. To do so the offline path
> must be made aware of the available deepest idle state. Hence probe the
> device tree for the possible idle states in powernv core code and
> expose the deepest idle state through flags.
>
> Since the device tree is probed by the cpuidle driver as well, move
> the parameters required to discover the idle states into an appropriate
> common place to both the driver and the powernv core code.
>
> Another point is that fastsleep idle state may require workarounds in
> the kernel to function properly. This workaround is introduced in the
> subsequent patches. However neither the cpuidle driver or the hotplug
> path need be bothered about this workaround.
>
> They will be taken care of by the core powernv code.
>
> Originally-by: Srivatsa S. Bhat <srivatsa@mit.edu>
> Signed-off-by: Preeti U. Murthy <preeti@linux.vnet.ibm.com>
> Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com>
Reviewed-by: Paul Mackerras <paulus@samba.org>
next prev parent reply other threads:[~2014-12-08 3:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 7:28 [PATCH v3 0/4] powernv: cpuidle: Redesign idle states management Shreyas B. Prabhu
2014-12-04 7:28 ` Shreyas B. Prabhu
2014-12-04 7:28 ` [PATCH v3 1/4] powerpc: powernv: Switch off MMU before entering nap/sleep/rvwinkle mode Shreyas B. Prabhu
2014-12-04 7:28 ` Shreyas B. Prabhu
2014-12-04 7:28 ` [PATCH v3 2/4] powerpc/powernv: Enable Offline CPUs to enter deep idle states Shreyas B. Prabhu
2014-12-04 7:28 ` Shreyas B. Prabhu
2014-12-08 3:33 ` Paul Mackerras [this message]
2014-12-08 3:33 ` Paul Mackerras
2014-12-14 10:05 ` [v3, " Michael Ellerman
2014-12-14 10:05 ` Michael Ellerman
2014-12-14 11:49 ` Shreyas B Prabhu
2014-12-14 11:49 ` Shreyas B Prabhu
2014-12-14 23:44 ` Michael Ellerman
2014-12-14 23:44 ` Michael Ellerman
2014-12-04 7:28 ` [PATCH v3 3/4] powernv: cpuidle: Redesign idle states management Shreyas B. Prabhu
2014-12-04 7:28 ` Shreyas B. Prabhu
2014-12-08 5:01 ` Paul Mackerras
2014-12-08 5:01 ` Paul Mackerras
2014-12-08 5:26 ` Shreyas B Prabhu
2014-12-08 5:26 ` Shreyas B Prabhu
2014-12-04 7:28 ` [PATCH v3 4/4] powernv: powerpc: Add winkle support for offline cpus Shreyas B. Prabhu
2014-12-04 7:28 ` Shreyas B. Prabhu
2014-12-08 5:52 ` Paul Mackerras
2014-12-08 5:52 ` Paul Mackerras
2014-12-08 21:54 ` Shreyas B Prabhu
2014-12-08 21:54 ` Shreyas B Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208033351.GA4437@drongo \
--to=paulus@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.