From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, freemangordon@abv.bg, balbi@ti.com,
Greg KH <greg@kroah.com>,
marcel@holtmann.org
Subject: Re: nokia_h4p on 3.16+
Date: Mon, 8 Dec 2014 23:10:50 +0100 [thread overview]
Message-ID: <201412082310.50742@pali> (raw)
In-Reply-To: <20141208204735.GA21599@amd>
[-- Attachment #1: Type: Text/Plain, Size: 1018 bytes --]
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Pavel, maybe there is some unhandled iir value in function
static irqreturn_t hci_h4p_interrupt(int irq, void *data)
which cause that driver is not working?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: nokia_h4p on 3.16+
Date: Mon, 8 Dec 2014 23:10:50 +0100 [thread overview]
Message-ID: <201412082310.50742@pali> (raw)
In-Reply-To: <20141208204735.GA21599@amd>
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Pavel, maybe there is some unhandled iir value in function
static irqreturn_t hci_h4p_interrupt(int irq, void *data)
which cause that driver is not working?
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141208/9712e5a3/attachment.sig>
next prev parent reply other threads:[~2014-12-08 22:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 20:47 nokia_h4p on 3.16+ Pavel Machek
2014-12-08 20:47 ` Pavel Machek
2014-12-08 20:50 ` Pali Rohár
2014-12-08 20:50 ` Pali Rohár
2014-12-08 22:06 ` Pali Rohár
2014-12-08 22:06 ` Pali Rohár
2014-12-08 22:10 ` Pali Rohár [this message]
2014-12-08 22:10 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412082310.50742@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=freemangordon@abv.bg \
--cc=greg@kroah.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pavel@ucw.cz \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.