From: Dan Carpenter <dan.carpenter@oracle.com>
To: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>,
Wensong Zhang <wensong@linux-vs.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] ipvs: uninitialized data with IP_VS_IPV6
Date: Tue, 09 Dec 2014 06:49:47 +0000 [thread overview]
Message-ID: <20141209064947.GH4912@mwanda> (raw)
In-Reply-To: <20141209005215.GH8897@verge.net.au>
On Tue, Dec 09, 2014 at 09:52:15AM +0900, Simon Horman wrote:
> On Sun, Dec 07, 2014 at 08:39:35PM +0200, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Sat, 6 Dec 2014, Dan Carpenter wrote:
> >
> > > The app_tcp_pkt_out() function expects "*diff" to be set and ends up
> > > using uninitialized data if CONFIG_IP_VS_IPV6 is turned on.
> > >
> > > The same issue is there in app_tcp_pkt_in(). Thanks to Julian Anastasov
> > > for noticing that.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > > v2: fix app_tcp_pkt_in() as well. This is an old bug.
> >
> > Thanks! It will not break seqs for IPv6 control
> > connection, only that we do not support FTP yet :( I have
> > the doubt whether this should be classified as bugfix :)
> > I guess, it is a net-next material, right?
>
> Agreed, I have queued it up in ipvs-next.
> I'll send a pull request to Pablo if Dan doesn't object
> to it going there.
No objections from me.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>,
Wensong Zhang <wensong@linux-vs.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] ipvs: uninitialized data with IP_VS_IPV6
Date: Tue, 9 Dec 2014 09:49:47 +0300 [thread overview]
Message-ID: <20141209064947.GH4912@mwanda> (raw)
In-Reply-To: <20141209005215.GH8897@verge.net.au>
On Tue, Dec 09, 2014 at 09:52:15AM +0900, Simon Horman wrote:
> On Sun, Dec 07, 2014 at 08:39:35PM +0200, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Sat, 6 Dec 2014, Dan Carpenter wrote:
> >
> > > The app_tcp_pkt_out() function expects "*diff" to be set and ends up
> > > using uninitialized data if CONFIG_IP_VS_IPV6 is turned on.
> > >
> > > The same issue is there in app_tcp_pkt_in(). Thanks to Julian Anastasov
> > > for noticing that.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > > v2: fix app_tcp_pkt_in() as well. This is an old bug.
> >
> > Thanks! It will not break seqs for IPv6 control
> > connection, only that we do not support FTP yet :( I have
> > the doubt whether this should be classified as bugfix :)
> > I guess, it is a net-next material, right?
>
> Agreed, I have queued it up in ipvs-next.
> I'll send a pull request to Pablo if Dan doesn't object
> to it going there.
No objections from me.
regards,
dan carpenter
next prev parent reply other threads:[~2014-12-09 6:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 10:12 [patch] ipvs: uninitialized data with IP_VS_IPV6 Dan Carpenter
2014-12-03 10:12 ` Dan Carpenter
2014-12-04 21:19 ` Julian Anastasov
2014-12-04 21:19 ` Julian Anastasov
2014-12-05 7:25 ` Dan Carpenter
2014-12-05 7:25 ` Dan Carpenter
2014-12-06 13:49 ` [patch v2] " Dan Carpenter
2014-12-06 13:49 ` Dan Carpenter
2014-12-07 18:39 ` Julian Anastasov
2014-12-07 18:39 ` Julian Anastasov
2014-12-09 0:52 ` Simon Horman
2014-12-09 0:52 ` Simon Horman
2014-12-09 6:49 ` Dan Carpenter [this message]
2014-12-09 6:49 ` Dan Carpenter
2014-12-10 8:47 ` Simon Horman
2014-12-10 8:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209064947.GH4912@mwanda \
--to=dan.carpenter@oracle.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.