From: Timo Teras <timo.teras@iki.fi>
To: Tom Herbert <therbert@google.com>
Cc: Alexander Duyck <alexander.h.duyck@redhat.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: Possible regression: "gre: Use inner mac length when computing tunnel length"
Date: Tue, 9 Dec 2014 08:44:25 +0200 [thread overview]
Message-ID: <20141209084425.7499dbd4@vostro> (raw)
In-Reply-To: <20141209082645.5cf70f55@vostro>
On Tue, 9 Dec 2014 08:26:45 +0200
Timo Teras <timo.teras@iki.fi> wrote:
> On Thu, 4 Dec 2014 08:00:19 -0800
> Tom Herbert <therbert@google.com> wrote:
>
> > A fix is pending for net. Please try if you can.
>
> Finally got to testing this. Unfortunately, this does not seem to fix
> the issue I am experiencing.
>
> Any suggestions?
I think this fix is required, but does not fix the issue.
I suspect my problem is with the fact that I have NBMA GRE tunnel.
In ipgre_xmit() it is gre_handle_offloads() that is called first.
However, in my case, the GRE header was already pushed earlier via
header_ops. That's why the packet is skb_pull()'ed in the
"if (dev->header_ops)" path, so that __gre_xmit can push back the
header again on it.
I wonder if it is correct to just move the gre_handle_offloads() call
after the if() block, or if additional fixing is needed to make
offloads work with nbma tunnels.
/Timo
next prev parent reply other threads:[~2014-12-09 6:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 12:16 Possible regression: "gre: Use inner mac length when computing tunnel length" Timo Teras
2014-12-04 16:00 ` Tom Herbert
2014-12-09 6:26 ` Timo Teras
2014-12-09 6:44 ` Timo Teras [this message]
2014-12-09 21:23 ` Tom Herbert
2014-12-11 7:14 ` [net] gre: fix the inner mac header in nbma gre tunnels xmit path Timo Teräs
2014-12-11 19:36 ` David Miller
2014-12-11 19:44 ` Timo Teras
2014-12-11 20:07 ` David Miller
2014-12-15 7:24 ` [PATCH net, v2] gre: fix the inner mac header in nbma tunnel " Timo Teräs
2014-12-15 16:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209084425.7499dbd4@vostro \
--to=timo.teras@iki.fi \
--cc=alexander.h.duyck@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.