From: Timo Teras <timo.teras@iki.fi>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, therbert@google.com,
alexander.h.duyck@redhat.com
Subject: Re: [net] gre: fix the inner mac header in nbma gre tunnels xmit path
Date: Thu, 11 Dec 2014 21:44:56 +0200 [thread overview]
Message-ID: <20141211214456.7cc621e4@vostro> (raw)
In-Reply-To: <20141211.143627.1516156524809595238.davem@davemloft.net>
On Thu, 11 Dec 2014 14:36:27 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Timo Teräs <timo.teras@iki.fi>
> Date: Thu, 11 Dec 2014 09:14:39 +0200
>
> > @@ -266,6 +262,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff
> > *skb,
> > * to gre header.
> > */
> > skb_pull(skb, tunnel->hlen + sizeof(struct iphdr));
> > + skb_reset_mac_header(mac);
>
> Please explain to me how this compiles, let alone be functionally
> tested.
Sorry. I made the change twice; once on the build box. And again on my
git checkout on work station. Must've been on seriously coffee deprived
state.
Should be obviously:
+ skb_reset_mac_header(skb);
Is there other comments on it?
Or shall I resend?
next prev parent reply other threads:[~2014-12-11 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 12:16 Possible regression: "gre: Use inner mac length when computing tunnel length" Timo Teras
2014-12-04 16:00 ` Tom Herbert
2014-12-09 6:26 ` Timo Teras
2014-12-09 6:44 ` Timo Teras
2014-12-09 21:23 ` Tom Herbert
2014-12-11 7:14 ` [net] gre: fix the inner mac header in nbma gre tunnels xmit path Timo Teräs
2014-12-11 19:36 ` David Miller
2014-12-11 19:44 ` Timo Teras [this message]
2014-12-11 20:07 ` David Miller
2014-12-15 7:24 ` [PATCH net, v2] gre: fix the inner mac header in nbma tunnel " Timo Teräs
2014-12-15 16:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211214456.7cc621e4@vostro \
--to=timo.teras@iki.fi \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.