* [PATCH] staging: fpga manager: fix array_size.cocci warnings [not found] <201412102004.fChTGE0W%fengguang.wu@intel.com> @ 2014-12-10 12:48 ` kbuild test robot 2014-12-10 12:48 ` [PATCH] staging: fpga manager: fix platform_no_drv_owner.cocci warnings kbuild test robot 1 sibling, 0 replies; 2+ messages in thread From: kbuild test robot @ 2014-12-10 12:48 UTC (permalink / raw) To: Alan Tull Cc: kbuild-all, Michal Simek, Greg Kroah-Hartman, devel, linux-kernel drivers/staging/fpga/altera.c:368:33-34: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an effort to find cases where ARRAY_SIZE can be used such as where there is a division of sizeof the array by the sizeof its first element or by any indexed element or the element type. It replaces the division of the two sizeofs by ARRAY_SIZE. Generated by: scripts/coccinelle/misc/array_size.cocci CC: Alan Tull <atull@opensource.altera.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/fpga/altera.c +++ b/drivers/staging/fpga/altera.c @@ -365,7 +365,7 @@ static int altera_fpga_cfg_mode_get(stru msel >>= ALTERA_FPGAMGR_STAT_MSEL_SHIFT; /* Check that this MSEL setting is supported */ - if ((msel >= sizeof(cfgmgr_modes)/sizeof(struct cfgmgr_mode)) || + if ((msel >= ARRAY_SIZE(cfgmgr_modes)) || !cfgmgr_modes[msel].valid) return -EINVAL; ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] staging: fpga manager: fix platform_no_drv_owner.cocci warnings [not found] <201412102004.fChTGE0W%fengguang.wu@intel.com> 2014-12-10 12:48 ` [PATCH] staging: fpga manager: fix array_size.cocci warnings kbuild test robot @ 2014-12-10 12:48 ` kbuild test robot 1 sibling, 0 replies; 2+ messages in thread From: kbuild test robot @ 2014-12-10 12:48 UTC (permalink / raw) To: Alan Tull Cc: kbuild-all, Michal Simek, Greg Kroah-Hartman, devel, linux-kernel drivers/staging/fpga/altera.c:768:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan Tull <atull@opensource.altera.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- altera.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/fpga/altera.c +++ b/drivers/staging/fpga/altera.c @@ -765,7 +765,6 @@ static struct platform_driver altera_fpg .remove = altera_fpga_remove, .driver = { .name = "altera_fpga_manager", - .owner = THIS_MODULE, .of_match_table = of_match_ptr(altera_fpga_of_match), }, .probe = altera_fpga_probe, ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-10 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201412102004.fChTGE0W%fengguang.wu@intel.com>
2014-12-10 12:48 ` [PATCH] staging: fpga manager: fix array_size.cocci warnings kbuild test robot
2014-12-10 12:48 ` [PATCH] staging: fpga manager: fix platform_no_drv_owner.cocci warnings kbuild test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.