From: Eduardo Valentin <edubezval@gmail.com>
To: Abhilash Kesavan <kesavan.abhilash@gmail.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>,
Zhang Rui <rui.zhang@intel.com>,
Kukjin Kim <kgene.kim@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Amit Kachhap <amit.daniel@samsung.com>
Subject: Re: [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung
Date: Wed, 10 Dec 2014 10:41:15 -0400 [thread overview]
Message-ID: <20141210144112.GA3232@developer> (raw)
In-Reply-To: <CAM4voamr2yxqWq51-WuiWyVpS7hCyXJY8rE7dH3Xr7WwQoayiw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]
On Wed, Dec 10, 2014 at 09:26:55AM +0530, Abhilash Kesavan wrote:
> Hi Eduardo,
>
> On Mon, Dec 8, 2014 at 3:13 PM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> > Hi Abhilash,
> >
> >> As samsung thermal support is enabled only for ARCH_EXYNOS, there is
> >> no need to select ARCH_HAS_BANDGAP from the arch-specific code.
> >> Removing this dependency will also allow the driver to be enabled on
> >> 64-bit SoCs.
> >>
> >> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> >> ---
> >> This was based on the discussion regarding adding ARCH_HAS_BANDGAP
> >> symbol for arm64 here:
> >> http://www.spinics.net/lists/arm-kernel/msg377560.html
> >>
> >> drivers/thermal/samsung/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/thermal/samsung/Kconfig
> >> b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
> >> --- a/drivers/thermal/samsung/Kconfig
> >> +++ b/drivers/thermal/samsung/Kconfig
> >> @@ -1,6 +1,6 @@
> >> config EXYNOS_THERMAL
> >> tristate "Exynos thermal management unit driver"
> >> - depends on ARCH_HAS_BANDGAP && OF
> >> + depends on OF
> >> help
> >> If you say yes here you get support for the TMU (Thermal
> >> Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This
> >> driver initialises
> >
> > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Can you pick up these 2 patches if they look OK ?
OK. Adding to my fixes queue.
>
> Regards,
> Abhilash
> >
> > --
> > Best regards,
> >
> > Lukasz Majewski
> >
> > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung
Date: Wed, 10 Dec 2014 10:41:15 -0400 [thread overview]
Message-ID: <20141210144112.GA3232@developer> (raw)
In-Reply-To: <CAM4voamr2yxqWq51-WuiWyVpS7hCyXJY8rE7dH3Xr7WwQoayiw@mail.gmail.com>
On Wed, Dec 10, 2014 at 09:26:55AM +0530, Abhilash Kesavan wrote:
> Hi Eduardo,
>
> On Mon, Dec 8, 2014 at 3:13 PM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> > Hi Abhilash,
> >
> >> As samsung thermal support is enabled only for ARCH_EXYNOS, there is
> >> no need to select ARCH_HAS_BANDGAP from the arch-specific code.
> >> Removing this dependency will also allow the driver to be enabled on
> >> 64-bit SoCs.
> >>
> >> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> >> ---
> >> This was based on the discussion regarding adding ARCH_HAS_BANDGAP
> >> symbol for arm64 here:
> >> http://www.spinics.net/lists/arm-kernel/msg377560.html
> >>
> >> drivers/thermal/samsung/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/thermal/samsung/Kconfig
> >> b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
> >> --- a/drivers/thermal/samsung/Kconfig
> >> +++ b/drivers/thermal/samsung/Kconfig
> >> @@ -1,6 +1,6 @@
> >> config EXYNOS_THERMAL
> >> tristate "Exynos thermal management unit driver"
> >> - depends on ARCH_HAS_BANDGAP && OF
> >> + depends on OF
> >> help
> >> If you say yes here you get support for the TMU (Thermal
> >> Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This
> >> driver initialises
> >
> > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Can you pick up these 2 patches if they look OK ?
OK. Adding to my fixes queue.
>
> Regards,
> Abhilash
> >
> > --
> > Best regards,
> >
> > Lukasz Majewski
> >
> > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141210/373a3a28/attachment.sig>
next prev parent reply other threads:[~2014-12-10 14:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 6:34 [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Abhilash Kesavan
2014-12-02 6:34 ` Abhilash Kesavan
2014-12-02 6:34 ` [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection Abhilash Kesavan
2014-12-02 6:34 ` Abhilash Kesavan
2014-12-02 14:23 ` Bartlomiej Zolnierkiewicz
2014-12-02 14:23 ` Bartlomiej Zolnierkiewicz
2014-12-08 9:44 ` Lukasz Majewski
2014-12-08 9:44 ` Lukasz Majewski
2014-12-02 14:17 ` [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Bartlomiej Zolnierkiewicz
2014-12-02 14:17 ` Bartlomiej Zolnierkiewicz
2014-12-08 9:43 ` Lukasz Majewski
2014-12-08 9:43 ` Lukasz Majewski
2014-12-10 3:56 ` Abhilash Kesavan
2014-12-10 3:56 ` Abhilash Kesavan
2014-12-10 14:41 ` Eduardo Valentin [this message]
2014-12-10 14:41 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210144112.GA3232@developer \
--to=edubezval@gmail.com \
--cc=amit.daniel@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.