All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm8750: Make VREF a VMID instead of OUTPUT widget
Date: Thu, 11 Dec 2014 09:54:03 +0000	[thread overview]
Message-ID: <20141211095403.GH14516@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1418034191-28010-1-git-send-email-lars@metafoo.de>

On Mon, Dec 08, 2014 at 11:23:11AM +0100, Lars-Peter Clausen wrote:
> Commit 04489eeb02a4 ("ALSA: wm8750: add missing VREF output") added the
> previously missing VREF widget. And while adding the widget as OUTPUT widget
> silences the error of the missing widget it should have rather been a VMID
> widget.
> 
> The VREF widget is only used internally as a source for the VREF input of
> the Out3 Mux. Selecting that input means that the path should be kept
> powered up at the VREF/VMID voltage, but that there is no actual audio
> signal. Using a VMID widget will do this, whereas using a OUTPUT widget will
> simply cause the path to completely power down.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

  reply	other threads:[~2014-12-11  9:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 10:23 [PATCH] ASoC: wm8750: Make VREF a VMID instead of OUTPUT widget Lars-Peter Clausen
2014-12-11  9:54 ` Charles Keepax [this message]
2014-12-12 13:35 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141211095403.GH14516@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.