From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Alex Benn?e <alex.bennee@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/1] Sort include/qemu/typedefs.h
Date: Thu, 11 Dec 2014 14:02:58 +0000 [thread overview]
Message-ID: <20141211140257.GE2567@work-vm> (raw)
In-Reply-To: <87oaracoa6.fsf@linaro.org>
* Alex Benn?e (alex.bennee@linaro.org) wrote:
>
> Dr. David Alan Gilbert (git) <dgilbert@redhat.com> writes:
>
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Mainly to make it less likely to conflict during merges.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> I'm happy with the idea (having been adding stuff recently). However
> have you:
>
> a) checked for typedefs no longer used by the wider code base
> b) audited for others using opaque types pulling in full definitions?
Nope; I just sorted it - so it's nice and simple; but yes it's
probably worth doing those at some point.
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Thanks,
Dave
>
> Cheers,
>
> --
> Alex Bennée
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Alex Benn?e <alex.bennee@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Sort include/qemu/typedefs.h
Date: Thu, 11 Dec 2014 14:02:58 +0000 [thread overview]
Message-ID: <20141211140257.GE2567@work-vm> (raw)
In-Reply-To: <87oaracoa6.fsf@linaro.org>
* Alex Benn?e (alex.bennee@linaro.org) wrote:
>
> Dr. David Alan Gilbert (git) <dgilbert@redhat.com> writes:
>
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Mainly to make it less likely to conflict during merges.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> I'm happy with the idea (having been adding stuff recently). However
> have you:
>
> a) checked for typedefs no longer used by the wider code base
> b) audited for others using opaque types pulling in full definitions?
Nope; I just sorted it - so it's nice and simple; but yes it's
probably worth doing those at some point.
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Thanks,
Dave
>
> Cheers,
>
> --
> Alex Bennée
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-12-11 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 11:46 [Qemu-trivial] [PATCH 1/1] Sort include/qemu/typedefs.h Dr. David Alan Gilbert (git)
2014-12-11 11:46 ` [Qemu-devel] " Dr. David Alan Gilbert (git)
2014-12-11 13:24 ` [Qemu-trivial] " Alex Bennée
2014-12-11 13:24 ` Alex Bennée
2014-12-11 14:02 ` Dr. David Alan Gilbert [this message]
2014-12-11 14:02 ` Dr. David Alan Gilbert
2014-12-11 18:00 ` [Qemu-trivial] " Michael Tokarev
2014-12-11 18:00 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211140257.GE2567@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.