* [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention
@ 2014-12-11 11:53 Vicente Olivert Riera
2014-12-11 11:53 ` [Buildroot] [PATCH 2/2] libsvgtiny: add a patch to remove -Werror from Makefile Vicente Olivert Riera
2014-12-11 18:53 ` [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2014-12-11 11:53 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
Changes v1 -> v2: this patch did not exist in v1
...ntfs.patch => 0001-disable-debug-printfs.patch} | 0
...e-builddir.patch => 0002-create-builddir.patch} | 0
2 files changed, 0 insertions(+), 0 deletions(-)
rename package/libsvgtiny/{libsvgtiny-01-disable-debug-printfs.patch => 0001-disable-debug-printfs.patch} (100%)
rename package/libsvgtiny/{libsvgtiny-02-create-builddir.patch => 0002-create-builddir.patch} (100%)
diff --git a/package/libsvgtiny/libsvgtiny-01-disable-debug-printfs.patch b/package/libsvgtiny/0001-disable-debug-printfs.patch
similarity index 100%
rename from package/libsvgtiny/libsvgtiny-01-disable-debug-printfs.patch
rename to package/libsvgtiny/0001-disable-debug-printfs.patch
diff --git a/package/libsvgtiny/libsvgtiny-02-create-builddir.patch b/package/libsvgtiny/0002-create-builddir.patch
similarity index 100%
rename from package/libsvgtiny/libsvgtiny-02-create-builddir.patch
rename to package/libsvgtiny/0002-create-builddir.patch
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] libsvgtiny: add a patch to remove -Werror from Makefile
2014-12-11 11:53 [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention Vicente Olivert Riera
@ 2014-12-11 11:53 ` Vicente Olivert Riera
2014-12-11 18:53 ` [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2014-12-11 11:53 UTC (permalink / raw)
To: buildroot
glibc-2.20 includes some changes to the include/features.h file
introduced by this commit:
https://sourceware.org/git/?p=glibc.git;a=commit;h=ade40b10ff5fa59a318cf55b9d8414b758e8df78
Those changes make libsvgtiny fail because some warnings are thrown and
the build system is using the -Werror option. We disable this to be able
to build it, or otherwise we will see errors like this one:
GPERF: src/colors.gperf
COMPILE: build-Linux-Linux-release-lib-static/src_colors.c
In file included from
/br/output/host/usr/mipsel-buildroot-linux-gnu/sysroot/usr/include/string.h:25:0,
from src/colors.gperf:16:
/br/output/host/usr/mipsel-buildroot-linux-gnu/sysroot/usr/include/features.h:148:3:
error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use
_DEFAULT_SOURCE" [-Werror=cpp]
and this one:
In file included from src/colors.gperf:18:0:
/home/ldap/vriera/work/mips-buildroots/mips32/output/build/libsvgtiny-12121/src/svgtiny_internal.h:71:0:
error: "strndup" redefined [-Werror]
Fixes:
http://autobuild.buildroot.net/results/3dd/3dd700405055750262738f867eb5aa08531f5781/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
---
Chages v1 -> v2: add a patch instead of using a 'sed' command
package/libsvgtiny/0003-Remove-Werror.patch | 44 +++++++++++++++++++++++++++
1 files changed, 44 insertions(+), 0 deletions(-)
create mode 100644 package/libsvgtiny/0003-Remove-Werror.patch
diff --git a/package/libsvgtiny/0003-Remove-Werror.patch b/package/libsvgtiny/0003-Remove-Werror.patch
new file mode 100644
index 0000000..c8b0c0b
--- /dev/null
+++ b/package/libsvgtiny/0003-Remove-Werror.patch
@@ -0,0 +1,44 @@
+Remove -Werror from Makefile
+
+glibc-2.20 includes some changes to the include/features.h file
+introduced by this commit:
+
+ https://sourceware.org/git/?p=glibc.git;a=commit;h=ade40b10ff5fa59a318cf55b9d8414b758e8df78
+
+Those changes make libsvgtiny fail because some warnings are thrown and
+the build system is using the -Werror option. We disable this to be able
+to build it, or otherwise we will see errors like this one:
+
+GPERF: src/colors.gperf
+COMPILE: build-Linux-Linux-release-lib-static/src_colors.c
+In file included from
+/br/output/host/usr/mipsel-buildroot-linux-gnu/sysroot/usr/include/string.h:25:0,
+ from src/colors.gperf:16:
+/br/output/host/usr/mipsel-buildroot-linux-gnu/sysroot/usr/include/features.h:148:3:
+error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use
+_DEFAULT_SOURCE" [-Werror=cpp]
+
+and this one:
+
+In file included from src/colors.gperf:18:0:
+/home/ldap/vriera/work/mips-buildroots/mips32/output/build/libsvgtiny-12121/src/svgtiny_internal.h:71:0:
+error: "strndup" redefined [-Werror]
+
+Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
+
+diff -rup a/Makefile b/Makefile
+--- a/Makefile 2010-01-03 23:37:39.000000000 +0000
++++ b/Makefile 2014-12-11 11:35:37.241903884 +0000
+@@ -13,12 +13,6 @@ TESTRUNNER := $(ECHO)
+ WARNFLAGS := -Wall -W -Wundef -Wpointer-arith -Wcast-align \
+ -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes \
+ -Wmissing-declarations -Wnested-externs -pedantic
+-# BeOS/Haiku/AmigaOS4 standard library headers create warnings
+-ifneq ($(TARGET),beos)
+- ifneq ($(TARGET),AmigaOS)
+- WARNFLAGS := $(WARNFLAGS) -Werror
+- endif
+-endif
+ CFLAGS := -D_BSD_SOURCE -I$(CURDIR)/include/ \
+ -I$(CURDIR)/src $(WARNFLAGS) $(CFLAGS)
+ ifneq ($(GCCVER),2)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention
2014-12-11 11:53 [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention Vicente Olivert Riera
2014-12-11 11:53 ` [Buildroot] [PATCH 2/2] libsvgtiny: add a patch to remove -Werror from Makefile Vicente Olivert Riera
@ 2014-12-11 18:53 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-12-11 18:53 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Thu, 11 Dec 2014 11:53:20 +0000, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> Changes v1 -> v2: this patch did not exist in v1
>
> ...ntfs.patch => 0001-disable-debug-printfs.patch} | 0
> ...e-builddir.patch => 0002-create-builddir.patch} | 0
> 2 files changed, 0 insertions(+), 0 deletions(-)
> rename package/libsvgtiny/{libsvgtiny-01-disable-debug-printfs.patch => 0001-disable-debug-printfs.patch} (100%)
> rename package/libsvgtiny/{libsvgtiny-02-create-builddir.patch => 0002-create-builddir.patch} (100%)
Both patches applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-11 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-11 11:53 [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention Vicente Olivert Riera
2014-12-11 11:53 ` [Buildroot] [PATCH 2/2] libsvgtiny: add a patch to remove -Werror from Makefile Vicente Olivert Riera
2014-12-11 18:53 ` [Buildroot] [PATCH 1/2] libsvgtiny: rename patches to follow the new name convention Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.