From: "Michael S. Tsirkin" <mst@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC 3/5] pci: add pci_iomap_range
Date: Fri, 12 Dec 2014 01:49:36 +0200 [thread overview]
Message-ID: <20141211234936.GB9439@redhat.com> (raw)
In-Reply-To: <11102634.nzYXXfUH5X@wuerfel>
On Thu, Dec 11, 2014 at 11:27:54PM +0100, Arnd Bergmann wrote:
> On Thursday 11 December 2014 21:37:34 Michael S. Tsirkin wrote:
> > if (flags & IORESOURCE_MEM) {
> > - if (flags & IORESOURCE_CACHEABLE)
> > + if (!force_nocache && (flags & IORESOURCE_CACHEABLE))
> > return ioremap(start, len);
> > return ioremap_nocache(start, len);
> > }
> >
>
> ioremap is the same as ioremap_nocache, so this doesn't really make any
> sense. IORESOURCE_CACHEABLE is practically only set for ROM bars, which
> we rarely map.
>
> Arnd
Hmm I think you are right.
It's an old patch - I think at one point in time we did set it when we
now set IORESOURCE_PREFETCH.
I'll drop this parameter.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
cornelia.huck@de.ibm.com, linux-arch@vger.kernel.org
Subject: Re: [PATCH RFC 3/5] pci: add pci_iomap_range
Date: Fri, 12 Dec 2014 01:49:36 +0200 [thread overview]
Message-ID: <20141211234936.GB9439@redhat.com> (raw)
Message-ID: <20141211234936.ArHYNONIMnYN7_Hbsv5vPAeFDchgJg9pyupQL_OmfkI@z> (raw)
In-Reply-To: <11102634.nzYXXfUH5X@wuerfel>
On Thu, Dec 11, 2014 at 11:27:54PM +0100, Arnd Bergmann wrote:
> On Thursday 11 December 2014 21:37:34 Michael S. Tsirkin wrote:
> > if (flags & IORESOURCE_MEM) {
> > - if (flags & IORESOURCE_CACHEABLE)
> > + if (!force_nocache && (flags & IORESOURCE_CACHEABLE))
> > return ioremap(start, len);
> > return ioremap_nocache(start, len);
> > }
> >
>
> ioremap is the same as ioremap_nocache, so this doesn't really make any
> sense. IORESOURCE_CACHEABLE is practically only set for ROM bars, which
> we rarely map.
>
> Arnd
Hmm I think you are right.
It's an old patch - I think at one point in time we did set it when we
now set IORESOURCE_PREFETCH.
I'll drop this parameter.
--
MST
next prev parent reply other threads:[~2014-12-11 23:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 19:37 [PATCH RFC 0/5] virtio_pci: modern driver Michael S. Tsirkin
2014-12-11 19:37 ` Michael S. Tsirkin
2014-12-11 19:37 ` [PATCH RFC 1/5] virtio_pci: add VIRTIO_PCI_NO_LEGACY Michael S. Tsirkin
2014-12-11 19:37 ` Michael S. Tsirkin
2014-12-11 19:37 ` [PATCH RFC 2/5] virtio-pci: define layout for virtio 1.0 Michael S. Tsirkin
2014-12-11 19:37 ` Michael S. Tsirkin
2014-12-11 19:37 ` [PATCH RFC 3/5] pci: add pci_iomap_range Michael S. Tsirkin
2014-12-11 22:27 ` Arnd Bergmann
2014-12-11 22:27 ` Arnd Bergmann
2014-12-11 23:49 ` Michael S. Tsirkin [this message]
2014-12-11 23:49 ` Michael S. Tsirkin
2014-12-11 19:37 ` Michael S. Tsirkin
2014-12-11 19:37 ` [PATCH RFC 4/5] virtio_pci: modern driver Michael S. Tsirkin
2014-12-11 19:37 ` Michael S. Tsirkin
2014-12-11 19:37 ` [PATCH RFC 5/5] virtio_pci: macros for PCI layout offsets Michael S. Tsirkin
2014-12-11 19:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211234936.GB9439@redhat.com \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.