[PATCH bluetooth-next 0/6] Various coding style cleanups and typo fixes

[PATCH bluetooth-next 0/6] Various coding style cleanups and typo fixes

[Stefan Schmidt]

Hello.

Just some smaller cleanups while going through the codebase. I'm aware that the
3.19 merge window is already open. If you feel these are .20 material feel free to
stick them in a branch or let me know when you want me to re-submit them.

regards
Stefan Schmidt

Stefan Schmidt (6):
  ieee802154/at86rf230: Remove unneeded blank lines
  ieee802154/at86rf230: Align to opening parenthesis
  ieee802154/at86rf230: Fix typo unkown -> unknown
  ieee802154/cc2520: Remove extra blank lines
  ieee802154/mrf24j40: Fix typo begining -> beginning
  ieee802154/mrf24j40: Fix alignment of parenthesis

 drivers/net/ieee802154/at86rf230.c | 12 +++++-------
 drivers/net/ieee802154/cc2520.c    |  2 --
 drivers/net/ieee802154/mrf24j40.c  |  6 +++---
 3 files changed, 8 insertions(+), 12 deletions(-)

-- 
1.9.3

[PATCH bluetooth-next 1/6] ieee802154/at86rf230: Remove unneeded blank lines

[Stefan Schmidt]

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 drivers/net/ieee802154/at86rf230.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 1c01356..88be161 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -524,7 +524,6 @@ at86rf230_async_state_assert(void *context)
 			}
 		}
 
-
 		dev_warn(&lp->spi->dev, "unexcept state change from 0x%02x to 0x%02x. Actual state: 0x%02x\n",
 			 ctx->from_state, ctx->to_state, trx_state);
 	}
@@ -762,7 +761,6 @@ at86rf230_tx_trac_check(void *context)
 	at86rf230_tx_on(context);
 }
 
-
 static void
 at86rf230_tx_trac_status(void *context)
 {
-- 
1.9.3

[PATCH bluetooth-next 2/6] ieee802154/at86rf230: Align to opening parenthesis

[Stefan Schmidt]

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 drivers/net/ieee802154/at86rf230.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 88be161..069c20f 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1080,7 +1080,7 @@ at86rf230_set_hw_addr_filt(struct ieee802154_hw *hw,
 		u16 addr = le16_to_cpu(filt->short_addr);
 
 		dev_vdbg(&lp->spi->dev,
-			"at86rf230_set_hw_addr_filt called for saddr\n");
+			 "at86rf230_set_hw_addr_filt called for saddr\n");
 		__at86rf230_write(lp, RG_SHORT_ADDR_0, addr);
 		__at86rf230_write(lp, RG_SHORT_ADDR_1, addr >> 8);
 	}
@@ -1089,7 +1089,7 @@ at86rf230_set_hw_addr_filt(struct ieee802154_hw *hw,
 		u16 pan = le16_to_cpu(filt->pan_id);
 
 		dev_vdbg(&lp->spi->dev,
-			"at86rf230_set_hw_addr_filt called for pan id\n");
+			 "at86rf230_set_hw_addr_filt called for pan id\n");
 		__at86rf230_write(lp, RG_PAN_ID_0, pan);
 		__at86rf230_write(lp, RG_PAN_ID_1, pan >> 8);
 	}
@@ -1099,14 +1099,14 @@ at86rf230_set_hw_addr_filt(struct ieee802154_hw *hw,
 
 		memcpy(addr, &filt->ieee_addr, 8);
 		dev_vdbg(&lp->spi->dev,
-			"at86rf230_set_hw_addr_filt called for IEEE addr\n");
+			 "at86rf230_set_hw_addr_filt called for IEEE addr\n");
 		for (i = 0; i < 8; i++)
 			__at86rf230_write(lp, RG_IEEE_ADDR_0 + i, addr[i]);
 	}
 
 	if (changed & IEEE802154_AFILT_PANC_CHANGED) {
 		dev_vdbg(&lp->spi->dev,
-			"at86rf230_set_hw_addr_filt called for panc change\n");
+			 "at86rf230_set_hw_addr_filt called for panc change\n");
 		if (filt->pan_coord)
 			at86rf230_write_subreg(lp, SR_AACK_I_AM_COORD, 1);
 		else
-- 
1.9.3

[PATCH bluetooth-next 3/6] ieee802154/at86rf230: Fix typo unkown -> unknown

[Stefan Schmidt]

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 drivers/net/ieee802154/at86rf230.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 069c20f..2c338a4 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1446,7 +1446,7 @@ at86rf230_detect_device(struct at86rf230_local *lp)
 		lp->hw->phy->symbol_duration = 16;
 		break;
 	default:
-		chip = "unkown";
+		chip = "unknown";
 		rc = -ENOTSUPP;
 		break;
 	}
-- 
1.9.3

[PATCH bluetooth-next 4/6] ieee802154/cc2520: Remove extra blank lines

[Stefan Schmidt]

CC: Varka Bhadram <varkabhadram@gmail.com>
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 drivers/net/ieee802154/cc2520.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index f9df9fa..c2b7da3 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -513,7 +513,6 @@ err_tx:
 	return rc;
 }
 
-
 static int cc2520_rx(struct cc2520_private *priv)
 {
 	u8 len = 0, lqi = 0, bytes = 1;
@@ -947,7 +946,6 @@ static int cc2520_probe(struct spi_device *spi)
 	if (ret)
 		goto err_hw_init;
 
-
 	gpio_set_value(pdata->vreg, HIGH);
 	usleep_range(100, 150);
 
-- 
1.9.3

[PATCH bluetooth-next 5/6] ieee802154/mrf24j40: Fix typo begining -> beginning

[Stefan Schmidt]

CC: Alan Ott <alan@signal11.us>
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 drivers/net/ieee802154/mrf24j40.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index a200fa1..ec605c9 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -289,7 +289,7 @@ static int mrf24j40_read_rx_buf(struct mrf24j40 *devrec,
 		goto out;
 
 	/* Range check the RX FIFO length, accounting for the one-byte
-	 * length field at the begining. */
+	 * length field at the beginning. */
 	if (rx_len > RX_FIFO_SIZE-1) {
 		dev_err(printdev(devrec), "Invalid length read from device. Performing short read.\n");
 		rx_len = RX_FIFO_SIZE-1;
-- 
1.9.3

[PATCH bluetooth-next 6/6] ieee802154/mrf24j40: Fix alignment of parenthesis

[Stefan Schmidt]

CC: Alan Ott <alan@signal11.us>
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 drivers/net/ieee802154/mrf24j40.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index ec605c9..fba2dfd 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -323,7 +323,7 @@ static int mrf24j40_read_rx_buf(struct mrf24j40 *devrec,
 
 #ifdef DEBUG
 	print_hex_dump(KERN_DEBUG, "mrf24j40 rx: ",
-		DUMP_PREFIX_OFFSET, 16, 1, data, *len, 0);
+		       DUMP_PREFIX_OFFSET, 16, 1, data, *len, 0);
 	pr_debug("mrf24j40 rx: lqi: %02hhx rssi: %02hhx\n",
 		 lqi_rssi[0], lqi_rssi[1]);
 #endif
@@ -521,7 +521,7 @@ static int mrf24j40_filter(struct ieee802154_hw *hw,
 		 */
 
 		dev_dbg(printdev(devrec), "Set Pan Coord to %s\n",
-					filt->pan_coord ? "on" : "off");
+			filt->pan_coord ? "on" : "off");
 	}
 
 	return 0;
-- 
1.9.3

Re: [PATCH bluetooth-next 0/6] Various coding style cleanups and typo fixes

[Alexander Aring]

On Fri, Dec 12, 2014 at 12:45:27PM +0100, Stefan Schmidt wrote:
> Hello.
> 
> Just some smaller cleanups while going through the codebase. I'm aware that the
> 3.19 merge window is already open. If you feel these are .20 material feel free to
> stick them in a branch or let me know when you want me to re-submit them.
> 

On the complete serie:

Acked-by: Alexander Aring <alex.aring@gmail.com>

Thanks.

- Alex

Re: [PATCH bluetooth-next 0/6] Various coding style cleanups and typo fixes

[Marcel Holtmann]

Hi Stefan,

> Just some smaller cleanups while going through the codebase. I'm aware that the
> 3.19 merge window is already open. If you feel these are .20 material feel free to
> stick them in a branch or let me know when you want me to re-submit them.
> 
> regards
> Stefan Schmidt
> 
> Stefan Schmidt (6):
>  ieee802154/at86rf230: Remove unneeded blank lines
>  ieee802154/at86rf230: Align to opening parenthesis
>  ieee802154/at86rf230: Fix typo unkown -> unknown
>  ieee802154/cc2520: Remove extra blank lines
>  ieee802154/mrf24j40: Fix typo begining -> beginning
>  ieee802154/mrf24j40: Fix alignment of parenthesis
> 
> drivers/net/ieee802154/at86rf230.c | 12 +++++-------
> drivers/net/ieee802154/cc2520.c    |  2 --
> drivers/net/ieee802154/mrf24j40.c  |  6 +++---
> 3 files changed, 8 insertions(+), 12 deletions(-)

all 6 patches have been applied to bluetooth-next tree.

Regards

Marcel