From: Dan Carpenter <dan.carpenter@oracle.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] ALSA: oxfw: some signedness bugs
Date: Sat, 13 Dec 2014 10:04:14 +0300 [thread overview]
Message-ID: <20141213070414.GA4973@mwanda> (raw)
In-Reply-To: <548BC973.3090004@sakamocchi.jp>
On Sat, Dec 13, 2014 at 02:06:59PM +0900, Takashi Sakamoto wrote:
> On Dec 13 2014 04:27, Dan Carpenter wrote:
> > This code tends to use unsigned variables by default and it causes
> > signedness bugs when we use negative variables for error handling.
> > The "i" and "j" variables are used to iterated over small positive
> > values and so they should be type "int". The "len" variable doesn't
> > *need* to be signed but it should be signed to make the code easier to
> > read and audit.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks, but I prefer to use 'unsigned int' for loop counter, like the
> other drivers.
Unthinking use of unsigned int every where is a kind of leprosy. It
just makes the code hard to read and it causes bugs.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] ALSA: oxfw: some signedness bugs
Date: Sat, 13 Dec 2014 07:04:14 +0000 [thread overview]
Message-ID: <20141213070414.GA4973@mwanda> (raw)
In-Reply-To: <548BC973.3090004@sakamocchi.jp>
On Sat, Dec 13, 2014 at 02:06:59PM +0900, Takashi Sakamoto wrote:
> On Dec 13 2014 04:27, Dan Carpenter wrote:
> > This code tends to use unsigned variables by default and it causes
> > signedness bugs when we use negative variables for error handling.
> > The "i" and "j" variables are used to iterated over small positive
> > values and so they should be type "int". The "len" variable doesn't
> > *need* to be signed but it should be signed to make the code easier to
> > read and audit.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks, but I prefer to use 'unsigned int' for loop counter, like the
> other drivers.
Unthinking use of unsigned int every where is a kind of leprosy. It
just makes the code hard to read and it causes bugs.
regards,
dan carpenter
next prev parent reply other threads:[~2014-12-13 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 19:27 [patch 1/2] ALSA: oxfw: some signedness bugs Dan Carpenter
2014-12-12 19:27 ` Dan Carpenter
2014-12-13 5:06 ` Takashi Sakamoto
2014-12-13 5:06 ` Takashi Sakamoto
2014-12-13 7:04 ` Dan Carpenter [this message]
2014-12-13 7:04 ` Dan Carpenter
2014-12-13 10:14 ` Takashi Sakamoto
2014-12-13 10:14 ` Takashi Sakamoto
2014-12-13 11:35 ` Dan Carpenter
2014-12-13 11:35 ` Dan Carpenter
2014-12-13 11:38 ` Dan Carpenter
2014-12-13 11:38 ` Dan Carpenter
2014-12-13 17:30 ` Takashi Iwai
2014-12-13 17:30 ` Takashi Iwai
2014-12-14 17:01 ` Takashi Sakamoto
2014-12-14 17:01 ` Takashi Sakamoto
2014-12-15 9:03 ` Takashi Iwai
2014-12-15 9:03 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141213070414.GA4973@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.