All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl()
Date: Mon, 15 Dec 2014 08:59:13 +0100	[thread overview]
Message-ID: <20141215075912.GS27182@phenom.ffwll.local> (raw)
In-Reply-To: <548D9A49.80203@vodafone.de>

On Sun, Dec 14, 2014 at 03:10:17PM +0100, Christian König wrote:
> Am 14.12.2014 um 14:35 schrieb Oded Gabbay:
> >When an ioctl function returns -EAGAIN, don't print error in kfd_ioctl()
> 
> You most likely want to handle -ERESTARTSYS the same way.

Please just reuse drmIoctl or at least copy it perfectly. We've had too
many tears about ioctl restarting going badly wrong. Also make sure you
never do a raw ioctl call anywhere for amdkfd. Adding Dave.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2014-12-15  7:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-14 13:35 [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl() Oded Gabbay
2014-12-14 13:35 ` [PATCH 2/4] amdkfd: Add number of watch points to topology Oded Gabbay
2014-12-14 13:35 ` [PATCH 3/4] amdkfd: Remove duplicate include Oded Gabbay
2014-12-14 13:35 ` [PATCH 4/4] amdkfd: Process-device data creation and lookup split Oded Gabbay
2014-12-14 14:10 ` [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl() Christian König
2014-12-14 14:20   ` Oded Gabbay
2014-12-15  7:59   ` Daniel Vetter [this message]
2014-12-15  8:32     ` Dave Airlie
2014-12-15 13:48       ` Oded Gabbay
2014-12-29 12:44       ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141215075912.GS27182@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=deathsimple@vodafone.de \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.