From: Oded Gabbay <oded.gabbay@amd.com>
To: Dave Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl()
Date: Mon, 15 Dec 2014 15:48:18 +0200 [thread overview]
Message-ID: <548EE6A2.2070401@amd.com> (raw)
In-Reply-To: <CAPM=9tznW=xOexrHpczPbKn39CuB4Y_-mGFuhM8qV1HTL00bnA@mail.gmail.com>
On 12/15/2014 10:32 AM, Dave Airlie wrote:
> On 15 December 2014 at 17:59, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Sun, Dec 14, 2014 at 03:10:17PM +0100, Christian König wrote:
>>> Am 14.12.2014 um 14:35 schrieb Oded Gabbay:
>>>> When an ioctl function returns -EAGAIN, don't print error in kfd_ioctl()
>>>
>>> You most likely want to handle -ERESTARTSYS the same way.
>>
>> Please just reuse drmIoctl or at least copy it perfectly. We've had too
>> many tears about ioctl restarting going badly wrong. Also make sure you
>> never do a raw ioctl call anywhere for amdkfd. Adding Dave.
>
> Also please don't make a user triggerable printk.
>
> If the user can throw crap at the ioctl and get msgs in dmesg,
> then its annoying as hell.
>
> Copy the drm.debug stuff and code as well, and for userspace,
> yes do what Daniel says and use drmIoctl wrapper or something like
> that, though Daniel I believe one of the main consumers on i915
> insists on opencoding his ioctls.
>
> Dave.
>
Dave & Daniel,
Thanks for the guidance & comments.
I will take a look at drmioctl & drm.debug stuff and copy/reuse what's
relevant.
After that, I'll resubmit this patch, and probably this will generate
some more patches for me to submit for review.
Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-12-15 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 13:35 [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl() Oded Gabbay
2014-12-14 13:35 ` [PATCH 2/4] amdkfd: Add number of watch points to topology Oded Gabbay
2014-12-14 13:35 ` [PATCH 3/4] amdkfd: Remove duplicate include Oded Gabbay
2014-12-14 13:35 ` [PATCH 4/4] amdkfd: Process-device data creation and lookup split Oded Gabbay
2014-12-14 14:10 ` [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl() Christian König
2014-12-14 14:20 ` Oded Gabbay
2014-12-15 7:59 ` Daniel Vetter
2014-12-15 8:32 ` Dave Airlie
2014-12-15 13:48 ` Oded Gabbay [this message]
2014-12-29 12:44 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548EE6A2.2070401@amd.com \
--to=oded.gabbay@amd.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.