All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Jeremiah Mahler <jmmahler@gmail.com>,
	devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	jun.j.tian@intel.com, linux-kernel@vger.kernel.org,
	joe@perches.com, octavian.purdila@intel.com, apw@canonical.com,
	nnk@google.com, alan@linux.intel.com
Subject: Re: [PATCH] checkpatch giving bogus advice (was staging: goldfish: Fix minor coding style)
Date: Mon, 15 Dec 2014 14:59:56 +0300	[thread overview]
Message-ID: <20141215115956.GD4856@mwanda> (raw)
In-Reply-To: <20141215114421.7389d32a@lxorguk.ukuu.org.uk>

I haven't seen any bugs caused by lack of type safety with "!foo"...
I prefer !foo because it is more common in the kernel and I think it's
easier to read but I don't feel strongly about this.

I kind of hate "if (foo != NULL) though, because it's a double negative.
But I really hate when people start adding the "!= 0" on to all their
conditions.

	if (frob() != 0)

Also:

	if (a + b != 0)

People do this all the time instead of "if (a || b)" and I don't know
why...

regards,
dan carpenter


  reply	other threads:[~2014-12-15 12:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-13 16:29 [PATCH] staging: goldfish: Fix minor coding style Loic Pefferkorn
2014-12-13 17:55 ` Jeremiah Mahler
2014-12-13 18:22   ` Loic Pefferkorn
2014-12-13 19:46     ` Jeremiah Mahler
2014-12-15 11:44       ` [PATCH] checkpatch giving bogus advice (was staging: goldfish: Fix minor coding style) One Thousand Gnomes
2014-12-15 11:59         ` Dan Carpenter [this message]
2014-12-16  0:50           ` Joe Perches
2014-12-15 13:03         ` Jeremiah Mahler
2014-12-15 13:43           ` Dan Carpenter
2014-12-15 14:08             ` Jeremiah Mahler
2014-12-13 19:07 ` [PATCH] staging: goldfish: Fix minor coding style One Thousand Gnomes
2014-12-13 21:20   ` Loic Pefferkorn
2014-12-15 11:51     ` One Thousand Gnomes
2014-12-15 12:26       ` Loic Pefferkorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141215115956.GD4856@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alan@linux.intel.com \
    --cc=apw@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmmahler@gmail.com \
    --cc=joe@perches.com \
    --cc=jun.j.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nnk@google.com \
    --cc=octavian.purdila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.