From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeremiah Mahler <jmmahler@gmail.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Loic Pefferkorn <loic@loicp.eu>,
gregkh@linuxfoundation.org, alan@linux.intel.com,
jun.j.tian@intel.com, octavian.purdila@intel.com, nnk@google.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
apw@canonical.com, joe@perches.com
Subject: Re: [PATCH] checkpatch giving bogus advice (was staging: goldfish: Fix minor coding style)
Date: Mon, 15 Dec 2014 16:43:34 +0300 [thread overview]
Message-ID: <20141215134334.GE4856@mwanda> (raw)
In-Reply-To: <20141215130346.GB18251@hudson.localdomain>
On Mon, Dec 15, 2014 at 05:03:46AM -0800, Jeremiah Mahler wrote:
>
> Or another way mentioned in K&R that produces a compile error
>
> if (NULL = x)
>
Yes. People used to write Yoda code back in the day. Don't ever do
this in the kernel.
1) It looks stupid.
2) GCC will catch most == vs = bugs as Alan pointed out.
3) There are still some that sneak through because people put double
parenthesis around everything like "if ((foo = NULL) || (...)) {",
but checkpatch.pl and Smatch will catch those.
regards,
dan carpenter
next prev parent reply other threads:[~2014-12-15 13:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 16:29 [PATCH] staging: goldfish: Fix minor coding style Loic Pefferkorn
2014-12-13 17:55 ` Jeremiah Mahler
2014-12-13 18:22 ` Loic Pefferkorn
2014-12-13 19:46 ` Jeremiah Mahler
2014-12-15 11:44 ` [PATCH] checkpatch giving bogus advice (was staging: goldfish: Fix minor coding style) One Thousand Gnomes
2014-12-15 11:59 ` Dan Carpenter
2014-12-16 0:50 ` Joe Perches
2014-12-15 13:03 ` Jeremiah Mahler
2014-12-15 13:43 ` Dan Carpenter [this message]
2014-12-15 14:08 ` Jeremiah Mahler
2014-12-13 19:07 ` [PATCH] staging: goldfish: Fix minor coding style One Thousand Gnomes
2014-12-13 21:20 ` Loic Pefferkorn
2014-12-15 11:51 ` One Thousand Gnomes
2014-12-15 12:26 ` Loic Pefferkorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215134334.GE4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=apw@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jmmahler@gmail.com \
--cc=joe@perches.com \
--cc=jun.j.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loic@loicp.eu \
--cc=nnk@google.com \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.