From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
Phil Edworthy <phil.edworthy@renesas.com>,
Jingoo Han <jg1.han@samsung.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Russell King <linux@arm.linux.org.uk>,
Mohit Kumar <mohit.kumar@st.com>
Subject: Re: [PATCH v3 2/2] arm: pcibios: move to generic PCI domains
Date: Mon, 15 Dec 2014 17:18:51 -0700 [thread overview]
Message-ID: <20141216001851.GA1991@obsidianresearch.com> (raw)
In-Reply-To: <1416569367-29409-3-git-send-email-lorenzo.pieralisi@arm.com>
On Fri, Nov 21, 2014 at 11:29:26AM +0000, Lorenzo Pieralisi wrote:
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> index b1315e1..dc2ed4d 100644
> +++ b/drivers/pci/host/pci-mvebu.c
> @@ -101,9 +101,7 @@ struct mvebu_pcie {
> struct mvebu_pcie_port *ports;
> struct msi_chip *msi;
> struct resource io;
> - char io_name[30];
> struct resource realio;
> - char mem_name[30];
> struct resource mem;
> struct resource busn;
> int nports;
> @@ -722,18 +720,9 @@ static int mvebu_pcie_setup(int nr, struct pci_sys_data *sys)
> {
> struct mvebu_pcie *pcie = sys_to_pcie(sys);
> int i;
> - int domain = 0;
>
> -#ifdef CONFIG_PCI_DOMAINS
> - domain = sys->domain;
> -#endif
> -
> - snprintf(pcie->mem_name, sizeof(pcie->mem_name), "PCI MEM %04x",
> - domain);
> - pcie->mem.name = pcie->mem_name;
> -
> - snprintf(pcie->io_name, sizeof(pcie->io_name), "PCI I/O %04x", domain);
> - pcie->realio.name = pcie->io_name;
> + pcie->mem.name = "PCI MEM";
> + pcie->realio.name = "PCI I/O";
>
> if (request_resource(&iomem_resource, &pcie->mem))
> return 0;
For the mvebu section:
Reviewed-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] arm: pcibios: move to generic PCI domains
Date: Mon, 15 Dec 2014 17:18:51 -0700 [thread overview]
Message-ID: <20141216001851.GA1991@obsidianresearch.com> (raw)
In-Reply-To: <1416569367-29409-3-git-send-email-lorenzo.pieralisi@arm.com>
On Fri, Nov 21, 2014 at 11:29:26AM +0000, Lorenzo Pieralisi wrote:
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> index b1315e1..dc2ed4d 100644
> +++ b/drivers/pci/host/pci-mvebu.c
> @@ -101,9 +101,7 @@ struct mvebu_pcie {
> struct mvebu_pcie_port *ports;
> struct msi_chip *msi;
> struct resource io;
> - char io_name[30];
> struct resource realio;
> - char mem_name[30];
> struct resource mem;
> struct resource busn;
> int nports;
> @@ -722,18 +720,9 @@ static int mvebu_pcie_setup(int nr, struct pci_sys_data *sys)
> {
> struct mvebu_pcie *pcie = sys_to_pcie(sys);
> int i;
> - int domain = 0;
>
> -#ifdef CONFIG_PCI_DOMAINS
> - domain = sys->domain;
> -#endif
> -
> - snprintf(pcie->mem_name, sizeof(pcie->mem_name), "PCI MEM %04x",
> - domain);
> - pcie->mem.name = pcie->mem_name;
> -
> - snprintf(pcie->io_name, sizeof(pcie->io_name), "PCI I/O %04x", domain);
> - pcie->realio.name = pcie->io_name;
> + pcie->mem.name = "PCI MEM";
> + pcie->realio.name = "PCI I/O";
>
> if (request_resource(&iomem_resource, &pcie->mem))
> return 0;
For the mvebu section:
Reviewed-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Jason
next prev parent reply other threads:[~2014-12-16 0:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 11:29 [PATCH v3 0/2] arm: pcibios: remove pci_sys_data domain Lorenzo Pieralisi
2014-11-21 11:29 ` Lorenzo Pieralisi
2014-11-21 11:29 ` [PATCH v3 1/2] arm: cns3xxx: pci: remove artificial dependency on " Lorenzo Pieralisi
2014-11-21 11:29 ` Lorenzo Pieralisi
2014-11-21 11:29 ` [PATCH v3 2/2] arm: pcibios: move to generic PCI domains Lorenzo Pieralisi
2014-11-21 11:29 ` Lorenzo Pieralisi
2014-12-16 0:18 ` Jason Gunthorpe [this message]
2014-12-16 0:18 ` Jason Gunthorpe
2014-12-15 23:52 ` [PATCH v3 0/2] arm: pcibios: remove pci_sys_data domain Bjorn Helgaas
2014-12-15 23:52 ` Bjorn Helgaas
2014-12-15 23:56 ` Bjorn Helgaas
2014-12-15 23:56 ` Bjorn Helgaas
2014-12-16 0:08 ` Russell King - ARM Linux
2014-12-16 0:08 ` Russell King - ARM Linux
2014-12-16 0:35 ` Bjorn Helgaas
2014-12-16 0:35 ` Bjorn Helgaas
2014-12-18 23:12 ` Murali Karicheri
2014-12-18 23:12 ` Murali Karicheri
2014-12-18 23:25 ` Arnd Bergmann
2014-12-18 23:25 ` Arnd Bergmann
2014-12-19 15:22 ` Murali Karicheri
2014-12-19 15:22 ` Murali Karicheri
2014-12-19 9:19 ` Lorenzo Pieralisi
2014-12-19 9:19 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216001851.GA1991@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mohit.kumar@st.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.