Re: [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	dedekind1@gmail.com
Subject: Re: [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown
Date: Wed, 17 Dec 2014 11:26:44 -0300	[thread overview]
Message-ID: <20141217142644.GB19525@fox> (raw)
In-Reply-To: <1416835236-25185-4-git-send-email-richard@nod.at>

On Mon, Nov 24, 2014 at 02:20:33PM +0100, Richard Weinberger wrote:
> ...otherwise the deferred work might run after datastructures
> got freed and corrupt memory.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>

After moving it to shutdown_work():

Reviewed-by: Guido Martínez <guido@vanguardiasur.com.ar>

> ---
>  drivers/mtd/ubi/wl.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index 7f135df..cb2e571 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -2041,6 +2041,9 @@ static void protection_queue_destroy(struct ubi_device *ubi)
>  void ubi_wl_close(struct ubi_device *ubi)
>  {
>  	dbg_wl("close the WL sub-system");
> +#ifdef CONFIG_MTD_UBI_FASTMAP
> +	flush_work(&ubi->fm_work);
> +#endif
>  	shutdown_work(ubi);
>  	protection_queue_destroy(ubi);
>  	tree_destroy(&ubi->used);
> -- 
> 1.8.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Guido Martínez, VanguardiaSur
www.vanguardiasur.com.ar

WARNING: multiple messages have this Message-ID (diff)

From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: Richard Weinberger <richard@nod.at>
Cc: dedekind1@gmail.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown
Date: Wed, 17 Dec 2014 11:26:44 -0300	[thread overview]
Message-ID: <20141217142644.GB19525@fox> (raw)
In-Reply-To: <1416835236-25185-4-git-send-email-richard@nod.at>

On Mon, Nov 24, 2014 at 02:20:33PM +0100, Richard Weinberger wrote:
> ...otherwise the deferred work might run after datastructures
> got freed and corrupt memory.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>

After moving it to shutdown_work():

Reviewed-by: Guido Martínez <guido@vanguardiasur.com.ar>

> ---
>  drivers/mtd/ubi/wl.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index 7f135df..cb2e571 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -2041,6 +2041,9 @@ static void protection_queue_destroy(struct ubi_device *ubi)
>  void ubi_wl_close(struct ubi_device *ubi)
>  {
>  	dbg_wl("close the WL sub-system");
> +#ifdef CONFIG_MTD_UBI_FASTMAP
> +	flush_work(&ubi->fm_work);
> +#endif
>  	shutdown_work(ubi);
>  	protection_queue_destroy(ubi);
>  	tree_destroy(&ubi->used);
> -- 
> 1.8.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Guido Martínez, VanguardiaSur
www.vanguardiasur.com.ar

next prev parent reply	other threads:[~2014-12-17 14:27 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 13:20 Fastmap update v2 (pile 1) Richard Weinberger
2014-11-24 13:20 ` [PATCH 1/6] UBI: Fastmap: Care about the protection queue Richard Weinberger
2014-11-24 13:20   ` Richard Weinberger
2014-11-27 14:54   ` Artem Bityutskiy
2015-01-09 21:23   ` Ezequiel Garcia
2015-01-09 21:31     ` Richard Weinberger
2015-01-09 21:34       ` Ezequiel Garcia
2014-11-24 13:20 ` [PATCH 2/6] UBI: Fastmap: Ensure that only one fastmap work is scheduled Richard Weinberger
2014-11-24 13:20   ` Richard Weinberger
2014-11-27 15:27   ` Artem Bityutskiy
2014-11-27 16:13     ` Richard Weinberger
2014-11-27 16:35       ` Artem Bityutskiy
2014-11-27 16:39         ` Richard Weinberger
2014-11-27 16:49           ` Artem Bityutskiy
2014-12-04 16:14   ` Tanya Brokhman
2014-12-17 13:51   ` Guido Martínez
2014-12-17 13:51     ` Guido Martínez
2014-11-24 13:20 ` [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown Richard Weinberger
2014-11-24 13:20   ` Richard Weinberger
2014-11-27 15:38   ` Artem Bityutskiy
2014-11-27 16:08     ` Richard Weinberger
2014-11-27 16:29       ` Artem Bityutskiy
2014-11-27 16:35         ` Richard Weinberger
2014-11-27 16:47           ` Artem Bityutskiy
2014-11-28  9:53             ` Richard Weinberger
2014-12-04 16:44     ` Tanya Brokhman
2014-12-04 17:21       ` Richard Weinberger
2014-12-17 14:26   ` Guido Martínez [this message]
2014-12-17 14:26     ` Guido Martínez
2015-01-09 21:32   ` Ezequiel Garcia
2015-01-09 21:37     ` Richard Weinberger
2015-01-09 21:39       ` Ezequiel Garcia
2014-11-24 13:20 ` [PATCH 4/6] UBI: Fastmap: Fix races in ubi_wl_get_peb() Richard Weinberger
2014-11-24 13:20   ` Richard Weinberger
2014-12-05 13:09   ` Tanya Brokhman
2014-12-05 13:20     ` Richard Weinberger
2014-12-05 16:54       ` Tanya Brokhman
2014-12-05 21:08         ` Richard Weinberger
2014-12-07  7:36           ` Tanya Brokhman
2014-12-07  9:45             ` Richard Weinberger
2014-11-24 13:20 ` [PATCH 5/6] UBI: Split __wl_get_peb() Richard Weinberger
2014-11-24 13:20   ` Richard Weinberger
2014-12-05 17:41   ` Tanya Brokhman
2014-12-05 21:02     ` Richard Weinberger
2014-12-17 15:03   ` Guido Martínez
2014-12-17 15:03     ` Guido Martínez
2014-11-24 13:20 ` [PATCH 6/6] UBI: Fastmap: Make ubi_refill_pools() fair Richard Weinberger
2014-11-24 13:20   ` Richard Weinberger
2014-12-05 17:55   ` Tanya Brokhman
2014-12-05 20:56     ` Richard Weinberger
2014-12-07  7:55       ` Tanya Brokhman
2014-12-07  9:49         ` Richard Weinberger
2014-12-17 15:48   ` Guido Martínez
2014-12-17 15:48     ` Guido Martínez
2014-11-27 14:53 ` Fastmap update v2 (pile 1) Artem Bityutskiy
2014-11-27 14:59   ` Richard Weinberger
2014-12-10  8:21 ` Richard Weinberger
2014-12-10  8:21   ` Richard Weinberger
2015-01-05 10:37   ` Richard Weinberger
2015-01-05 10:37     ` Richard Weinberger
2015-01-09 21:38 ` Ezequiel Garcia
2015-01-09 21:55   ` Richard Weinberger
2015-01-09 22:09     ` Ezequiel Garcia
2015-01-09 22:20       ` Richard Weinberger
2015-03-29 10:46 ` Richard Weinberger
2015-03-29 10:46   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141217142644.GB19525@fox \
    --to=guido@vanguardiasur.com.ar \
    --cc=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.