From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH 2/2] i2c: sh_mobile: rework deferred probing
Date: Wed, 17 Dec 2014 19:29:06 +0100 [thread overview]
Message-ID: <20141217182905.GD3981@katana> (raw)
In-Reply-To: <1418733086-26324-3-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Tue, Dec 16, 2014 at 01:31:26PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> DMA is opt-in for this driver. So, we can't use deferred probing for
> requesting DMA channels in probe, because our driver would get endlessly
> deferred if DMA support is compiled in AND the DMA driver is missing.
> Because we can't know when the DMA driver might show up, we always try
> again when a DMA transfer would be possible. The downside is that there
> is more overhead for setting up PIO transfers under the above scenario.
> But well, having DMA enabled and the proper DMA driver missing looks
> like a broken or test config anyhow.
>
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH 2/2] i2c: sh_mobile: rework deferred probing
Date: Wed, 17 Dec 2014 18:29:06 +0000 [thread overview]
Message-ID: <20141217182905.GD3981@katana> (raw)
In-Reply-To: <1418733086-26324-3-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Tue, Dec 16, 2014 at 01:31:26PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> DMA is opt-in for this driver. So, we can't use deferred probing for
> requesting DMA channels in probe, because our driver would get endlessly
> deferred if DMA support is compiled in AND the DMA driver is missing.
> Because we can't know when the DMA driver might show up, we always try
> again when a DMA transfer would be possible. The downside is that there
> is more overhead for setting up PIO transfers under the above scenario.
> But well, having DMA enabled and the proper DMA driver missing looks
> like a broken or test config anyhow.
>
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-17 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 12:31 [PATCH 0/2] i2c: sh_mobile: handle deferred probe properly when requesting DMA channels Wolfram Sang
2014-12-16 12:31 ` Wolfram Sang
[not found] ` <1418733086-26324-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-12-16 12:31 ` [PATCH 1/2] i2c: sh_mobile: refactor DMA setup Wolfram Sang
2014-12-16 12:31 ` Wolfram Sang
2014-12-17 18:28 ` Wolfram Sang
2014-12-17 18:28 ` Wolfram Sang
2014-12-16 12:31 ` [PATCH 2/2] i2c: sh_mobile: rework deferred probing Wolfram Sang
2014-12-16 12:31 ` Wolfram Sang
2014-12-17 18:29 ` Wolfram Sang [this message]
2014-12-17 18:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217182905.GD3981@katana \
--to=wsa@the-dreams.de \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.