* [PATCH] at86rf230: fix register read for part version
@ 2014-12-17 21:14 Andrey Yurovsky
2014-12-17 21:20 ` Alexander Aring
2014-12-18 23:20 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Andrey Yurovsky @ 2014-12-17 21:14 UTC (permalink / raw)
To: linux-wpan; +Cc: Andrey Yurovsky, alex.aring
The driver was reading the PART_NUM register for both the part number
(type of device) and the part version, the version is actually in
register 0x1D, VERSION_NUM. I believe that this was a copy-paste error.
Tested on AT86RF212B where the part is detected to be the expected part
number (0x07) and version (0x03 on mine).
Signed-off-by: Andrey Yurovsky <andrey@snupi.com>
---
drivers/net/ieee802154/at86rf230.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 1c01356..aa1005f 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1400,7 +1400,7 @@ at86rf230_detect_device(struct at86rf230_local *lp)
if (rc)
return rc;
- rc = __at86rf230_read(lp, RG_PART_NUM, &version);
+ rc = __at86rf230_read(lp, RG_VERSION_NUM, &version);
if (rc)
return rc;
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] at86rf230: fix register read for part version
2014-12-17 21:14 [PATCH] at86rf230: fix register read for part version Andrey Yurovsky
@ 2014-12-17 21:20 ` Alexander Aring
2014-12-18 23:20 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Aring @ 2014-12-17 21:20 UTC (permalink / raw)
To: Andrey Yurovsky; +Cc: linux-wpan
Hi Andrey,
On Wed, Dec 17, 2014 at 01:14:42PM -0800, Andrey Yurovsky wrote:
> The driver was reading the PART_NUM register for both the part number
> (type of device) and the part version, the version is actually in
> register 0x1D, VERSION_NUM. I believe that this was a copy-paste error.
>
> Tested on AT86RF212B where the part is detected to be the expected part
> number (0x07) and version (0x03 on mine).
>
> Signed-off-by: Andrey Yurovsky <andrey@snupi.com>
> ---
> drivers/net/ieee802154/at86rf230.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
> index 1c01356..aa1005f 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
> @@ -1400,7 +1400,7 @@ at86rf230_detect_device(struct at86rf230_local *lp)
> if (rc)
> return rc;
>
> - rc = __at86rf230_read(lp, RG_PART_NUM, &version);
> + rc = __at86rf230_read(lp, RG_VERSION_NUM, &version);
oops, yes this is indeed wrong here. Thanks!
Acked-by: Alexander Aring <alex.aring@gmail.com>
- Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] at86rf230: fix register read for part version
2014-12-17 21:14 [PATCH] at86rf230: fix register read for part version Andrey Yurovsky
2014-12-17 21:20 ` Alexander Aring
@ 2014-12-18 23:20 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2014-12-18 23:20 UTC (permalink / raw)
To: Andrey Yurovsky; +Cc: linux-wpan, alex.aring
Hi Andrey,
> The driver was reading the PART_NUM register for both the part number
> (type of device) and the part version, the version is actually in
> register 0x1D, VERSION_NUM. I believe that this was a copy-paste error.
>
> Tested on AT86RF212B where the part is detected to be the expected part
> number (0x07) and version (0x03 on mine).
>
> Signed-off-by: Andrey Yurovsky <andrey@snupi.com>
> ---
> drivers/net/ieee802154/at86rf230.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-18 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-17 21:14 [PATCH] at86rf230: fix register read for part version Andrey Yurovsky
2014-12-17 21:20 ` Alexander Aring
2014-12-18 23:20 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.