From: Pavel Machek <pavel@ucw.cz>
To: Oliver Neukum <oneukum@suse.de>
Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: bluetooth: Add hci_h4p driver
Date: Thu, 18 Dec 2014 21:10:43 +0100 [thread overview]
Message-ID: <20141218201043.GA15240@amd> (raw)
In-Reply-To: <20141218193153.GA27832@amd>
Hi!
On Thu 2014-12-18 20:31:53, Pavel Machek wrote:
> Hi!
>
> > > + h4p_simple_send_frame(info, skb);
> > > +
> > > + if (!wait_for_completion_interruptible_timeout(&info->init_completion,
> > > + msecs_to_jiffies(1000))) {
> > > + printk("h4p: negotiation did not return\n");
> >
> > Memory leak in the error case
>
> And memory leak in the normal case, too, no? Fixed.
Actually, no, h4p_simple_send_frame passes skb to network stack, and
it should free it as neccessary.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: bluetooth: Add hci_h4p driver
Date: Thu, 18 Dec 2014 21:10:43 +0100 [thread overview]
Message-ID: <20141218201043.GA15240@amd> (raw)
In-Reply-To: <20141218193153.GA27832@amd>
Hi!
On Thu 2014-12-18 20:31:53, Pavel Machek wrote:
> Hi!
>
> > > + h4p_simple_send_frame(info, skb);
> > > +
> > > + if (!wait_for_completion_interruptible_timeout(&info->init_completion,
> > > + msecs_to_jiffies(1000))) {
> > > + printk("h4p: negotiation did not return\n");
> >
> > Memory leak in the error case
>
> And memory leak in the normal case, too, no? Fixed.
Actually, no, h4p_simple_send_frame passes skb to network stack, and
it should free it as neccessary.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-12-18 20:10 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 22:37 bluetooth: Add hci_h4p driver Pavel Machek
2014-12-13 22:37 ` Pavel Machek
2014-12-13 23:30 ` Marcel Holtmann
2014-12-13 23:30 ` Marcel Holtmann
2014-12-13 23:51 ` Pavel Machek
2014-12-13 23:51 ` Pavel Machek
2014-12-14 0:07 ` Marcel Holtmann
2014-12-14 0:07 ` Marcel Holtmann
2014-12-14 9:47 ` Pavel Machek
2014-12-14 9:47 ` Pavel Machek
2014-12-14 10:40 ` Pavel Machek
2014-12-14 10:40 ` Pavel Machek
2014-12-14 10:40 ` Pavel Machek
2014-12-14 13:18 ` Bastien Nocera
2014-12-14 11:16 ` Pavel Machek
2014-12-14 11:16 ` Pavel Machek
2014-12-14 19:21 ` Pavel Machek
2014-12-14 19:21 ` Pavel Machek
2014-12-14 19:21 ` Pavel Machek
2014-12-14 20:28 ` Marcel Holtmann
2014-12-14 20:28 ` Marcel Holtmann
2014-12-14 22:41 ` Pavel Machek
2014-12-14 22:41 ` Pavel Machek
2014-12-14 22:41 ` Pavel Machek
2014-12-14 21:52 ` Pavel Machek
2014-12-14 21:52 ` Pavel Machek
2014-12-15 10:01 ` Oliver Neukum
2014-12-15 10:01 ` Oliver Neukum
2014-12-18 19:31 ` Pavel Machek
2014-12-18 19:31 ` Pavel Machek
2014-12-18 20:10 ` Pavel Machek [this message]
2014-12-18 20:10 ` Pavel Machek
2014-12-15 12:10 ` Marcel Holtmann
2014-12-15 12:10 ` Marcel Holtmann
2014-12-19 9:50 ` Pavel Machek
2014-12-19 9:50 ` Pavel Machek
2014-12-19 9:58 ` Marcel Holtmann
2014-12-19 9:58 ` Marcel Holtmann
2014-12-20 15:48 ` Pavel Machek
2014-12-20 15:48 ` Pavel Machek
2014-12-20 23:39 ` Marcel Holtmann
2014-12-20 23:39 ` Marcel Holtmann
2014-12-20 20:23 ` [PATCH] " Pavel Machek
2014-12-20 20:23 ` Pavel Machek
2014-12-20 20:23 ` Pavel Machek
2014-12-20 20:43 ` Paul Bolle
2014-12-20 20:43 ` Paul Bolle
2014-12-20 23:35 ` Marcel Holtmann
2014-12-20 23:35 ` Marcel Holtmann
2014-12-23 12:00 ` Pavel Machek
2014-12-23 12:00 ` Pavel Machek
2014-12-23 12:41 ` Pavel Machek
2014-12-23 12:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218201043.GA15240@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=oneukum@suse.de \
--cc=pali.rohar@gmail.com \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.