* [patch] scsi: gdth: fix bad integer overflow check
@ 2014-12-22 7:51 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-12-22 7:51 UTC (permalink / raw)
To: Achim Leubner; +Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
The integer overflow check was written incorrectly so it doesn't work.
Whoever wrote this clearly didn't know what they were doing. (I suck).
Fixes: f63ae56e4e97 ('[SCSI] gdth: integer overflow in ioctl')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 71e1380..0539147 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -4175,7 +4175,7 @@ static int ioc_general(void __user *arg, char *cmnd)
return -EINVAL;
if (gen.sense_len > INT_MAX)
return -EINVAL;
- if (gen.data_len + gen.sense_len > INT_MAX)
+ if (gen.data_len > INT_MAX - gen.sense_len)
return -EINVAL;
if (gen.data_len + gen.sense_len != 0) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] scsi: gdth: fix bad integer overflow check
@ 2014-12-22 7:51 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-12-22 7:51 UTC (permalink / raw)
To: Achim Leubner; +Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
The integer overflow check was written incorrectly so it doesn't work.
Whoever wrote this clearly didn't know what they were doing. (I suck).
Fixes: f63ae56e4e97 ('[SCSI] gdth: integer overflow in ioctl')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 71e1380..0539147 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -4175,7 +4175,7 @@ static int ioc_general(void __user *arg, char *cmnd)
return -EINVAL;
if (gen.sense_len > INT_MAX)
return -EINVAL;
- if (gen.data_len + gen.sense_len > INT_MAX)
+ if (gen.data_len > INT_MAX - gen.sense_len)
return -EINVAL;
if (gen.data_len + gen.sense_len != 0) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-22 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 7:51 [patch] scsi: gdth: fix bad integer overflow check Dan Carpenter
2014-12-22 7:51 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.