From: Felipe Balbi <balbi@ti.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dimitri Sivanich <sivanich@sgi.com>,
"Juergen E. Fischer" <fischer@norbit.de>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Felipe Balbi <balbi@ti.com>,
linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] cleanup on stack DECLARE_COMPLETIONs
Date: Tue, 23 Dec 2014 12:19:43 -0600 [thread overview]
Message-ID: <20141223181943.GE9147@saruman> (raw)
In-Reply-To: <1419356048-22405-1-git-send-email-der.herr@hofr.at>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On Tue, Dec 23, 2014 at 06:34:08PM +0100, Nicholas Mc Guire wrote:
> fixups for incorrect use of DECLARE_COMPLETION. see also commit
> 6e9a4738 ("completions: lockdep annotate on stack completions")
> The only somewhat special case being
> drivers/misc/sgi-gru/grukservices.c:quicktest2
> which had a static qualifier in the original DECLARE_COMPLETION()
> but that seems to be wrong (why should the completion persisted between
> successive calls ?) so the conversion to DECLARE_COMPLETION_ONSTACK
> was also applied and the static qualifier removed.
>
> Not sure if this is suitable in this form or if it should go out as
> 5 seperate patches ?
>
> This was only code reviewed and compile tested
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
please split drivers/usb/gadget out of this patch so I can take it
through my tree.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Dimitri Sivanich <sivanich@sgi.com>,
linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
Felipe Balbi <balbi@ti.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
"Juergen E. Fischer" <fischer@norbit.de>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] cleanup on stack DECLARE_COMPLETIONs
Date: Tue, 23 Dec 2014 12:19:43 -0600 [thread overview]
Message-ID: <20141223181943.GE9147@saruman> (raw)
In-Reply-To: <1419356048-22405-1-git-send-email-der.herr@hofr.at>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On Tue, Dec 23, 2014 at 06:34:08PM +0100, Nicholas Mc Guire wrote:
> fixups for incorrect use of DECLARE_COMPLETION. see also commit
> 6e9a4738 ("completions: lockdep annotate on stack completions")
> The only somewhat special case being
> drivers/misc/sgi-gru/grukservices.c:quicktest2
> which had a static qualifier in the original DECLARE_COMPLETION()
> but that seems to be wrong (why should the completion persisted between
> successive calls ?) so the conversion to DECLARE_COMPLETION_ONSTACK
> was also applied and the static qualifier removed.
>
> Not sure if this is suitable in this form or if it should go out as
> 5 seperate patches ?
>
> This was only code reviewed and compile tested
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
please split drivers/usb/gadget out of this patch so I can take it
through my tree.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-23 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 17:34 [PATCH] cleanup on stack DECLARE_COMPLETIONs Nicholas Mc Guire
2014-12-23 17:34 ` Nicholas Mc Guire
2014-12-23 18:19 ` Felipe Balbi [this message]
2014-12-23 18:19 ` Felipe Balbi
2014-12-29 15:38 ` Dimitri Sivanich
2014-12-29 15:38 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223181943.GE9147@saruman \
--to=balbi@ti.com \
--cc=JBottomley@parallels.com \
--cc=benh@kernel.crashing.org \
--cc=der.herr@hofr.at \
--cc=fischer@norbit.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.