* [PATCH] openvswitch: fix odd_ptr_err.cocci warnings @ 2014-12-24 6:41 ` kbuild test robot 0 siblings, 0 replies; 5+ messages in thread From: kbuild test robot @ 2014-12-24 6:41 UTC (permalink / raw) To: Pravin B Shelar; +Cc: kbuild-all, dev, netdev, linux-kernel net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- vport-gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/openvswitch/vport-gre.c +++ b/net/openvswitch/vport-gre.c @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp /* Push Tunnel header. */ skb = __build_header(skb, tunnel_hlen); if (IS_ERR(skb)) { - err = PTR_ERR(rt); + err = PTR_ERR(skb); skb = NULL; goto err_free_rt; } ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] openvswitch: fix odd_ptr_err.cocci warnings @ 2014-12-24 6:41 ` kbuild test robot 0 siblings, 0 replies; 5+ messages in thread From: kbuild test robot @ 2014-12-24 6:41 UTC (permalink / raw) To: Pravin B Shelar Cc: dev-yBygre7rU0TnMu66kgdUjQ, netdev-u79uwXL29TY76Z2rM5mHXA, kbuild-all-JC7UmRfGjtg, linux-kernel-u79uwXL29TY76Z2rM5mHXA net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- vport-gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/openvswitch/vport-gre.c +++ b/net/openvswitch/vport-gre.c @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp /* Push Tunnel header. */ skb = __build_header(skb, tunnel_hlen); if (IS_ERR(skb)) { - err = PTR_ERR(rt); + err = PTR_ERR(skb); skb = NULL; goto err_free_rt; } _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] openvswitch: fix odd_ptr_err.cocci warnings 2014-12-24 6:41 ` kbuild test robot @ 2014-12-24 18:49 ` Pravin Shelar -1 siblings, 0 replies; 5+ messages in thread From: Pravin Shelar @ 2014-12-24 18:49 UTC (permalink / raw) To: kbuild test robot; +Cc: kbuild-all, dev@openvswitch.org, netdev, LKML On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot <fengguang.wu@intel.com> wrote: > net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189 > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, where it is the call > IS_ERR that is wrong. > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Pravin B Shelar <pshelar@nicira.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Thanks for the fix. Acked-by: Pravin B Shelar <pshelar@nicira.com> > --- > > vport-gre.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/net/openvswitch/vport-gre.c > +++ b/net/openvswitch/vport-gre.c > @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp > /* Push Tunnel header. */ > skb = __build_header(skb, tunnel_hlen); > if (IS_ERR(skb)) { > - err = PTR_ERR(rt); > + err = PTR_ERR(skb); > skb = NULL; > goto err_free_rt; > } ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] openvswitch: fix odd_ptr_err.cocci warnings @ 2014-12-24 18:49 ` Pravin Shelar 0 siblings, 0 replies; 5+ messages in thread From: Pravin Shelar @ 2014-12-24 18:49 UTC (permalink / raw) To: kbuild test robot Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, netdev, kbuild-all-JC7UmRfGjtg, LKML On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot <fengguang.wu@intel.com> wrote: > net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189 > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, where it is the call > IS_ERR that is wrong. > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Pravin B Shelar <pshelar@nicira.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Thanks for the fix. Acked-by: Pravin B Shelar <pshelar@nicira.com> > --- > > vport-gre.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/net/openvswitch/vport-gre.c > +++ b/net/openvswitch/vport-gre.c > @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp > /* Push Tunnel header. */ > skb = __build_header(skb, tunnel_hlen); > if (IS_ERR(skb)) { > - err = PTR_ERR(rt); > + err = PTR_ERR(skb); > skb = NULL; > goto err_free_rt; > } _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] openvswitch: fix odd_ptr_err.cocci warnings 2014-12-24 18:49 ` Pravin Shelar (?) @ 2014-12-24 20:18 ` David Miller -1 siblings, 0 replies; 5+ messages in thread From: David Miller @ 2014-12-24 20:18 UTC (permalink / raw) To: pshelar; +Cc: fengguang.wu, kbuild-all, dev, netdev, linux-kernel From: Pravin Shelar <pshelar@nicira.com> Date: Wed, 24 Dec 2014 10:49:22 -0800 > On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot > <fengguang.wu@intel.com> wrote: >> net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189 >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Semantic patch information: >> There can be false positives in the patch case, where it is the call >> IS_ERR that is wrong. >> >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci >> >> CC: Pravin B Shelar <pshelar@nicira.com> >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Thanks for the fix. > > Acked-by: Pravin B Shelar <pshelar@nicira.com> Applied, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-24 20:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201412241437.BpaCtsIE%fengguang.wu@intel.com>
2014-12-24 6:41 ` [PATCH] openvswitch: fix odd_ptr_err.cocci warnings kbuild test robot
2014-12-24 6:41 ` kbuild test robot
2014-12-24 18:49 ` Pravin Shelar
2014-12-24 18:49 ` Pravin Shelar
2014-12-24 20:18 ` David Miller
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.