From: Vladimir Davydov <vdavydov@parallels.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: memcontrol: switch soft limit default back to infinity
Date: Mon, 29 Dec 2014 11:42:59 +0300 [thread overview]
Message-ID: <20141229084259.GA9984@esperanza> (raw)
In-Reply-To: <1419792468-9278-1-git-send-email-hannes@cmpxchg.org>
On Sun, Dec 28, 2014 at 01:47:48PM -0500, Johannes Weiner wrote:
> 3e32cb2e0a12 ("mm: memcontrol: lockless page counters") accidentally
> switched the soft limit default from infinity to zero, which turns all
> memcgs with even a single page into soft limit excessors and engages
> soft limit reclaim on all of them during global memory pressure. This
> makes global reclaim generally more aggressive, but also inverts the
> meaning of existing soft limit configurations where unset soft limits
> are usually more generous than set ones.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Overlooked that :-/
Acked-by: Vladimir Davydov <vdavydov@parallels.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@parallels.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>, Tejun Heo <tj@kernel.org>,
<linux-mm@kvack.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [patch] mm: memcontrol: switch soft limit default back to infinity
Date: Mon, 29 Dec 2014 11:42:59 +0300 [thread overview]
Message-ID: <20141229084259.GA9984@esperanza> (raw)
In-Reply-To: <1419792468-9278-1-git-send-email-hannes@cmpxchg.org>
On Sun, Dec 28, 2014 at 01:47:48PM -0500, Johannes Weiner wrote:
> 3e32cb2e0a12 ("mm: memcontrol: lockless page counters") accidentally
> switched the soft limit default from infinity to zero, which turns all
> memcgs with even a single page into soft limit excessors and engages
> soft limit reclaim on all of them during global memory pressure. This
> makes global reclaim generally more aggressive, but also inverts the
> meaning of existing soft limit configurations where unset soft limits
> are usually more generous than set ones.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Overlooked that :-/
Acked-by: Vladimir Davydov <vdavydov@parallels.com>
next prev parent reply other threads:[~2014-12-29 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 18:47 [patch] mm: memcontrol: switch soft limit default back to infinity Johannes Weiner
2014-12-28 18:47 ` Johannes Weiner
[not found] ` <1419792468-9278-1-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2014-12-29 8:22 ` Michal Hocko
2014-12-29 8:22 ` Michal Hocko
2014-12-29 8:22 ` Michal Hocko
2014-12-29 8:42 ` Vladimir Davydov [this message]
2014-12-29 8:42 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229084259.GA9984@esperanza \
--to=vdavydov@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.