From: Vladimir Davydov <vdavydov@parallels.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.cz>,
Greg Thelen <gthelen@google.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [RFC PATCH 2/2] memcg: add memory and swap knobs to the default cgroup hierarchy
Date: Mon, 29 Dec 2014 11:54:35 +0300 [thread overview]
Message-ID: <20141229085435.GC9984@esperanza> (raw)
In-Reply-To: <20141228203023.GB9385@phnom.home.cmpxchg.org>
On Sun, Dec 28, 2014 at 03:30:23PM -0500, Johannes Weiner wrote:
> As such, my proposals would be:
>
> memory.low: the expected lower end of the workload size
> memory.high: the expected upper end
> memory.max: the absolute OOM-enforced maximum size
> memory.current: the current size
>
> And then, in the same vein:
>
> swap.max
> swap.current
>
> These names are short, but they should be unambiguous and descriptive
> in their context, and users will have to consult the documentation on
> how to configure this stuff anyway.
To me, memory.max resembles memory.max_usage_in_bytes from the old
interface, which is confusing. However, if we forget about the old
interface, the new names look fine.
Thanks,
Vladimir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@parallels.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.cz>,
Greg Thelen <gthelen@google.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Subject: Re: [RFC PATCH 2/2] memcg: add memory and swap knobs to the default cgroup hierarchy
Date: Mon, 29 Dec 2014 11:54:35 +0300 [thread overview]
Message-ID: <20141229085435.GC9984@esperanza> (raw)
In-Reply-To: <20141228203023.GB9385@phnom.home.cmpxchg.org>
On Sun, Dec 28, 2014 at 03:30:23PM -0500, Johannes Weiner wrote:
> As such, my proposals would be:
>
> memory.low: the expected lower end of the workload size
> memory.high: the expected upper end
> memory.max: the absolute OOM-enforced maximum size
> memory.current: the current size
>
> And then, in the same vein:
>
> swap.max
> swap.current
>
> These names are short, but they should be unambiguous and descriptive
> in their context, and users will have to consult the documentation on
> how to configure this stuff anyway.
To me, memory.max resembles memory.max_usage_in_bytes from the old
interface, which is confusing. However, if we forget about the old
interface, the new names look fine.
Thanks,
Vladimir
next prev parent reply other threads:[~2014-12-29 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 16:19 [RFC PATCH 1/2] memcg: account swap instead of memory+swap Vladimir Davydov
2014-12-28 16:19 ` Vladimir Davydov
2014-12-28 16:19 ` [RFC PATCH 2/2] memcg: add memory and swap knobs to the default cgroup hierarchy Vladimir Davydov
2014-12-28 16:19 ` Vladimir Davydov
2014-12-28 20:30 ` Johannes Weiner
2014-12-28 20:30 ` Johannes Weiner
2014-12-29 8:54 ` Vladimir Davydov [this message]
2014-12-29 8:54 ` Vladimir Davydov
2014-12-28 19:00 ` [RFC PATCH 1/2] memcg: account swap instead of memory+swap Johannes Weiner
2014-12-28 19:00 ` Johannes Weiner
2014-12-29 8:47 ` Vladimir Davydov
2014-12-29 8:47 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229085435.GC9984@esperanza \
--to=vdavydov@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.