From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more)
Date: Mon, 5 Jan 2015 12:32:52 +0000 [thread overview]
Message-ID: <20150105123252.GB10116@arm.com> (raw)
In-Reply-To: <20150105013436.GA23350@thunk.org>
Hi Ted,
On Mon, Jan 05, 2015 at 01:34:36AM +0000, Theodore Ts'o wrote:
> On Sun, Jan 04, 2015 at 09:26:59PM +0000, Russell King - ARM Linux wrote:
> >
> > With the revert in place, we now have insanely small bogomips values
> > reported via /proc/cpuinfo when hardware timers are used. That needs
> > fixing.
>
> Why does it need to be fixed?
>
> It's clear that there are applications that are working OK with the
> existing value,
I'm not sure it is that clear -- the reported regression was on a processor
that doesn't use the timer-backed delay loop, so the bogomips value will
essentially be restored by reverting the patch.
The issue comes on newer CPUs, where there will now be a very small bogomips
value reported and (to my knowledge) nobody has yet tried running some
affected applications there to see if they can cope.
> and if you change it to fix it for some new applications, but it breaks
> for others, then have you considered defining a new interface (perhaps
> exported via sysfs) that exports a "sane" value and document that new
> applications shoud use the new interface.
>
> Or if the answer is that no one should be using the bogomips field at
> all, then just document *that*, and then leave it be, so that existing
> applications don't break.
It never hurts to document our assumptions or anticipated/preferred use-cases
but in this case I think bogomips is difficult enough to use on any
half-recent SoCs that most developers have either (a) found another way to
do what they want (perf counters, clock_gettime) or (b) stopped bothering to
guess the CPU frequency when it's not actually needed, so I don't *think*
that new applications are such an issue.
Cheers,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pavel Machek <pavel@ucw.cz>, Marc Zyngier <marc.zyngier@arm.com>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more)
Date: Mon, 5 Jan 2015 12:32:52 +0000 [thread overview]
Message-ID: <20150105123252.GB10116@arm.com> (raw)
In-Reply-To: <20150105013436.GA23350@thunk.org>
Hi Ted,
On Mon, Jan 05, 2015 at 01:34:36AM +0000, Theodore Ts'o wrote:
> On Sun, Jan 04, 2015 at 09:26:59PM +0000, Russell King - ARM Linux wrote:
> >
> > With the revert in place, we now have insanely small bogomips values
> > reported via /proc/cpuinfo when hardware timers are used. That needs
> > fixing.
>
> Why does it need to be fixed?
>
> It's clear that there are applications that are working OK with the
> existing value,
I'm not sure it is that clear -- the reported regression was on a processor
that doesn't use the timer-backed delay loop, so the bogomips value will
essentially be restored by reverting the patch.
The issue comes on newer CPUs, where there will now be a very small bogomips
value reported and (to my knowledge) nobody has yet tried running some
affected applications there to see if they can cope.
> and if you change it to fix it for some new applications, but it breaks
> for others, then have you considered defining a new interface (perhaps
> exported via sysfs) that exports a "sane" value and document that new
> applications shoud use the new interface.
>
> Or if the answer is that no one should be using the bogomips field at
> all, then just document *that*, and then leave it be, so that existing
> applications don't break.
It never hurts to document our assumptions or anticipated/preferred use-cases
but in this case I think bogomips is difficult enough to use on any
half-recent SoCs that most developers have either (a) found another way to
do what they want (perf counters, clock_gettime) or (b) stopped bothering to
guess the CPU frequency when it's not actually needed, so I don't *think*
that new applications are such an issue.
Cheers,
Will
next prev parent reply other threads:[~2015-01-05 12:32 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 19:01 [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more) Pavel Machek
2015-01-04 20:03 ` Nicolas Pitre
2015-01-04 20:10 ` Pavel Machek
2015-01-04 20:25 ` Nicolas Pitre
2015-01-04 20:37 ` Pavel Machek
2015-01-04 20:56 ` Nicolas Pitre
2015-01-04 21:02 ` Linus Torvalds
2015-01-04 21:20 ` Nicolas Pitre
2015-01-04 21:26 ` Russell King - ARM Linux
2015-01-04 21:40 ` Pavel Machek
2015-01-04 22:27 ` Aaro Koskinen
2015-01-05 1:34 ` Theodore Ts'o
2015-01-05 12:32 ` Will Deacon [this message]
2015-01-05 12:32 ` Will Deacon
2015-01-05 4:51 ` Nicolas Pitre
2015-01-05 12:11 ` Will Deacon
2015-01-05 12:11 ` Will Deacon
2015-01-05 15:34 ` Pavel Machek
2015-01-05 15:34 ` Pavel Machek
2015-01-05 16:24 ` Nicolas Pitre
2015-01-05 16:24 ` Nicolas Pitre
2015-01-06 4:09 ` Nicolas Pitre
2015-01-06 13:01 ` Arnd Bergmann
2015-01-06 20:50 ` Nicolas Pitre
2015-01-06 21:27 ` Nicolas Pitre
2015-01-06 21:37 ` Arnd Bergmann
2015-01-07 18:11 ` Catalin Marinas
2015-01-07 18:47 ` Linus Torvalds
2015-01-07 19:00 ` Nicolas Pitre
2015-01-07 19:36 ` Linus Torvalds
2015-01-07 20:34 ` Nicolas Pitre
2015-01-07 20:53 ` Russell King - ARM Linux
2015-01-07 21:15 ` Nicolas Pitre
2015-01-09 22:54 ` Steven Rostedt
2015-01-07 22:14 ` Catalin Marinas
2015-01-08 0:05 ` Linus Torvalds
2015-01-08 0:45 ` Nicolas Pitre
2015-01-08 0:57 ` Linus Torvalds
2015-01-08 4:56 ` Nicolas Pitre
2015-01-08 5:04 ` Linus Torvalds
2015-01-08 5:54 ` Nicolas Pitre
2015-01-08 10:39 ` Russell King - ARM Linux
2015-01-08 15:44 ` Vince Weaver
2015-01-08 16:19 ` Catalin Marinas
2015-01-08 16:34 ` Russell King - ARM Linux
2015-01-08 16:41 ` Catalin Marinas
2015-01-08 16:57 ` Russell King - ARM Linux
2015-01-08 17:01 ` Catalin Marinas
2015-01-08 17:39 ` Vince Weaver
2015-01-08 17:22 ` Vince Weaver
2015-01-08 22:46 ` Pavel Machek
2015-01-09 9:49 ` Catalin Marinas
2015-01-08 16:32 ` Russell King - ARM Linux
[not found] ` <CA+55aFwuO2g1S-bY96V28crMWj+dKXWANzbP28JQjBdTg0rV0w@mail.gmail.com>
2015-01-07 21:29 ` Nicolas Pitre
[not found] ` <CA+55aFyrNE9qqBR9Khbj=TuAnjA+UzUhNxFz==SqKuiG5q3uMQ@mail.gmail.com>
2015-01-07 22:42 ` Nicolas Pitre
2015-01-08 0:25 ` Linus Torvalds
2015-01-08 0:49 ` Linus Torvalds
2015-01-07 22:24 ` Catalin Marinas
2015-01-07 18:50 ` Nicolas Pitre
2015-01-08 22:49 ` Pavel Machek
2015-01-06 18:33 ` Will Deacon
2015-01-04 20:22 ` Linus Torvalds
2015-01-04 20:43 ` Russell King - ARM Linux
2015-01-04 20:52 ` Pavel Machek
2015-01-04 20:45 ` Nicolas Pitre
2015-01-04 20:57 ` Linus Torvalds
2015-01-04 21:15 ` Russell King - ARM Linux
2015-01-05 14:22 ` One Thousand Gnomes
2015-01-05 18:22 ` Catalin Marinas
2015-01-06 22:33 ` Linus Torvalds
2015-01-06 23:42 ` Catalin Marinas
2015-01-07 1:20 ` Linus Torvalds
2015-01-07 15:01 ` Catalin Marinas
2015-01-08 13:29 ` One Thousand Gnomes
2015-01-07 6:41 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105123252.GB10116@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.