All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, sre@kernel.org
Subject: Re: [PATCH V4] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
Date: Mon, 5 Jan 2015 11:27:18 -0600	[thread overview]
Message-ID: <20150105172718.GJ19336@saruman> (raw)
In-Reply-To: <1420475549-28492-1-git-send-email-nm@ti.com>

[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]

On Mon, Jan 05, 2015 at 10:32:29AM -0600, Nishanth Menon wrote:
> TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
> a fan (such as AFB02505HHB) over J1 connector for various purposes.
> Provide device tree node to enable the same.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

have already reviewed this one previously:

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
> V4: Change format of the speed-map used.
> V3: https://patchwork.kernel.org/patch/5562121/
> V2: https://patchwork.kernel.org/patch/5445111/
> V1: https://patchwork.kernel.org/patch/5444911/
> 
> Enable and disable can be controlled by (post the RPM, it finds
> closest match - even a 1 will do)
> 
> echo '13000' > /sys/class/hwmon/hwmon0/fan1_target
> and
> echo '0' > /sys/class/hwmon/hwmon0/fan1_target
> 
> Test log: http://slexy.org/view/s2T0ajh46z
> 
> requires CONFIG_GPIO_PALMAS and CONFIG_SENSORS_GPIO_FAN to be operational
> Applies on v3.19-rc1
> 
>  arch/arm/boot/dts/am57xx-beagle-x15.dts |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index 6c2e8e4..c5d4cea 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -80,6 +80,14 @@
>  			default-state = "off";
>  		};
>  	};
> +
> +	gpio_fan: gpio_fan {
> +		/* Based on 5v 500mA AFB02505HHB */
> +		compatible = "gpio-fan";
> +		gpios =  <&tps659038_gpio 1 GPIO_ACTIVE_HIGH>;
> +		gpio-fan,speed-map = <0     0>,
> +				     <13000 1>;
> +	};
>  };
>  
>  &dra7_pmx_core {
> @@ -394,6 +402,12 @@
>  			wakeup-source;
>  			ti,palmas-long-press-seconds = <12>;
>  		};
> +
> +		tps659038_gpio: tps659038_gpio {
> +			compatible = "ti,palmas-gpio";
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +		};
>  	};
>  
>  	tmp102: tmp102@48 {
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
Date: Mon, 5 Jan 2015 11:27:18 -0600	[thread overview]
Message-ID: <20150105172718.GJ19336@saruman> (raw)
In-Reply-To: <1420475549-28492-1-git-send-email-nm@ti.com>

On Mon, Jan 05, 2015 at 10:32:29AM -0600, Nishanth Menon wrote:
> TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
> a fan (such as AFB02505HHB) over J1 connector for various purposes.
> Provide device tree node to enable the same.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

have already reviewed this one previously:

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
> V4: Change format of the speed-map used.
> V3: https://patchwork.kernel.org/patch/5562121/
> V2: https://patchwork.kernel.org/patch/5445111/
> V1: https://patchwork.kernel.org/patch/5444911/
> 
> Enable and disable can be controlled by (post the RPM, it finds
> closest match - even a 1 will do)
> 
> echo '13000' > /sys/class/hwmon/hwmon0/fan1_target
> and
> echo '0' > /sys/class/hwmon/hwmon0/fan1_target
> 
> Test log: http://slexy.org/view/s2T0ajh46z
> 
> requires CONFIG_GPIO_PALMAS and CONFIG_SENSORS_GPIO_FAN to be operational
> Applies on v3.19-rc1
> 
>  arch/arm/boot/dts/am57xx-beagle-x15.dts |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index 6c2e8e4..c5d4cea 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -80,6 +80,14 @@
>  			default-state = "off";
>  		};
>  	};
> +
> +	gpio_fan: gpio_fan {
> +		/* Based on 5v 500mA AFB02505HHB */
> +		compatible = "gpio-fan";
> +		gpios =  <&tps659038_gpio 1 GPIO_ACTIVE_HIGH>;
> +		gpio-fan,speed-map = <0     0>,
> +				     <13000 1>;
> +	};
>  };
>  
>  &dra7_pmx_core {
> @@ -394,6 +402,12 @@
>  			wakeup-source;
>  			ti,palmas-long-press-seconds = <12>;
>  		};
> +
> +		tps659038_gpio: tps659038_gpio {
> +			compatible = "ti,palmas-gpio";
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +		};
>  	};
>  
>  	tmp102: tmp102 at 48 {
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150105/c8a96ffe/attachment.sig>

  reply	other threads:[~2015-01-05 17:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 16:32 [PATCH V4] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node Nishanth Menon
2015-01-05 16:32 ` Nishanth Menon
2015-01-05 17:27 ` Felipe Balbi [this message]
2015-01-05 17:27   ` Felipe Balbi
2015-01-08  0:20   ` Tony Lindgren
2015-01-08  0:20     ` Tony Lindgren
2015-01-05 17:27 ` Felipe Balbi
2015-01-05 17:27   ` Felipe Balbi
2015-01-05 17:33   ` Nishanth Menon
2015-01-05 17:33     ` Nishanth Menon
2015-01-05 17:45     ` Felipe Balbi
2015-01-05 17:45       ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105172718.GJ19336@saruman \
    --to=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.