* [PATCH 3.19 REGRESSION FIX] ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias
@ 2014-12-25 12:25 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2014-12-25 12:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Maxime, ChenYu,
The Ippo q8h has its serial console connected to the r-uart. Adjust the
serial0 alias to match.
This fixes the kernel serial console no longer working since 3.19-rc1, because
8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather
then being ttyS0, as it was in 3.18 and before.
Note that adjusting bootargs instead is not an acceptable fix, because
console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should
continue to work.
Maxime, can you please queue this up as a fix for 3.19 ?
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.19 REGRESSION FIX] ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias
@ 2014-12-25 12:25 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2014-12-25 12:25 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
Hi Maxime, ChenYu,
The Ippo q8h has its serial console connected to the r-uart. Adjust the
serial0 alias to match.
This fixes the kernel serial console no longer working since 3.19-rc1, because
8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather
then being ttyS0, as it was in 3.18 and before.
Note that adjusting bootargs instead is not an acceptable fix, because
console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should
continue to work.
Maxime, can you please queue this up as a fix for 3.19 ?
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias
@ 2014-12-25 12:25 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2014-12-25 12:25 UTC (permalink / raw)
To: linux-arm-kernel
The Ippo q8h has its serial console connected to the r-uart. Adjust the
serial0 alias to match.
This fixes the kernel serial console no longer working since 3.19-rc1, because
8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather
then being ttyS0, as it was in 3.18 and before.
Note that adjusting bootargs instead is not an acceptable fix, because
console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should
continue to work.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts b/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts
index 7f2117c..32ad808 100644
--- a/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts
+++ b/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts
@@ -55,6 +55,10 @@
model = "Ippo Q8H Dual Core Tablet (v5)";
compatible = "ippo,q8h-v5", "allwinner,sun8i-a23";
+ aliases {
+ serial0 = &r_uart;
+ };
+
chosen {
bootargs = "earlyprintk console=ttyS0,115200";
};
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias
@ 2014-12-25 12:25 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2014-12-25 12:25 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Hans de Goede
The Ippo q8h has its serial console connected to the r-uart. Adjust the
serial0 alias to match.
This fixes the kernel serial console no longer working since 3.19-rc1, because
8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather
then being ttyS0, as it was in 3.18 and before.
Note that adjusting bootargs instead is not an acceptable fix, because
console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should
continue to work.
Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts b/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts
index 7f2117c..32ad808 100644
--- a/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts
+++ b/arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts
@@ -55,6 +55,10 @@
model = "Ippo Q8H Dual Core Tablet (v5)";
compatible = "ippo,q8h-v5", "allwinner,sun8i-a23";
+ aliases {
+ serial0 = &r_uart;
+ };
+
chosen {
bootargs = "earlyprintk console=ttyS0,115200";
};
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias
@ 2015-01-06 9:54 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2015-01-06 9:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 25, 2014 at 01:25:19PM +0100, Hans de Goede wrote:
> The Ippo q8h has its serial console connected to the r-uart. Adjust the
> serial0 alias to match.
>
> This fixes the kernel serial console no longer working since 3.19-rc1, because
> 8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather
> then being ttyS0, as it was in 3.18 and before.
>
> Note that adjusting bootargs instead is not an acceptable fix, because
> console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should
> continue to work.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150106/5f4fad5a/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias
@ 2015-01-06 9:54 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2015-01-06 9:54 UTC (permalink / raw)
To: Hans de Goede
Cc: Chen-Yu Tsai, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Thu, Dec 25, 2014 at 01:25:19PM +0100, Hans de Goede wrote:
> The Ippo q8h has its serial console connected to the r-uart. Adjust the
> serial0 alias to match.
>
> This fixes the kernel serial console no longer working since 3.19-rc1, because
> 8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather
> then being ttyS0, as it was in 3.18 and before.
>
> Note that adjusting bootargs instead is not an acceptable fix, because
> console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should
> continue to work.
>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-06 9:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-25 12:25 [PATCH 3.19 REGRESSION FIX] ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias Hans de Goede
2014-12-25 12:25 ` Hans de Goede
2014-12-25 12:25 ` [PATCH] " Hans de Goede
2014-12-25 12:25 ` Hans de Goede
2015-01-06 9:54 ` Maxime Ripard
2015-01-06 9:54 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.