* [PATCH 0/2] thermal: rcar: minor fixes @ 2015-01-06 10:02 ` Yoshihiro Shimoda 0 siblings, 0 replies; 16+ messages in thread From: Yoshihiro Shimoda @ 2015-01-06 10:02 UTC (permalink / raw) To: rui.zhang, edubezval; +Cc: linux-pm, linux-sh, Yoshihiro Shimoda This patch series is based on linux-soc-thermal.git / fixes branch. (commit id = 5a723e81923410f0d3ae4c38974607b13befdda9) Yoshihiro Shimoda (2): thermal: rcar: fix ENR register value thermal: rcar: change type of ctemp in rcar_thermal_update_temp() drivers/thermal/rcar_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/2] thermal: rcar: minor fixes @ 2015-01-06 10:02 ` Yoshihiro Shimoda 0 siblings, 0 replies; 16+ messages in thread From: Yoshihiro Shimoda @ 2015-01-06 10:02 UTC (permalink / raw) To: rui.zhang, edubezval; +Cc: linux-pm, linux-sh, Yoshihiro Shimoda This patch series is based on linux-soc-thermal.git / fixes branch. (commit id = 5a723e81923410f0d3ae4c38974607b13befdda9) Yoshihiro Shimoda (2): thermal: rcar: fix ENR register value thermal: rcar: change type of ctemp in rcar_thermal_update_temp() drivers/thermal/rcar_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] thermal: rcar: fix ENR register value 2015-01-06 10:02 ` Yoshihiro Shimoda @ 2015-01-06 10:02 ` Yoshihiro Shimoda -1 siblings, 0 replies; 16+ messages in thread From: Yoshihiro Shimoda @ 2015-01-06 10:02 UTC (permalink / raw) To: rui.zhang, edubezval; +Cc: linux-pm, linux-sh, Yoshihiro Shimoda Since the write value should always be 0 for bit 31-4 of ENR register on R-Car H2, this patch fixes the value. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/thermal/rcar_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index 8803e69..bbdf64e 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -409,7 +409,7 @@ static int rcar_thermal_probe(struct platform_device *pdev) return PTR_ERR(common->base); /* enable temperature comparation */ - rcar_thermal_common_write(common, ENR, 0x00030303); + rcar_thermal_common_write(common, ENR, 0x00000003); idle = 0; /* polling delay is not needed */ } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 1/2] thermal: rcar: fix ENR register value @ 2015-01-06 10:02 ` Yoshihiro Shimoda 0 siblings, 0 replies; 16+ messages in thread From: Yoshihiro Shimoda @ 2015-01-06 10:02 UTC (permalink / raw) To: rui.zhang, edubezval; +Cc: linux-pm, linux-sh, Yoshihiro Shimoda Since the write value should always be 0 for bit 31-4 of ENR register on R-Car H2, this patch fixes the value. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/thermal/rcar_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index 8803e69..bbdf64e 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -409,7 +409,7 @@ static int rcar_thermal_probe(struct platform_device *pdev) return PTR_ERR(common->base); /* enable temperature comparation */ - rcar_thermal_common_write(common, ENR, 0x00030303); + rcar_thermal_common_write(common, ENR, 0x00000003); idle = 0; /* polling delay is not needed */ } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] thermal: rcar: fix ENR register value 2015-01-06 10:02 ` Yoshihiro Shimoda @ 2015-01-06 10:53 ` Geert Uytterhoeven -1 siblings, 0 replies; 16+ messages in thread From: Geert Uytterhoeven @ 2015-01-06 10:53 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Zhang Rui, Eduardo Valentin, Linux PM list, Linux-sh list Hi Shimoda-san, On Tue, Jan 6, 2015 at 11:02 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Since the write value should always be 0 for bit 31-4 of ENR register > on R-Car H2, this patch fixes the value. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/thermal/rcar_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index 8803e69..bbdf64e 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -409,7 +409,7 @@ static int rcar_thermal_probe(struct platform_device *pdev) > return PTR_ERR(common->base); > > /* enable temperature comparation */ > - rcar_thermal_common_write(common, ENR, 0x00030303); > + rcar_thermal_common_write(common, ENR, 0x00000003); While your patch is correct for R-Car gen2, this driver is also used on R-Mobile APE6 (r8a73a4), which does have 3 thermal zones. So I think you should count the other I/O resource sets to calculate the correct mask. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] thermal: rcar: fix ENR register value @ 2015-01-06 10:53 ` Geert Uytterhoeven 0 siblings, 0 replies; 16+ messages in thread From: Geert Uytterhoeven @ 2015-01-06 10:53 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Zhang Rui, Eduardo Valentin, Linux PM list, Linux-sh list Hi Shimoda-san, On Tue, Jan 6, 2015 at 11:02 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Since the write value should always be 0 for bit 31-4 of ENR register > on R-Car H2, this patch fixes the value. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/thermal/rcar_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index 8803e69..bbdf64e 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -409,7 +409,7 @@ static int rcar_thermal_probe(struct platform_device *pdev) > return PTR_ERR(common->base); > > /* enable temperature comparation */ > - rcar_thermal_common_write(common, ENR, 0x00030303); > + rcar_thermal_common_write(common, ENR, 0x00000003); While your patch is correct for R-Car gen2, this driver is also used on R-Mobile APE6 (r8a73a4), which does have 3 thermal zones. So I think you should count the other I/O resource sets to calculate the correct mask. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH 1/2] thermal: rcar: fix ENR register value 2015-01-06 10:53 ` Geert Uytterhoeven @ 2015-01-06 11:13 ` yoshihiro shimoda -1 siblings, 0 replies; 16+ messages in thread From: yoshihiro shimoda @ 2015-01-06 11:13 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Zhang Rui, Eduardo Valentin, Linux PM list, Linux-sh list Hi Geert-san, > Hi Shimoda-san, > > On Tue, Jan 6, 2015 at 11:02 AM, Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Since the write value should always be 0 for bit 31-4 of ENR register > > on R-Car H2, this patch fixes the value. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > drivers/thermal/rcar_thermal.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > > index 8803e69..bbdf64e 100644 > > --- a/drivers/thermal/rcar_thermal.c > > +++ b/drivers/thermal/rcar_thermal.c > > @@ -409,7 +409,7 @@ static int rcar_thermal_probe(struct platform_device *pdev) > > return PTR_ERR(common->base); > > > > /* enable temperature comparation */ > > - rcar_thermal_common_write(common, ENR, 0x00030303); > > + rcar_thermal_common_write(common, ENR, 0x00000003); > > While your patch is correct for R-Car gen2, this driver is also used on > R-Mobile APE6 (r8a73a4), which does have 3 thermal zones. > So I think you should count the other I/O resource sets to calculate > the correct mask. Thank you for the review and suggestion! As you say, I didn't care about R-Mobile APE6. So, I will modify this code tomorrow. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH 1/2] thermal: rcar: fix ENR register value @ 2015-01-06 11:13 ` yoshihiro shimoda 0 siblings, 0 replies; 16+ messages in thread From: yoshihiro shimoda @ 2015-01-06 11:13 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Zhang Rui, Eduardo Valentin, Linux PM list, Linux-sh list SGkgR2VlcnQtc2FuLA0KDQo+IEhpIFNoaW1vZGEtc2FuLA0KPiANCj4gT24gVHVlLCBKYW4gNiwg MjAxNSBhdCAxMTowMiBBTSwgWW9zaGloaXJvIFNoaW1vZGENCj4gPHlvc2hpaGlyby5zaGltb2Rh LnVoQHJlbmVzYXMuY29tPiB3cm90ZToNCj4gPiBTaW5jZSB0aGUgd3JpdGUgdmFsdWUgc2hvdWxk IGFsd2F5cyBiZSAwIGZvciBiaXQgMzEtNCBvZiBFTlIgcmVnaXN0ZXINCj4gPiBvbiBSLUNhciBI MiwgdGhpcyBwYXRjaCBmaXhlcyB0aGUgdmFsdWUuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBZ b3NoaWhpcm8gU2hpbW9kYSA8eW9zaGloaXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQo+ID4g LS0tDQo+ID4gIGRyaXZlcnMvdGhlcm1hbC9yY2FyX3RoZXJtYWwuYyB8ICAgIDIgKy0NCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4NCj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy90aGVybWFsL3JjYXJfdGhlcm1hbC5jIGIvZHJpdmVycy90aGVy bWFsL3JjYXJfdGhlcm1hbC5jDQo+ID4gaW5kZXggODgwM2U2OS4uYmJkZjY0ZSAxMDA2NDQNCj4g PiAtLS0gYS9kcml2ZXJzL3RoZXJtYWwvcmNhcl90aGVybWFsLmMNCj4gPiArKysgYi9kcml2ZXJz L3RoZXJtYWwvcmNhcl90aGVybWFsLmMNCj4gPiBAQCAtNDA5LDcgKzQwOSw3IEBAIHN0YXRpYyBp bnQgcmNhcl90aGVybWFsX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4g ICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIoY29tbW9uLT5iYXNlKTsNCj4g Pg0KPiA+ICAgICAgICAgICAgICAgICAvKiBlbmFibGUgdGVtcGVyYXR1cmUgY29tcGFyYXRpb24g Ki8NCj4gPiAtICAgICAgICAgICAgICAgcmNhcl90aGVybWFsX2NvbW1vbl93cml0ZShjb21tb24s IEVOUiwgMHgwMDAzMDMwMyk7DQo+ID4gKyAgICAgICAgICAgICAgIHJjYXJfdGhlcm1hbF9jb21t b25fd3JpdGUoY29tbW9uLCBFTlIsIDB4MDAwMDAwMDMpOw0KPiANCj4gV2hpbGUgeW91ciBwYXRj aCBpcyBjb3JyZWN0IGZvciBSLUNhciBnZW4yLCB0aGlzIGRyaXZlciBpcyBhbHNvIHVzZWQgb24N Cj4gUi1Nb2JpbGUgQVBFNiAocjhhNzNhNCksIHdoaWNoIGRvZXMgaGF2ZSAzIHRoZXJtYWwgem9u ZXMuDQo+IFNvIEkgdGhpbmsgeW91IHNob3VsZCBjb3VudCB0aGUgb3RoZXIgSS9PIHJlc291cmNl IHNldHMgdG8gY2FsY3VsYXRlDQo+IHRoZSBjb3JyZWN0IG1hc2suDQoNClRoYW5rIHlvdSBmb3Ig dGhlIHJldmlldyBhbmQgc3VnZ2VzdGlvbiENCkFzIHlvdSBzYXksIEkgZGlkbid0IGNhcmUgYWJv dXQgUi1Nb2JpbGUgQVBFNi4NClNvLCBJIHdpbGwgbW9kaWZ5IHRoaXMgY29kZSB0b21vcnJvdy4N Cg0KQmVzdCByZWdhcmRzLA0KWW9zaGloaXJvIFNoaW1vZGENCg0KPiBHcntvZXRqZSxlZXRpbmd9 cywNCj4gDQo+ICAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0DQo+IA0KPiAtLQ0KPiBHZWVy dCBVeXR0ZXJob2V2ZW4gLS0gVGhlcmUncyBsb3RzIG9mIExpbnV4IGJleW9uZCBpYTMyIC0tIGdl ZXJ0QGxpbnV4LW02OGsub3JnDQo+IA0KPiBJbiBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGgg dGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15c2VsZiBhIGhhY2tlci4gQnV0DQo+IHdoZW4gSSdt IHRhbGtpbmcgdG8gam91cm5hbGlzdHMgSSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Igc29tZXRo aW5nIGxpa2UgdGhhdC4NCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51 cyBUb3J2YWxkcw0K ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() 2015-01-06 10:02 ` Yoshihiro Shimoda @ 2015-01-06 10:02 ` Yoshihiro Shimoda -1 siblings, 0 replies; 16+ messages in thread From: Yoshihiro Shimoda @ 2015-01-06 10:02 UTC (permalink / raw) To: rui.zhang, edubezval; +Cc: linux-pm, linux-sh, Yoshihiro Shimoda Since the ctemp is used for rcar_thermal_write() in rcar_thermal_update_temp(), the type of ctemp should be "u32" instead of "int". Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/thermal/rcar_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index bbdf64e..6dcead1 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -63,7 +63,7 @@ struct rcar_thermal_priv { struct mutex lock; struct list_head list; int id; - int ctemp; + u32 ctemp; }; #define rcar_thermal_for_each_priv(pos, common) \ @@ -145,7 +145,7 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv) { struct device *dev = rcar_priv_to_dev(priv); int i; - int ctemp, old, new; + u32 ctemp, old, new; int ret = -EINVAL; mutex_lock(&priv->lock); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() @ 2015-01-06 10:02 ` Yoshihiro Shimoda 0 siblings, 0 replies; 16+ messages in thread From: Yoshihiro Shimoda @ 2015-01-06 10:02 UTC (permalink / raw) To: rui.zhang, edubezval; +Cc: linux-pm, linux-sh, Yoshihiro Shimoda Since the ctemp is used for rcar_thermal_write() in rcar_thermal_update_temp(), the type of ctemp should be "u32" instead of "int". Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/thermal/rcar_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index bbdf64e..6dcead1 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -63,7 +63,7 @@ struct rcar_thermal_priv { struct mutex lock; struct list_head list; int id; - int ctemp; + u32 ctemp; }; #define rcar_thermal_for_each_priv(pos, common) \ @@ -145,7 +145,7 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv) { struct device *dev = rcar_priv_to_dev(priv); int i; - int ctemp, old, new; + u32 ctemp, old, new; int ret = -EINVAL; mutex_lock(&priv->lock); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() 2015-01-06 10:02 ` Yoshihiro Shimoda @ 2015-01-06 10:55 ` Geert Uytterhoeven -1 siblings, 0 replies; 16+ messages in thread From: Geert Uytterhoeven @ 2015-01-06 10:55 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Zhang Rui, Eduardo Valentin, Linux PM list, Linux-sh list On Tue, Jan 6, 2015 at 11:02 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Since the ctemp is used for rcar_thermal_write() in > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > of "int". > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() @ 2015-01-06 10:55 ` Geert Uytterhoeven 0 siblings, 0 replies; 16+ messages in thread From: Geert Uytterhoeven @ 2015-01-06 10:55 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Zhang Rui, Eduardo Valentin, Linux PM list, Linux-sh list On Tue, Jan 6, 2015 at 11:02 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Since the ctemp is used for rcar_thermal_write() in > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > of "int". > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() 2015-01-06 10:02 ` Yoshihiro Shimoda @ 2015-01-06 13:03 ` Eduardo Valentin -1 siblings, 0 replies; 16+ messages in thread From: Eduardo Valentin @ 2015-01-06 13:03 UTC (permalink / raw) To: Yoshihiro Shimoda; +Cc: rui.zhang, linux-pm, linux-sh [-- Attachment #1: Type: text/plain, Size: 1347 bytes --] Shimoda-san, On Tue, Jan 06, 2015 at 07:02:08PM +0900, Yoshihiro Shimoda wrote: > Since the ctemp is used for rcar_thermal_write() in > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > of "int". In your V2, can you please include in your description that you are also updating the helper variables 'old' and 'new'? The description does not mention it. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/thermal/rcar_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index bbdf64e..6dcead1 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -63,7 +63,7 @@ struct rcar_thermal_priv { > struct mutex lock; > struct list_head list; > int id; > - int ctemp; > + u32 ctemp; > }; > > #define rcar_thermal_for_each_priv(pos, common) \ > @@ -145,7 +145,7 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv) > { > struct device *dev = rcar_priv_to_dev(priv); > int i; > - int ctemp, old, new; > + u32 ctemp, old, new; But you also update them, as necessary. > int ret = -EINVAL; > > mutex_lock(&priv->lock); > -- > 1.7.9.5 > BR, Eduardo Valentin [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() @ 2015-01-06 13:03 ` Eduardo Valentin 0 siblings, 0 replies; 16+ messages in thread From: Eduardo Valentin @ 2015-01-06 13:03 UTC (permalink / raw) To: Yoshihiro Shimoda; +Cc: rui.zhang, linux-pm, linux-sh [-- Attachment #1: Type: text/plain, Size: 1347 bytes --] Shimoda-san, On Tue, Jan 06, 2015 at 07:02:08PM +0900, Yoshihiro Shimoda wrote: > Since the ctemp is used for rcar_thermal_write() in > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > of "int". In your V2, can you please include in your description that you are also updating the helper variables 'old' and 'new'? The description does not mention it. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/thermal/rcar_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index bbdf64e..6dcead1 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -63,7 +63,7 @@ struct rcar_thermal_priv { > struct mutex lock; > struct list_head list; > int id; > - int ctemp; > + u32 ctemp; > }; > > #define rcar_thermal_for_each_priv(pos, common) \ > @@ -145,7 +145,7 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv) > { > struct device *dev = rcar_priv_to_dev(priv); > int i; > - int ctemp, old, new; > + u32 ctemp, old, new; But you also update them, as necessary. > int ret = -EINVAL; > > mutex_lock(&priv->lock); > -- > 1.7.9.5 > BR, Eduardo Valentin [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() 2015-01-06 13:03 ` Eduardo Valentin @ 2015-01-07 0:26 ` yoshihiro shimoda -1 siblings, 0 replies; 16+ messages in thread From: yoshihiro shimoda @ 2015-01-07 0:26 UTC (permalink / raw) To: Eduardo Valentin Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-sh@vger.kernel.org Hi Eduardo-san, > Shimoda-san, > > On Tue, Jan 06, 2015 at 07:02:08PM +0900, Yoshihiro Shimoda wrote: > > Since the ctemp is used for rcar_thermal_write() in > > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > > of "int". > > In your V2, can you please include in your description that you are also > updating the helper variables 'old' and 'new'? > > The description does not mention it. Thank you for the point. I will fix this description in v2 patch set. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() @ 2015-01-07 0:26 ` yoshihiro shimoda 0 siblings, 0 replies; 16+ messages in thread From: yoshihiro shimoda @ 2015-01-07 0:26 UTC (permalink / raw) To: Eduardo Valentin Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-sh@vger.kernel.org Hi Eduardo-san, > Shimoda-san, > > On Tue, Jan 06, 2015 at 07:02:08PM +0900, Yoshihiro Shimoda wrote: > > Since the ctemp is used for rcar_thermal_write() in > > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > > of "int". > > In your V2, can you please include in your description that you are also > updating the helper variables 'old' and 'new'? > > The description does not mention it. Thank you for the point. I will fix this description in v2 patch set. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2015-01-07 0:26 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-06 10:02 [PATCH 0/2] thermal: rcar: minor fixes Yoshihiro Shimoda 2015-01-06 10:02 ` Yoshihiro Shimoda 2015-01-06 10:02 ` [PATCH 1/2] thermal: rcar: fix ENR register value Yoshihiro Shimoda 2015-01-06 10:02 ` Yoshihiro Shimoda 2015-01-06 10:53 ` Geert Uytterhoeven 2015-01-06 10:53 ` Geert Uytterhoeven 2015-01-06 11:13 ` yoshihiro shimoda 2015-01-06 11:13 ` yoshihiro shimoda 2015-01-06 10:02 ` [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp() Yoshihiro Shimoda 2015-01-06 10:02 ` Yoshihiro Shimoda 2015-01-06 10:55 ` Geert Uytterhoeven 2015-01-06 10:55 ` Geert Uytterhoeven 2015-01-06 13:03 ` Eduardo Valentin 2015-01-06 13:03 ` Eduardo Valentin 2015-01-07 0:26 ` yoshihiro shimoda 2015-01-07 0:26 ` yoshihiro shimoda
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.