From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: add ioremap physical address information
Date: Tue, 6 Jan 2015 14:17:01 +0000 [thread overview]
Message-ID: <20150106141701.GC3484@arm.com> (raw)
In-Reply-To: <CAHkaATSM=V+BNZvAXC+VG6NDjOK9m0ZP3Q=SUaoxtgDw4SKZog@mail.gmail.com>
On Fri, Dec 26, 2014 at 04:52:10PM +0000, Min-Hua Chen wrote:
> In /proc/vmallocinfo, it's good to show the physical address
> of each ioremap in vmallocinfo. Add physical address information
> in arm64 ioremap.
>
> 0xffffc900047f2000-0xffffc900047f4000 8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8100000 ioremap
> 0xffffc900047f4000-0xffffc900047f6000 8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8008000 ioremap
> 0xffffc90004800000-0xffffc90004821000 135168 e1000_probe+0x22c/0xb95
> [e1000e] phys=f4300000 ioremap
> 0xffffc900049c0000-0xffffc900049e1000 135168 _nv013521rm+0x4d/0xd0
> [nvidia] phys=e0140000 ioremap
>
> Signed-off-by: Min-Hua Chen <orca.chen@gmail.com>
> ---
Thanks, this looks useful for debugging.
Acked-by: Will Deacon <will.deacon@arm.com>
I assume this can wait for 3.20?
Will
> arch/arm64/mm/ioremap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
> index cbb99c8..01e88c8 100644
> --- a/arch/arm64/mm/ioremap.c
> +++ b/arch/arm64/mm/ioremap.c
> @@ -62,6 +62,7 @@ static void __iomem *__ioremap_caller(phys_addr_t
> phys_addr, size_t size,
> if (!area)
> return NULL;
> addr = (unsigned long)area->addr;
> + area->phys_addr = phys_addr;
>
> err = ioremap_page_range(addr, addr + size, phys_addr, prot);
> if (err) {
> --
> 1.7.10.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Min-Hua Chen <orca.chen@gmail.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: add ioremap physical address information
Date: Tue, 6 Jan 2015 14:17:01 +0000 [thread overview]
Message-ID: <20150106141701.GC3484@arm.com> (raw)
In-Reply-To: <CAHkaATSM=V+BNZvAXC+VG6NDjOK9m0ZP3Q=SUaoxtgDw4SKZog@mail.gmail.com>
On Fri, Dec 26, 2014 at 04:52:10PM +0000, Min-Hua Chen wrote:
> In /proc/vmallocinfo, it's good to show the physical address
> of each ioremap in vmallocinfo. Add physical address information
> in arm64 ioremap.
>
> 0xffffc900047f2000-0xffffc900047f4000 8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8100000 ioremap
> 0xffffc900047f4000-0xffffc900047f6000 8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8008000 ioremap
> 0xffffc90004800000-0xffffc90004821000 135168 e1000_probe+0x22c/0xb95
> [e1000e] phys=f4300000 ioremap
> 0xffffc900049c0000-0xffffc900049e1000 135168 _nv013521rm+0x4d/0xd0
> [nvidia] phys=e0140000 ioremap
>
> Signed-off-by: Min-Hua Chen <orca.chen@gmail.com>
> ---
Thanks, this looks useful for debugging.
Acked-by: Will Deacon <will.deacon@arm.com>
I assume this can wait for 3.20?
Will
> arch/arm64/mm/ioremap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
> index cbb99c8..01e88c8 100644
> --- a/arch/arm64/mm/ioremap.c
> +++ b/arch/arm64/mm/ioremap.c
> @@ -62,6 +62,7 @@ static void __iomem *__ioremap_caller(phys_addr_t
> phys_addr, size_t size,
> if (!area)
> return NULL;
> addr = (unsigned long)area->addr;
> + area->phys_addr = phys_addr;
>
> err = ioremap_page_range(addr, addr + size, phys_addr, prot);
> if (err) {
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2015-01-06 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 16:52 [PATCH] arm64: add ioremap physical address information Min-Hua Chen
2014-12-26 16:52 ` Min-Hua Chen
2015-01-06 14:17 ` Will Deacon [this message]
2015-01-06 14:17 ` Will Deacon
2015-01-06 14:58 ` Min-Hua Chen
2015-01-06 14:58 ` Min-Hua Chen
2015-01-23 15:29 ` Catalin Marinas
2015-01-23 15:29 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106141701.GC3484@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.