From: Thierry Reding <thierry.reding@gmail.com>
To: Mikko Perttunen <mikko.perttunen@kapsi.fi>
Cc: swarren@wwwdotorg.org, gnurou@gmail.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, wni@nvidia.com,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH v5 3/3] ARM: tegra: Add thermal reset (thermtrip) support to PMC
Date: Tue, 6 Jan 2015 16:14:28 +0100 [thread overview]
Message-ID: <20150106151427.GQ31830@ulmo.nvidia.com> (raw)
In-Reply-To: <1420541578-27968-4-git-send-email-mikko.perttunen@kapsi.fi>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On Tue, Jan 06, 2015 at 12:52:58PM +0200, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@nvidia.com>
>
> This adds a device tree controlled option to enable PMC-based
> thermal reset in overheating situations. Thermtrip is supported on
> Tegra30, Tegra114 and Tegra124. The thermal reset only works when
> the thermal sensors are calibrated, so a soctherm driver is also
> required.
>
> The thermtrip event is triggered by the soctherm block, and all
> soctherm sensors default to showing a temperature of zero Celsius
> before they are initialized. Because of this, it is safe to initialize
> thermtrip and soctherm in any order.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/soc/tegra/pmc.c | 107 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 107 insertions(+)
This looks good to me. I'm not sure if I asked before, but can this be
tested? Can we somehow trick thermtrip into reporting a temperature that
would trigger this?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/3] ARM: tegra: Add thermal reset (thermtrip) support to PMC
Date: Tue, 6 Jan 2015 16:14:28 +0100 [thread overview]
Message-ID: <20150106151427.GQ31830@ulmo.nvidia.com> (raw)
In-Reply-To: <1420541578-27968-4-git-send-email-mikko.perttunen@kapsi.fi>
On Tue, Jan 06, 2015 at 12:52:58PM +0200, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@nvidia.com>
>
> This adds a device tree controlled option to enable PMC-based
> thermal reset in overheating situations. Thermtrip is supported on
> Tegra30, Tegra114 and Tegra124. The thermal reset only works when
> the thermal sensors are calibrated, so a soctherm driver is also
> required.
>
> The thermtrip event is triggered by the soctherm block, and all
> soctherm sensors default to showing a temperature of zero Celsius
> before they are initialized. Because of this, it is safe to initialize
> thermtrip and soctherm in any order.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/soc/tegra/pmc.c | 107 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 107 insertions(+)
This looks good to me. I'm not sure if I asked before, but can this be
tested? Can we somehow trick thermtrip into reporting a temperature that
would trigger this?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150106/e4994fee/attachment.sig>
next prev parent reply other threads:[~2015-01-06 15:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 10:52 [PATCH v5 REPOST 0/3] Thermal reset support in PMC Mikko Perttunen
2015-01-06 10:52 ` Mikko Perttunen
2015-01-06 10:52 ` Mikko Perttunen
2015-01-06 10:52 ` [PATCH v5 1/3] of: Add descriptions of thermtrip properties to Tegra PMC bindings Mikko Perttunen
2015-01-06 10:52 ` Mikko Perttunen
2015-01-06 15:09 ` Thierry Reding
2015-01-06 15:09 ` Thierry Reding
2015-01-06 15:09 ` Thierry Reding
2015-01-06 10:52 ` [PATCH v5 2/3] ARM: tegra: Add PMC thermtrip programming to Jetson TK1 device tree Mikko Perttunen
2015-01-06 10:52 ` Mikko Perttunen
[not found] ` <1420541578-27968-1-git-send-email-mikko.perttunen-/1wQRMveznE@public.gmane.org>
2015-01-06 10:52 ` [PATCH v5 3/3] ARM: tegra: Add thermal reset (thermtrip) support to PMC Mikko Perttunen
2015-01-06 10:52 ` Mikko Perttunen
2015-01-06 10:52 ` Mikko Perttunen
2015-01-06 15:14 ` Thierry Reding [this message]
2015-01-06 15:14 ` Thierry Reding
2015-01-06 15:56 ` Mikko Perttunen
2015-01-06 15:56 ` Mikko Perttunen
-- strict thread matches above, loose matches on Subject: below --
2014-11-14 11:50 [PATCH v5 0/3] Thermal reset support in PMC Mikko Perttunen
2014-11-14 11:50 ` [PATCH v5 3/3] ARM: tegra: Add thermal reset (thermtrip) support to PMC Mikko Perttunen
2014-11-14 11:50 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106151427.GQ31830@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mikko.perttunen@kapsi.fi \
--cc=mperttunen@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.