[meta-networking][PATCH 0/2] world build fixes

[meta-networking][PATCH 0/2] world build fixes

[Armin Kuster]

this should address the RDEPENDS issue found in world build

Armin Kuster (2):
  proftpd: fix rdepends  issue
  netkit-rwho: fix rdepends issue

 meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb       | 2 +-
 meta-networking/recipes-netkit/netkit-rwho/netkit-rwho_0.17.bb | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
1.9.1

[meta-networking][PATCH 1/2] proftpd: fix rdepends issue

[Armin Kuster]

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
index cba39e8..7d285a0 100644
--- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
+++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
@@ -99,4 +99,4 @@ USERADD_PARAM_${PN} = "--system -g ${FTPGROUP} --home-dir /var/lib/${FTPUSER} --
 
 FILES_${PN} += "/home/${FTPUSER}"
 
-RDEPENDS_${PN} += "perl"
+RDEPENDS_${PN} += "perl initscripts-functions"
-- 
1.9.1

Re: [meta-networking][PATCH 1/2] proftpd: fix rdepends issue

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

On Tue, Jan 06, 2015 at 07:59:19AM -0800, Armin Kuster wrote:
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> index cba39e8..7d285a0 100644
> --- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> +++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> @@ -99,4 +99,4 @@ USERADD_PARAM_${PN} = "--system -g ${FTPGROUP} --home-dir /var/lib/${FTPUSER} --
>  
>  FILES_${PN} += "/home/${FTPUSER}"
>  
> -RDEPENDS_${PN} += "perl"
> +RDEPENDS_${PN} += "perl initscripts-functions"

It's not that simple.

The initscripts-functions is added to RDEPENDS conditionally based on
"sysvinit" in DISTRO_FEATURES and INHIBIT_UPDATERCD_BBCLASS.

Adding it explicitly here will pull it to image even for people who
care only about systemd services (and don't want any iniscripts to
pollute their startup sequence).

See meta/classes/update-rc.d.bbclass

I know we already have one recipe like this:
meta-oe/recipes-connectivity/krb5/krb5_1.12.2.bb:RDEPENDS_${PN} += "initscripts-functions"

but honestly silencing this warning like this does more harm then
the warning. I think it should be fixed in bbclass, because all
recipes which inherit it, suffer from this. Maybe by adding another
VIRTUAL_RUNTIME which can be set to empty when sysv isn't enabled.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-networking][PATCH 1/2] proftpd: fix rdepends issue

[Paul Eggleton]

On Tuesday 06 January 2015 17:26:10 Martin Jansa wrote:
> On Tue, Jan 06, 2015 at 07:59:19AM -0800, Armin Kuster wrote:
> > Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > ---
> > 
> >  meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> > b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb index
> > cba39e8..7d285a0 100644
> > --- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> > +++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> > @@ -99,4 +99,4 @@ USERADD_PARAM_${PN} = "--system -g ${FTPGROUP}
> > --home-dir /var/lib/${FTPUSER} --> 
> >  FILES_${PN} += "/home/${FTPUSER}"
> > 
> > -RDEPENDS_${PN} += "perl"
> > +RDEPENDS_${PN} += "perl initscripts-functions"
> 
> It's not that simple.
> 
> The initscripts-functions is added to RDEPENDS conditionally based on
> "sysvinit" in DISTRO_FEATURES and INHIBIT_UPDATERCD_BBCLASS.
> 
> Adding it explicitly here will pull it to image even for people who
> care only about systemd services (and don't want any iniscripts to
> pollute their startup sequence).
> 
> See meta/classes/update-rc.d.bbclass
> 
> I know we already have one recipe like this:
> meta-oe/recipes-connectivity/krb5/krb5_1.12.2.bb:RDEPENDS_${PN} +=
> "initscripts-functions"
> 
> but honestly silencing this warning like this does more harm then
> the warning. I think it should be fixed in bbclass, because all
> recipes which inherit it, suffer from this. Maybe by adding another
> VIRTUAL_RUNTIME which can be set to empty when sysv isn't enabled.

What about just adding initscripts to DEPENDS in update-rc.d.bbclass ? At 
least then the package would get built.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [meta-networking][PATCH 1/2] proftpd: fix rdepends issue

[akuster808]

On 01/06/2015 08:26 AM, Martin Jansa wrote:
> On Tue, Jan 06, 2015 at 07:59:19AM -0800, Armin Kuster wrote:
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>   meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
>> index cba39e8..7d285a0 100644
>> --- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
>> +++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
>> @@ -99,4 +99,4 @@ USERADD_PARAM_${PN} = "--system -g ${FTPGROUP} --home-dir /var/lib/${FTPUSER} --
>>
>>   FILES_${PN} += "/home/${FTPUSER}"
>>
>> -RDEPENDS_${PN} += "perl"
>> +RDEPENDS_${PN} += "perl initscripts-functions"
>
> It's not that simple.

Had to try :)
>
> The initscripts-functions is added to RDEPENDS conditionally based on
> "sysvinit" in DISTRO_FEATURES and INHIBIT_UPDATERCD_BBCLASS.
>
> Adding it explicitly here will pull it to image even for people who
> care only about systemd services (and don't want any iniscripts to
> pollute their startup sequence).

make sense.

>
> See meta/classes/update-rc.d.bbclass

thanks for the reference.
>
> I know we already have one recipe like this:
> meta-oe/recipes-connectivity/krb5/krb5_1.12.2.bb:RDEPENDS_${PN} += "initscripts-functions"
>
> but honestly silencing this warning like this does more harm then
> the warning. I think it should be fixed in bbclass, because all
> recipes which inherit it, suffer from this. Maybe by adding another
> VIRTUAL_RUNTIME which can be set to empty when sysv isn't enabled.

k.

Does the 5 second rule count ? or because I touched it I am stuck with 
it ; )

I will take a look.

thanks,
Armin
>
>
>

Re: [meta-networking][PATCH 1/2] proftpd: fix rdepends issue

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

[Re: [oe] [meta-networking][PATCH 1/2] proftpd: fix rdepends  issue] On 15.01.06 (Tue 17:48) akuster808 wrote:

> 
> 
> On 01/06/2015 08:26 AM, Martin Jansa wrote:
> >On Tue, Jan 06, 2015 at 07:59:19AM -0800, Armin Kuster wrote:
> >>Signed-off-by: Armin Kuster <akuster808@gmail.com>
> >>---
> >>  meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> >>index cba39e8..7d285a0 100644
> >>--- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> >>+++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.5.bb
> >>@@ -99,4 +99,4 @@ USERADD_PARAM_${PN} = "--system -g ${FTPGROUP} --home-dir /var/lib/${FTPUSER} --
> >>
> >>  FILES_${PN} += "/home/${FTPUSER}"
> >>
> >>-RDEPENDS_${PN} += "perl"
> >>+RDEPENDS_${PN} += "perl initscripts-functions"
> >
> >It's not that simple.
> 
> Had to try :)
> >
> >The initscripts-functions is added to RDEPENDS conditionally based on
> >"sysvinit" in DISTRO_FEATURES and INHIBIT_UPDATERCD_BBCLASS.
> >
> >Adding it explicitly here will pull it to image even for people who
> >care only about systemd services (and don't want any iniscripts to
> >pollute their startup sequence).
> 
> make sense.
> 
> >
> >See meta/classes/update-rc.d.bbclass
> 
> thanks for the reference.
> >
> >I know we already have one recipe like this:
> >meta-oe/recipes-connectivity/krb5/krb5_1.12.2.bb:RDEPENDS_${PN} += "initscripts-functions"
> >
> >but honestly silencing this warning like this does more harm then
> >the warning. I think it should be fixed in bbclass, because all
> >recipes which inherit it, suffer from this. Maybe by adding another
> >VIRTUAL_RUNTIME which can be set to empty when sysv isn't enabled.
> 
> k.
> 
> Does the 5 second rule count ? or because I touched it I am stuck
> with it ; )

If you invoke the five-second-rule, I think it can apply, but if you're
anything like me, once you step in something it's almost impossible to
pretend you didn't.  ;-)

-J.

> 
> I will take a look.
> 
> thanks,
> Armin
> >
> >
> >
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]

[meta-networking][PATCH 2/2] netkit-rwho: fix rdepends issue

[Armin Kuster]

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-networking/recipes-netkit/netkit-rwho/netkit-rwho_0.17.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-networking/recipes-netkit/netkit-rwho/netkit-rwho_0.17.bb b/meta-networking/recipes-netkit/netkit-rwho/netkit-rwho_0.17.bb
index 4433dc1..9072629 100644
--- a/meta-networking/recipes-netkit/netkit-rwho/netkit-rwho_0.17.bb
+++ b/meta-networking/recipes-netkit/netkit-rwho/netkit-rwho_0.17.bb
@@ -81,3 +81,5 @@ FILES_${PN}-server = "${sbindir}/* ${localstatedir} ${sysconfdir}/default/* ${sy
 FILES_${PN}-doc = "${mandir}"
 FILES_${PN}-dbg = "${prefix}/src/debug \
             ${bindir}/.debug ${sbindir}/.debug"
+
+RDEPENDS_${PN} += "initscripts-functions"
-- 
1.9.1